Vocabulary search using "0" as the query argument throws an error

[Ohiekkar]

At which URL did you encounter the problem?

https://api.finto.fi/rest/v1/ykl/search

What steps will reproduce the problem?

1. GET https://api.finto.fi/rest/v1/ykl/search?query=0

What is the expected output? What do you see instead?

As searching by notation is a thing and 0 is a valid notation I would expect the search to work and find this item: http://urn.fi/URN:NBN:fi:au:ykl:0, just like it works with https://api.finto.fi/rest/v1/ykl/search?query=1.

Currently it throws 400 Bad Request : query parameter missing. I'd assume this comes from php evaluating "0" to false

[kinow]

I think your analysis of the problem is spot-on @Ohiekkar ! See linked PR for a tentative fix. Thanks!

[osma]

Thanks for the report @Ohiekkar, and the quick confirmation and PR @kinow! I believe this affects not just the REST API but also the search in the web UI. Example:

• http://finto.fi/ykl/en/search?q=1 returns 43 results (classes with a notation beginning with 1 - prefix search is implicit here)
• http://finto.fi/ykl/en/search?q=0 returns an empty result

[osma]

The REST side was fixed in PR #1261 but the web UI search still suffers from the same problem (see above comment). I'm reopening this issue to keep track of the problem on the web UI side.

[osma]

Like @Ohiekkar mentioned above, the problem stems from PHP evaluating "0" to false. For the REST API, it was fixed in #1261 by changing the test in RestController from this:

Skosmos/controller/RestController.php

Line 178 in 21796ca

if (!$term && (!$request->getQueryParam('group') && !$request->getQueryParam('parent'))) {

to this:

Skosmos/controller/RestController.php

Line 178 in 52e7079

if ((!isset($term) || strlen(trim($term)) === 0) && (!$request->getQueryParam('group') && !$request->getQueryParam('parent'))) {

Now a similar problem still exists on the web UI side - we need to avoid evaluating $term (or similar variables/expressions containing the search term) directly and instead do a more careful check of the contents, for example with isset and strlen as above.

I suspect that at least this test in ConceptSearchParameters needs to be changed as !$term will evaluate to true if $term is "0":

Skosmos/model/ConceptSearchParameters.php

Line 71 in 52e7079

if (!$term && $this->rest)