fix: only generate metadata for the targeted arch #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edusperoni
force-pushed
the
fix/metadata-arch-target
branch
from
43a6d43 to
4b8ac56
Compare
edusperoni
force-pushed
the
fix/metadata-arch-target
branch
from
4b8ac56 to
e741cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nsld.shis usually invoked per target architecture.Right now, we generate metadata for all valid architectures from
env[ARCH]. This can cause issues in case we run mutiple builds in parallel (one for each target architecture) in which case both metadata generators output to the same files likely causing file corruption.With these changes, in case a first argument is passed to the metadata generator python script, we skip architectures that don't match the argument.
This way, in case the metadata generation is invoked via nsld - we pass through the target architecture.