From fc8c05ecadedbe45223660a32bf97d2d04aae420 Mon Sep 17 00:00:00 2001
From: TsvetanMilanov <tsvetan.milanov17@gmail.com>
Date: Tue, 22 Mar 2016 17:47:32 +0200
Subject: [PATCH 1/2] Simplified creating angular template project

Added angular and ng values for --template option which will use https://github.com/NativeScript/template-hello-world-ng.
Added --ng option in the create command which is equal to --template ng and --template angular.
Added unit tests.
Fix copying hidden files when creating project.
---
 docs/man_pages/project/creation/create.md |   4 +-
 lib/commands/create-project.ts            |  12 ++-
 lib/constants.ts                          |   2 +
 lib/declarations.ts                       |  39 ++++----
 lib/npm-installation-manager.ts           |   3 +-
 lib/options.ts                            |   3 +-
 lib/services/project-service.ts           |   2 +
 lib/services/project-templates-service.ts |   4 +-
 test/project-commands.ts                  | 114 ++++++++++++++++++++++
 test/project-service.ts                   |  26 +++++
 10 files changed, 185 insertions(+), 24 deletions(-)
 create mode 100644 test/project-commands.ts

diff --git a/docs/man_pages/project/creation/create.md b/docs/man_pages/project/creation/create.md
index 90379eef9b..e3910f5cef 100644
--- a/docs/man_pages/project/creation/create.md
+++ b/docs/man_pages/project/creation/create.md
@@ -4,7 +4,8 @@ create
 Usage | Synopsis
 ---|---
 Create from default JavaScript template | `$ tns create <App Name> [--path <Directory>] [--appid <App ID>]`
-Create from default TypeScript template | `$ tns create <App Name> [--path <Directory>] [--appid <App ID> --template typescript` OR `$ tns create <App Name> [--path <Directory>] [--appid <App ID> --template tsc`
+Create from default TypeScript template | `$ tns create <App Name> --template typescript [--path <Directory>] [--appid <App ID>]` OR `$ tns create <App Name> --template tsc [--path <Directory>] [--appid <App ID>]`
+Create from default Angular template | `$ tns create <App Name> --template angular [--path <Directory>] [--appid <App ID>]` OR `$ tns create <App Name> --template ng [--path <Directory>] [--appid <App ID>]` OR `$ tns create <App Name> --ng [--path <Directory>] [--appid <App ID>]`
 Copy from existing project | `$ tns create <App Name> [--path <Directory>] [--appid <App ID>] --copy-from <Directory>`
 Create from custom template | `$ tns create <App Name> [--path <Directory>] [--appid <App ID>] --template <Template>`
 
@@ -15,6 +16,7 @@ Creates a new project for native development with NativeScript.
 * `--appid` - Sets the application identifier for your project.
 * `--copy-from` - Specifies a directory which contains an existing NativeScript project. If `--copy-from` and `--template` are not set, the NativeScript CLI creates the project from the default JavaScript hello-world template.
 * `--template` - Specifies a valid npm package which you want to use to create your project. If `--copy-from` and `--template` are not set, the NativeScript CLI creates the project from the default JavaScript hello-world template.<% if(isHtml) { %> If one or more application assets are missing from the `App_Resources` directory in the package, the CLI adds them using the assets available in the default hello-world template.<% } %>
+* `--ng` - Sets the template for your project to the Angular template.
 
 ### Attributes
 * `<App Name>` is the name of project. The specified name must meet the requirements of all platforms that you want to target. <% if(isConsole) { %>For more information about the `<App Name>` requirements, run `$ tns help create`<% } %><% if(isHtml) { %>For projects that target Android, you can use uppercase or lowercase letters, numbers, and underscores. The name must start with a letter.
diff --git a/lib/commands/create-project.ts b/lib/commands/create-project.ts
index 14683a192b..de3aab1e01 100644
--- a/lib/commands/create-project.ts
+++ b/lib/commands/create-project.ts
@@ -1,6 +1,8 @@
 ///<reference path="../.d.ts"/>
 "use strict";
 
+import * as constants from "../constants";
+
 export class ProjectCommandParameter implements ICommandParameter {
 	constructor(private $errors: IErrors,
 		private $logger: ILogger,
@@ -27,12 +29,20 @@ export class CreateProjectCommand implements ICommand {
 		private $errors: IErrors,
 		private $logger: ILogger,
 		private $projectNameValidator: IProjectNameValidator,
-		private $options: ICommonOptions) { }
+		private $options: IOptions) { }
 
 	public enableHooks = false;
 
 	execute(args: string[]): IFuture<void> {
 		return (() => {
+			if (this.$options.ng && this.$options.template) {
+				this.$errors.fail("You cannot use --ng and --template simultaneously.");
+			}
+
+			if (this.$options.ng) {
+				this.$options.template = constants.ANGULAR_NAME;
+			}
+
 			this.$projectService.createProject(args[0], this.$options.template).wait();
 		}).future<void>()();
 	}
diff --git a/lib/constants.ts b/lib/constants.ts
index 776ab20349..f0f5271788 100644
--- a/lib/constants.ts
+++ b/lib/constants.ts
@@ -42,3 +42,5 @@ class ItunesConnectApplicationTypesClass implements IiTunesConnectApplicationTyp
 }
 
 export let ItunesConnectApplicationTypes = new ItunesConnectApplicationTypesClass();
+
+export let ANGULAR_NAME = "angular";
diff --git a/lib/declarations.ts b/lib/declarations.ts
index 3b43db110a..05ead7b796 100644
--- a/lib/declarations.ts
+++ b/lib/declarations.ts
@@ -58,32 +58,33 @@ interface ILiveSyncService {
 }
 
 interface IOptions extends ICommonOptions {
-	ipa: string;
-	frameworkPath: string;
-	frameworkName: string;
-	framework: string;
-	frameworkVersion: string;
+	baseConfig: string;
+	client: boolean;
+	compileSdk: number;
 	copyFrom: string;
-	linkTo: string;
+	copyTo: string;
+	debugTransport: boolean;
 	emulator: boolean;
-	symlink: boolean;
 	forDevice: boolean;
-	client: boolean;
-	production: boolean;
-	keyStorePath: string;
-	keyStorePassword: string;
+	framework: string;
+	frameworkName: string;
+	frameworkPath: string;
+	frameworkVersion: string;
+	ignoreScripts: boolean;
+	ipa: string;
 	keyStoreAlias: string;
 	keyStoreAliasPassword: string;
+	keyStorePassword: string;
+	keyStorePath: string;
+	linkTo: string;
+	ng: boolean;
+	platformTemplate: string;
+	port: Number;
+	production: boolean;
 	sdk: string;
-	debugTransport: boolean;
-	ignoreScripts: boolean;
-	tnsModulesVersion: string;
 	staticBindings: boolean;
-	compileSdk: number;
-	port: Number;
-	copyTo: string;
-	baseConfig: string;
-	platformTemplate: string;
+	symlink: boolean;
+	tnsModulesVersion: string;
 }
 
 interface IInitService {
diff --git a/lib/npm-installation-manager.ts b/lib/npm-installation-manager.ts
index 1440d88033..9b5acbb950 100644
--- a/lib/npm-installation-manager.ts
+++ b/lib/npm-installation-manager.ts
@@ -20,7 +20,8 @@ export class NpmInstallationManager implements INpmInstallationManager {
 		"tns-ios": constants.PROJECT_FRAMEWORK_FOLDER_NAME,
 		"tns-ios-inspector": "WebInspectorUI",
 		"tns-template-hello-world": constants.APP_RESOURCES_FOLDER_NAME,
-		"tns-template-hello-world-ts": constants.APP_RESOURCES_FOLDER_NAME
+		"tns-template-hello-world-ts": constants.APP_RESOURCES_FOLDER_NAME,
+		"tns-template-hello-world-ng": constants.APP_RESOURCES_FOLDER_NAME
 	};
 
 	constructor(private $npm: INodePackageManager,
diff --git a/lib/options.ts b/lib/options.ts
index 2b9311b4b1..d388b801dc 100644
--- a/lib/options.ts
+++ b/lib/options.ts
@@ -35,7 +35,8 @@ export class Options extends commonOptionsLibPath.OptionsBase {
 			port: { type: OptionType.Number },
 			copyTo: { type: OptionType.String },
 			baseConfig: { type: OptionType.String },
-			platformTemplate: { type: OptionType.String }
+			platformTemplate: { type: OptionType.String },
+			ng: {type: OptionType.Boolean }
 		},
 		path.join($hostInfo.isWindows ? process.env.AppData : path.join(osenv.home(), ".local/share"), ".nativescript-cli"),
 			$errors, $staticConfig);
diff --git a/lib/services/project-service.ts b/lib/services/project-service.ts
index d666aef6ee..f39a921801 100644
--- a/lib/services/project-service.ts
+++ b/lib/services/project-service.ts
@@ -146,6 +146,8 @@ export class ProjectService implements IProjectService {
 				this.$fs.symlink(appSourcePath, appDestinationPath).wait();
 			} else {
 				shelljs.cp('-R', path.join(appSourcePath, "*"), appDestinationPath);
+				// Copy hidden files.
+				shelljs.cp('-R', path.join(appSourcePath, ".*"), appDestinationPath);
 			}
 
 			this.createBasicProjectStructure(projectDir,  projectId).wait();
diff --git a/lib/services/project-templates-service.ts b/lib/services/project-templates-service.ts
index 9c23c5c9d7..4ffaf3df8c 100644
--- a/lib/services/project-templates-service.ts
+++ b/lib/services/project-templates-service.ts
@@ -10,7 +10,9 @@ export class ProjectTemplatesService implements IProjectTemplatesService {
 	private static RESERVED_TEMPLATE_NAMES: IStringDictionary = {
 		"default": "tns-template-hello-world",
 		"tsc": "tns-template-hello-world-ts",
-		"typescript": "tns-template-hello-world-ts"
+		"typescript": "tns-template-hello-world-ts",
+		"ng": "tns-template-hello-world-ng",
+		"angular": "tns-template-hello-world-ng"
 	};
 
 	public constructor(private $errors: IErrors,
diff --git a/test/project-commands.ts b/test/project-commands.ts
new file mode 100644
index 0000000000..f6d3df9b5a
--- /dev/null
+++ b/test/project-commands.ts
@@ -0,0 +1,114 @@
+/// <reference path=".d.ts" />
+"use strict";
+
+import * as yok from "../lib/common/yok";
+import * as stubs from "./stubs";
+import { CreateProjectCommand } from "../lib/commands/create-project";
+import * as constants from "../lib/constants";
+import {assert} from "chai";
+
+let selectedTemplateName: string;
+let isProjectCreated: boolean;
+let dummyArgsString = "dummyArgsString";
+
+class ProjectServiceMock implements IProjectService {
+	createProject(projectName: string, selectedTemplate?: string): IFuture<void> {
+		return (() => {
+			selectedTemplateName = selectedTemplate;
+			isProjectCreated = true;
+		}).future<void>()();
+	}
+}
+
+class ProjectNameValidatorMock implements IProjectNameValidator {
+	public validate(name: string): boolean {
+		return true;
+	}
+}
+
+function createTestInjector() {
+	let testInjector = new yok.Yok();
+
+	testInjector.register("injector", testInjector);
+	testInjector.register("staticConfig", {});
+	testInjector.register("projectService", ProjectServiceMock);
+	testInjector.register("errors", stubs.ErrorsStub);
+	testInjector.register("logger", stubs.LoggerStub);
+	testInjector.register("projectNameValidator", ProjectNameValidatorMock);
+	testInjector.register("options", {
+		ng: false,
+		template: undefined
+	});
+	testInjector.register("createCommand", CreateProjectCommand);
+
+	return testInjector;
+}
+
+describe('Project Service Tests', () => {
+	let testInjector: IInjector;
+
+	beforeEach(() => {
+		testInjector = createTestInjector();
+		isProjectCreated = false;
+	});
+
+	describe("project commands tests", () => {
+		describe("#CreateProjectCommand", () => {
+			it("should not fail when using only --ng.", () => {
+				let options: IOptions = testInjector.resolve("$options");
+				options.ng = true;
+
+				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
+
+				createProjectCommand.execute([dummyArgsString]).wait();
+
+				assert.isTrue(isProjectCreated);
+			});
+
+			it("should not fail when using only --template.", () => {
+				let options: IOptions = testInjector.resolve("$options");
+				options.template = "ng";
+
+				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
+
+				createProjectCommand.execute([dummyArgsString]).wait();
+
+				assert.isTrue(isProjectCreated);
+			});
+
+			it("should set the template name correctly when used --ng.", () => {
+				let options: IOptions = testInjector.resolve("$options");
+				options.ng = true;
+
+				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
+
+				createProjectCommand.execute([dummyArgsString]).wait();
+
+				assert.deepEqual(options.template, constants.ANGULAR_NAME);
+			});
+
+			it("should not set the template name when --ng is not used.", () => {
+				let options: IOptions = testInjector.resolve("$options");
+				options.ng = false;
+
+				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
+
+				createProjectCommand.execute([dummyArgsString]).wait();
+
+				assert.isUndefined(options.template);
+			});
+
+			it("should fail when --ng and --template are used simultaneously.", () => {
+				let options: IOptions = testInjector.resolve("$options");
+				options.ng = true;
+				options.template = "ng";
+
+				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
+
+				assert.throws(() => {
+					createProjectCommand.execute([dummyArgsString]).wait();
+				});
+			});
+		});
+	});
+});
diff --git a/test/project-service.ts b/test/project-service.ts
index 1a60810be8..65f0c66bb8 100644
--- a/test/project-service.ts
+++ b/test/project-service.ts
@@ -210,6 +210,32 @@ describe("Project Service Tests", () => {
 			projectIntegrationTest.assertProject(tempFolder, projectName, "org.nativescript.myapp", projectTemplatesService.prepareTemplate("tsc").wait()).wait();
 		});
 
+		it("creates valid project from angular template", () => {
+			let projectIntegrationTest = new ProjectIntegrationTest();
+			let tempFolder = temp.mkdirSync("projectAngular");
+			let projectName = "myapp";
+			let options = projectIntegrationTest.testInjector.resolve("options");
+
+			options.path = tempFolder;
+			projectIntegrationTest.createProject(projectName, "angular").wait();
+
+			let projectTemplatesService: IProjectTemplatesService = projectIntegrationTest.testInjector.resolve("projectTemplatesService");
+			projectIntegrationTest.assertProject(tempFolder, projectName, "org.nativescript.myapp", projectTemplatesService.prepareTemplate("angular").wait()).wait();
+		});
+
+		it("creates valid project from ng template", () => {
+			let projectIntegrationTest = new ProjectIntegrationTest();
+			let tempFolder = temp.mkdirSync("projectNg");
+			let projectName = "myapp";
+			let options = projectIntegrationTest.testInjector.resolve("options");
+
+			options.path = tempFolder;
+			projectIntegrationTest.createProject(projectName, "ng").wait();
+
+			let projectTemplatesService: IProjectTemplatesService = projectIntegrationTest.testInjector.resolve("projectTemplatesService");
+			projectIntegrationTest.assertProject(tempFolder, projectName, "org.nativescript.myapp", projectTemplatesService.prepareTemplate("ng").wait()).wait();
+		});
+
 		it("creates valid project from local directory template", () => {
 			let projectIntegrationTest = new ProjectIntegrationTest();
 			let tempFolder = temp.mkdirSync("projectLocalDir");

From 28202a763d9c571dd688499eee92c694c8f15782 Mon Sep 17 00:00:00 2001
From: TsvetanMilanov <tsvetan.milanov17@gmail.com>
Date: Wed, 23 Mar 2016 11:03:15 +0200
Subject: [PATCH 2/2] PR comments.

---
 lib/commands/create-project.ts |  6 +--
 test/project-commands.ts       | 82 +++++++++++++++-------------------
 2 files changed, 37 insertions(+), 51 deletions(-)

diff --git a/lib/commands/create-project.ts b/lib/commands/create-project.ts
index de3aab1e01..ebd1ee9a10 100644
--- a/lib/commands/create-project.ts
+++ b/lib/commands/create-project.ts
@@ -39,11 +39,9 @@ export class CreateProjectCommand implements ICommand {
 				this.$errors.fail("You cannot use --ng and --template simultaneously.");
 			}
 
-			if (this.$options.ng) {
-				this.$options.template = constants.ANGULAR_NAME;
-			}
+			let selectedTemplate = this.$options.ng ? constants.ANGULAR_NAME : this.$options.template;
 
-			this.$projectService.createProject(args[0], this.$options.template).wait();
+			this.$projectService.createProject(args[0], selectedTemplate).wait();
 		}).future<void>()();
 	}
 
diff --git a/test/project-commands.ts b/test/project-commands.ts
index f6d3df9b5a..09ddff1185 100644
--- a/test/project-commands.ts
+++ b/test/project-commands.ts
@@ -1,7 +1,7 @@
 /// <reference path=".d.ts" />
 "use strict";
 
-import * as yok from "../lib/common/yok";
+import { Yok } from "../lib/common/yok";
 import * as stubs from "./stubs";
 import { CreateProjectCommand } from "../lib/commands/create-project";
 import * as constants from "../lib/constants";
@@ -9,7 +9,7 @@ import {assert} from "chai";
 
 let selectedTemplateName: string;
 let isProjectCreated: boolean;
-let dummyArgsString = "dummyArgsString";
+let dummyArgs = ["dummyArgsString"];
 
 class ProjectServiceMock implements IProjectService {
 	createProject(projectName: string, selectedTemplate?: string): IFuture<void> {
@@ -27,7 +27,7 @@ class ProjectNameValidatorMock implements IProjectNameValidator {
 }
 
 function createTestInjector() {
-	let testInjector = new yok.Yok();
+	let testInjector = new Yok();
 
 	testInjector.register("injector", testInjector);
 	testInjector.register("staticConfig", {});
@@ -44,70 +44,58 @@ function createTestInjector() {
 	return testInjector;
 }
 
-describe('Project Service Tests', () => {
+describe("Project commands tests", () => {
 	let testInjector: IInjector;
+	let options: IOptions;
+	let createProjectCommand: ICommand;
 
 	beforeEach(() => {
 		testInjector = createTestInjector();
 		isProjectCreated = false;
+		selectedTemplateName = undefined;
+		options = testInjector.resolve("$options");
+		createProjectCommand = testInjector.resolve("$createCommand");
 	});
 
-	describe("project commands tests", () => {
-		describe("#CreateProjectCommand", () => {
-			it("should not fail when using only --ng.", () => {
-				let options: IOptions = testInjector.resolve("$options");
-				options.ng = true;
+	describe("#CreateProjectCommand", () => {
+		it("should not fail when using only --ng.", () => {
+			options.ng = true;
 
-				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
+			createProjectCommand.execute(dummyArgs).wait();
 
-				createProjectCommand.execute([dummyArgsString]).wait();
-
-				assert.isTrue(isProjectCreated);
-			});
-
-			it("should not fail when using only --template.", () => {
-				let options: IOptions = testInjector.resolve("$options");
-				options.template = "ng";
-
-				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
-
-				createProjectCommand.execute([dummyArgsString]).wait();
-
-				assert.isTrue(isProjectCreated);
-			});
+			assert.isTrue(isProjectCreated);
+		});
 
-			it("should set the template name correctly when used --ng.", () => {
-				let options: IOptions = testInjector.resolve("$options");
-				options.ng = true;
+		it("should not fail when using only --template.", () => {
+			options.template = "ng";
 
-				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
+			createProjectCommand.execute(dummyArgs).wait();
 
-				createProjectCommand.execute([dummyArgsString]).wait();
+			assert.isTrue(isProjectCreated);
+		});
 
-				assert.deepEqual(options.template, constants.ANGULAR_NAME);
-			});
+		it("should set the template name correctly when used --ng.", () => {
+			options.ng = true;
 
-			it("should not set the template name when --ng is not used.", () => {
-				let options: IOptions = testInjector.resolve("$options");
-				options.ng = false;
+			createProjectCommand.execute(dummyArgs).wait();
 
-				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
+			assert.deepEqual(selectedTemplateName, constants.ANGULAR_NAME);
+		});
 
-				createProjectCommand.execute([dummyArgsString]).wait();
+		it("should not set the template name when --ng is not used.", () => {
+			options.ng = false;
 
-				assert.isUndefined(options.template);
-			});
+			createProjectCommand.execute(dummyArgs).wait();
 
-			it("should fail when --ng and --template are used simultaneously.", () => {
-				let options: IOptions = testInjector.resolve("$options");
-				options.ng = true;
-				options.template = "ng";
+			assert.isUndefined(selectedTemplateName);
+		});
 
-				let createProjectCommand: ICommand = testInjector.resolve("$createCommand");
+		it("should fail when --ng and --template are used simultaneously.", () => {
+			options.ng = true;
+			options.template = "ng";
 
-				assert.throws(() => {
-					createProjectCommand.execute([dummyArgsString]).wait();
-				});
+			assert.throws(() => {
+				createProjectCommand.execute(dummyArgs).wait();
 			});
 		});
 	});