Add snapshot plugin to project package.json #2151
Conversation
jasssonpet
force-pushed
the
jasssonpet/enable-snapshot
branch
from
b35ba7c to
5f56578
Compare
|
It looks ok, but please DO NOT merge, it will hit the current CI infrastructure. |
| @@ -63,7 +63,10 @@ export class ProjectDataService implements IProjectDataService { | |||
| "description": "NativeScript Application", | |||
| "license": "SEE LICENSE IN <your-license-filename>", | |||
| "readme": "NativeScript Application", | |||
| "repository": "<fill-your-repository-here>" | |||
| "repository": "<fill-your-repository-here>", | |||
| "devDependencies": { | |||
There was a problem hiding this comment.
why the code is here? It can be added to the templates as all devDependencies from the template will be added to the currently created project:
https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/project-service.ts#L76
There was a problem hiding this comment.
In this case I prefer to add this to the templates. @jasssonpet what do you think?
There was a problem hiding this comment.
I can move it to the templates, but are we sure there aren't any templates outside the NativeScript organization? Or should I add it to the hello-world template and it will be copied like the App_Resources are?
There was a problem hiding this comment.
I've made pull requests for all three templates. No other templates outside of the organization
NativeScript/template-hello-world-ng#24
NativeScript/template-hello-world#53
NativeScript/template-hello-world-ts#14
This will enable the snapshot plugin for newly created apps.