Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tns migrate does not update @angular/animations #4878

Closed
rosen-vladimirov opened this issue Jul 17, 2019 · 0 comments
Closed

tns migrate does not update @angular/animations #4878

rosen-vladimirov opened this issue Jul 17, 2019 · 0 comments
Assignees
Labels
bug migrate Describes issues related to migrate command
Milestone

Comments

@rosen-vladimirov
Copy link
Contributor

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.0.0
  • Cross-platform modules: 5.2.0
  • Android Runtime: 5.2.0
  • iOS Runtime: 5.2.0
  • Plugin(s):
"dependencies": {
    "@angular/animations": "~7.2.0",
    "@angular/common": "~7.2.0",
    "@angular/compiler": "~7.2.0",
    "@angular/core": "~7.2.0",
    "@angular/forms": "~7.2.0",
    "@angular/http": "~7.2.0",
    "@angular/platform-browser": "~7.2.0",
    "@angular/platform-browser-dynamic": "~7.2.0",
    "@angular/router": "~7.2.0",
    "nativescript-angular": "~7.2.1",
    "nativescript-theme-core": "~1.0.4",
    "reflect-metadata": "~0.1.12",
    "rxjs": "~6.3.0",
    "tns-core-modules": "~5.2.0",
    "zone.js": "~0.8.26"
  },
  "devDependencies": {
    "@angular/compiler-cli": "~7.2.0",
    "@nativescript/schematics": "~0.5.0",
    "@ngtools/webpack": "~7.2.0",
    "nativescript-dev-typescript": "~0.8.0",
    "nativescript-dev-webpack": "~0.20.0"
  },

Describe the bug
After using tns migrate for a project with Angular 7, @angular/animations package is not updated - its still 7.x.x version.

To Reproduce

$ tns create myApp --template tns-template-hello-world-ng@5.2
$ cd myApp
$ tns migrate
# now check the project's package.json - `@angular/animations` version is still 7.x.x

Expected behavior
After migrate, the @angular/animations package should be migrated. In case it is not installed in the project before calling tns migrate, the migrate command should not add it.

Additional context
WORKAROUND: npm i --save-dev @angular/animations@~8.0

@rosen-vladimirov rosen-vladimirov added bug migrate Describes issues related to migrate command labels Jul 17, 2019
@rosen-vladimirov rosen-vladimirov added this to the 6.0.1 milestone Jul 17, 2019
@rosen-vladimirov rosen-vladimirov changed the title tns migrate should update @angular/animations tns migrate does not update @angular/animations Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug migrate Describes issues related to migrate command
Projects
None yet
Development

No branches or pull requests

3 participants