fix: Re-enable inspector code

Uncomment the code that starts the inspector. However, comment out the parts that don't work yet. At this point, the JsV8InspectorClient compiles, but doesn't do anything.
NativeScript · Mar 20, 2023 · 14faf01 · 14faf01
1 parent 4a23795
commit 14faf01
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 24 deletions.
diff --git a/NativeScript/NativeScript.mm b/NativeScript/NativeScript.mm
@@ -1,6 +1,6 @@
 #include <Foundation/Foundation.h>
 #include "NativeScript.h"
-// #include "inspector/JsV8InspectorClient.h"
+#include "inspector/JsV8InspectorClient.h"
 #include "runtime/RuntimeConfig.h"
 #include "runtime/Helpers.h"
 #include "runtime/Runtime.h"
@@ -45,14 +45,14 @@ - (instancetype)initWithConfig:(Config*)config {
         auto duration = std::chrono::duration_cast<std::chrono::milliseconds>(t2 - t1).count();
         printf("Runtime initialization took %llims\n", duration);
 
-        // if (config.IsDebug) {
-        //     Isolate::Scope isolate_scope(isolate);
-        //     HandleScope handle_scope(isolate);
-        //     v8_inspector::JsV8InspectorClient* inspectorClient = new v8_inspector::JsV8InspectorClient(runtime_.get());
-        //     inspectorClient->init();
-        //     inspectorClient->registerModules();
-        //     inspectorClient->connect([config ArgumentsCount], [config Arguments]);
-        // }
+        if (config.IsDebug) {
+            Isolate::Scope isolate_scope(isolate);
+            HandleScope handle_scope(isolate);
+            v8_inspector::JsV8InspectorClient* inspectorClient = new v8_inspector::JsV8InspectorClient(runtime_.get());
+            inspectorClient->init();
+            inspectorClient->registerModules();
+            inspectorClient->connect([config ArgumentsCount], [config Arguments]);
+        }
     }
 
     return self;

diff --git a/NativeScript/inspector/JsV8InspectorClient.cpp b/NativeScript/inspector/JsV8InspectorClient.cpp
@@ -1,6 +1,6 @@
 #include <stdio.h>
 #include "JsV8InspectorClient.h"
-#include "src/inspector/v8-inspector-session-impl.h"
+//#include "src/inspector/v8-inspector-session-impl.h"
 #include "Helpers.h"
 
 using namespace v8;
@@ -14,19 +14,19 @@ void JsV8InspectorClient::inspectorSendEventCallback(const FunctionCallbackInfo<
     Local<v8::String> arg = args[0].As<v8::String>();
     std::string message = tns::ToString(isolate, arg);
 
-    if (message.find("\"Network.") != std::string::npos) {
-        // The Network domain is handled directly by the corresponding backend
-        V8InspectorSessionImpl* session = (V8InspectorSessionImpl*)client->session_.get();
-        session->networkArgent()->dispatch(message);
-        return;
-    }
-
-    if (message.find("\"DOM.") != std::string::npos) {
-        // The DOM domain is handled directly by the corresponding backend
-        V8InspectorSessionImpl* session = (V8InspectorSessionImpl*)client->session_.get();
-        session->domArgent()->dispatch(message);
-        return;
-    }
+//    if (message.find("\"Network.") != std::string::npos) {
+//        // The Network domain is handled directly by the corresponding backend
+//        V8InspectorSessionImpl* session = (V8InspectorSessionImpl*)client->session_.get();
+//        session->networkArgent()->dispatch(message);
+//        return;
+//    }
+//
+//    if (message.find("\"DOM.") != std::string::npos) {
+//        // The DOM domain is handled directly by the corresponding backend
+//        V8InspectorSessionImpl* session = (V8InspectorSessionImpl*)client->session_.get();
+//        session->domArgent()->dispatch(message);
+//        return;
+//    }
 
     client->dispatchMessage(message);
 }

diff --git a/NativeScript/inspector/JsV8InspectorClient.mm b/NativeScript/inspector/JsV8InspectorClient.mm
@@ -4,7 +4,7 @@
 #include "JsV8InspectorClient.h"
 #include "InspectorServer.h"
 #include "include/libplatform/libplatform.h"
-#include "src/inspector/v8-log-agent-impl.h"
+//#include "src/inspector/v8-log-agent-impl.h"
 #include "Helpers.h"
 #include "utils.h"