fix: Build and link to v8_heap_base and v8_heap_base_headers

Not sure if this affects anything but those two static libraries are checked in to the branch, so we should probably be linking to them.
NativeScript · Mar 20, 2023 · 3ebd066 · 3ebd066
1 parent 241bba4
commit 3ebd066
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/build_v8_source.sh b/build_v8_source.sh
@@ -4,7 +4,7 @@ set -e
 pushd v8
 
 ARCH_ARR=(x64-simulator arm64-simulator arm64-device)
-MODULES=(v8_base_without_compiler v8_compiler v8_libplatform v8_libbase v8_bigint v8_snapshot torque_generated_initializers torque_generated_definitions)
+MODULES=(v8_base_without_compiler v8_compiler v8_libplatform v8_libbase v8_bigint v8_snapshot v8_heap_base v8_heap_base_headers torque_generated_initializers torque_generated_definitions)
 
 for CURRENT_ARCH in ${ARCH_ARR[@]}
 do

diff --git a/v8ios.xcodeproj/project.pbxproj b/v8ios.xcodeproj/project.pbxproj
@@ -2670,6 +2670,7 @@
 					"-ltorque_generated_initializers",
 					"-ltorque_generated_definitions",
 					"-lv8_heap_base",
+					"-lv8_heap_base_headers",
 					"-linspector_protocol",
 					"-linspector",
 					"-linspector_string_conversions",
@@ -2748,6 +2749,7 @@
 					"-ltorque_generated_initializers",
 					"-ltorque_generated_definitions",
 					"-lv8_heap_base",
+					"-lv8_heap_base_headers",
 					"-linspector_protocol",
 					"-linspector",
 					"-linspector_string_conversions",