Skip to content

Commit

Permalink
fix: Don't disconnect inspector when frontend connects
Browse files Browse the repository at this point in the history
This seems incorrect: we disconnect the inspector in the callback for
the frontend being connected. It leads to isConnected_ being false when
we actually go to send the console.log messages to the frontend.

However, I'm not 100% sure whether this is the correct fix. Please check
carefully.
  • Loading branch information
ptomato committed Mar 20, 2023
1 parent eaa8dd7 commit d2d3b65
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion NativeScript/inspector/JsV8InspectorClient.mm
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@
}

this->sender_ = sender;
this->disconnect();
}

void JsV8InspectorClient::onFrontendMessageReceived(std::string message) {
Expand Down

0 comments on commit d2d3b65

Please sign in to comment.