Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: 260 fix android building with java 17 kotlin and expo, upgrade virocore dependencies. #263

Closed
wants to merge 2 commits into from
Closed

WIP: 260 fix android building with java 17 kotlin and expo, upgrade virocore dependencies. #263

wants to merge 2 commits into from

Conversation

Avtrkrb
Copy link

@Avtrkrb Avtrkrb commented Feb 14, 2024 •
edited
Loading

  1. ARcore
  • Upgrade arcore 1.26.0 -> 1.41.0

This was referenced Feb 14, 2024
Merged
Closed
@Avtrkrb Avtrkrb changed the title WIP. WIP: 260 fix android building with java 17 kotlin and expo, upgrade virocore dependencies. Feb 15, 2024
@Avtrkrb
Copy link
Author

Avtrkrb commented Feb 15, 2024 •
edited
Loading

Tests via viro-test-bed app

  • Viro360Image ✅
    Viro360Image
  • Viro360Video
  • Viro3DObject ✅
    Viro3DObject
  • ViroAnimatedImage ✅
    ViroAnimatedImage
  • ViroAmbientLight
  • ViroARImageMarker ✅
    ViroARImageMarker
  • ViroARPlane ✅ Nothing visible on screen, but tracking is working from logs.
    ViroARPlane
  • ViroARPlaneSelector ✅ Nothing visible on screen, but tracking is working from logs.
    ViroARPlaneSelector
  • ViroBox ✅
    ViroBox
  • ViroButton ✅
    ViroButton
  • ViroController
  • ViroDirectionalLight
  • ViroFlexView ✅
    ViroFlexView
  • ViroGeometry
  • ViroLightingEnvironment
  • ViroImage ✅
    ViroImage
  • ViroMaterials -> Error: Asset not found: viro-test-bed/assets/LibertyStatue/LibertStatue.mtl for platform: (unspecified)
  • ViroMaterialVideo
  • ViroOmniLight
  • ViroOrbitCamera ✅
    ViroOrbitCamera1
    ViroOrbitCamera2
  • ViroParticleEmitter ✅
    ViroParticleEmitter
  • ViroPolygon ❌
    ViroPolygon
  • ViroPolyline ❌
    ViroPolyline
  • ViroPortal ❌
    ViroPortal
  • ViroQuad ✅
    ViroQuad
  • ViroSkyBox ✅
    ViroSkyBox1
    ViroSkyBox2
  • ViroSound
  • ViroSoundField
  • ViroSpatialSound
  • ViroSphere ✅
    ViroSphere
  • ViroSpinner ✅
    ViroSpinner1
    ViroSpinner2
  • ViroSpotLight
  • ViroText ✅
    ViroText
  • ViroVideo

App crashes without any errors for ViroSound, ViroVideo, Viro360Video, ViroSpatialSound. To be investigated.
Same error for ViroPolygon, ViroPolyline & ViroPortal. Will be debugging it further.

@bobbyjcolley @cjmcassar @robertjcolley

@Avtrkrb Avtrkrb mentioned this pull request Feb 15, 2024
Merged
8 tasks
@Avtrkrb
Copy link
Author

Avtrkrb commented Feb 20, 2024

There is more work done in the upstream branch. Closing this PR.

@Avtrkrb Avtrkrb closed this Feb 20, 2024
@Avtrkrb Avtrkrb deleted the 260-fix-android-building-with-java-17-kotlin-and-expo branch February 20, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertjcolley robertjcolley Awaiting requested review from robertjcolley

Assignees

@Avtrkrb Avtrkrb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Avtrkrb