From 8abedbe4f78781b3a793d4ab27f1925be56ded42 Mon Sep 17 00:00:00 2001 From: Martin Rodriguez Reboredo Date: Tue, 29 Nov 2022 16:14:21 -0300 Subject: [PATCH 1/4] Remove Qt modules in includes --- App/NatronApp_main.cpp | 2 +- CMakeLists.txt | 3 +-- Engine/AbortableRenderInfo.cpp | 8 +++---- Engine/AbortableRenderInfo.h | 2 +- Engine/AppInstance.cpp | 16 +++++++------- Engine/AppInstance.h | 6 ++--- Engine/AppManager.cpp | 24 ++++++++++---------- Engine/AppManager.h | 12 +++++----- Engine/AppManagerPrivate.cpp | 14 ++++++------ Engine/AppManagerPrivate.h | 10 ++++----- Engine/Bezier.cpp | 4 ++-- Engine/Bezier.h | 2 +- Engine/BezierCP.cpp | 6 ++--- Engine/BezierCPPrivate.h | 4 ++-- Engine/BlockingBackgroundRender.cpp | 2 +- Engine/BlockingBackgroundRender.h | 4 ++-- Engine/CLArgs.cpp | 8 +++---- Engine/CLArgs.h | 6 ++--- Engine/CMakeLists.txt | 5 +---- Engine/Cache.h | 14 ++++++------ Engine/CacheEntry.h | 10 ++++----- Engine/CurvePrivate.h | 4 ++-- Engine/EffectInstance.cpp | 4 ++-- Engine/EffectInstancePrivate.h | 8 +++---- Engine/EffectInstanceRenderRoI.cpp | 6 ++--- Engine/ExistenceCheckThread.cpp | 8 +++---- Engine/ExistenceCheckThread.h | 2 +- Engine/FileDownloader.cpp | 10 ++++----- Engine/FileDownloader.h | 2 +- Engine/FileSystemModel.cpp | 20 ++++++++--------- Engine/FileSystemModel.h | 6 ++--- Engine/Format.h | 2 +- Engine/FrameEntry.h | 4 ++-- Engine/GenericSchedulerThread.cpp | 10 ++++----- Engine/GenericSchedulerThreadWatcher.cpp | 4 ++-- Engine/Hash64.cpp | 2 +- Engine/HistogramCPU.cpp | 4 ++-- Engine/HistogramCPU.h | 2 +- Engine/Image.cpp | 2 +- Engine/Image.h | 4 ++-- Engine/ImageConvert.cpp | 2 +- Engine/ImageCopyChannels.cpp | 2 +- Engine/JoinViewsNode.cpp | 2 +- Engine/Knob.cpp | 12 +++++----- Engine/Knob.h | 10 ++++----- Engine/KnobFile.cpp | 6 ++--- Engine/KnobFile.h | 6 ++--- Engine/KnobImpl.h | 8 +++---- Engine/KnobSerialization.cpp | 4 ++-- Engine/KnobTypes.cpp | 6 ++--- Engine/KnobTypes.h | 10 ++++----- Engine/Log.cpp | 6 ++--- Engine/LogEntry.h | 4 ++-- Engine/Lut.h | 2 +- Engine/Markdown.cpp | 4 ++-- Engine/Markdown.h | 6 ++--- Engine/MemoryInfo.cpp | 8 +++---- Engine/MemoryInfo.h | 2 +- Engine/Node.cpp | 16 +++++++------- Engine/Node.h | 6 ++--- Engine/NodeDocumentation.cpp | 4 ++-- Engine/NodeGroup.cpp | 4 ++-- Engine/NodeGroup.h | 2 +- Engine/NodeGroupSerialization.cpp | 4 ++-- Engine/NodeGroupSerialization.h | 2 +- Engine/NodeInputs.cpp | 2 +- Engine/NodeMain.cpp | 2 +- Engine/NodeName.cpp | 2 +- Engine/NodeOverlay.cpp | 2 +- Engine/NodePrivate.h | 6 ++--- Engine/OSGLContext.cpp | 6 ++--- Engine/OSGLContext_win.cpp | 2 +- Engine/OfxClipInstance.cpp | 6 ++--- Engine/OfxClipInstance.h | 2 +- Engine/OfxEffectInstance.cpp | 8 +++---- Engine/OfxEffectInstance.h | 8 +++---- Engine/OfxHost.cpp | 18 +++++++-------- Engine/OfxHost.h | 2 +- Engine/OfxImageEffectInstance.cpp | 4 ++-- Engine/OfxImageEffectInstance.h | 2 +- Engine/OfxMemory.cpp | 2 +- Engine/OfxParamInstance.cpp | 2 +- Engine/OfxParamInstance.h | 4 ++-- Engine/OutputEffectInstance.cpp | 8 +++---- Engine/OutputEffectInstance.h | 2 +- Engine/OutputSchedulerThread.cpp | 18 +++++++-------- Engine/OutputSchedulerThread.h | 4 ++-- Engine/OverlaySupport.h | 2 +- Engine/Plugin.cpp | 2 +- Engine/Plugin.h | 6 ++--- Engine/PluginMemory.cpp | 2 +- Engine/PrecompNode.cpp | 2 +- Engine/ProcessHandler.cpp | 20 ++++++++--------- Engine/ProcessHandler.h | 12 +++++----- Engine/Project.cpp | 20 ++++++++--------- Engine/Project.h | 4 ++-- Engine/ProjectPrivate.cpp | 10 ++++----- Engine/ProjectPrivate.h | 8 +++---- Engine/PyAppInstance.cpp | 2 +- Engine/PyAppInstance.h | 4 ++-- Engine/ReadNode.cpp | 4 ++-- Engine/RenderStats.cpp | 2 +- Engine/RotoContext.cpp | 4 ++-- Engine/RotoContext.h | 6 ++--- Engine/RotoContextPrivate.h | 12 +++++----- Engine/RotoDrawableItem.cpp | 4 ++-- Engine/RotoDrawableItem.h | 6 ++--- Engine/RotoItem.cpp | 4 ++-- Engine/RotoItem.h | 6 ++--- Engine/RotoLayer.cpp | 4 ++-- Engine/RotoLayer.h | 6 ++--- Engine/RotoPaintInteract.cpp | 2 +- Engine/RotoPaintInteract.h | 4 ++-- Engine/RotoPoint.h | 6 ++--- Engine/RotoStrokeItem.cpp | 4 ++-- Engine/RotoStrokeItem.h | 6 ++--- Engine/RotoUndoCommand.cpp | 2 +- Engine/RotoUndoCommand.h | 2 +- Engine/ScriptObject.cpp | 2 +- Engine/Settings.cpp | 12 +++++----- Engine/Singleton.h | 2 +- Engine/StandardPaths.cpp | 12 +++++----- Engine/StandardPaths.h | 2 +- Engine/StringAnimationManager.cpp | 2 +- Engine/TLSHolder.cpp | 6 ++--- Engine/TLSHolder.h | 4 ++-- Engine/ThreadPool.cpp | 8 +++---- Engine/ThreadPool.h | 2 +- Engine/ThreadStorage.h | 6 ++--- Engine/TimeLine.cpp | 4 ++-- Engine/TimeLine.h | 4 ++-- Engine/Timer.cpp | 4 ++-- Engine/Timer.h | 6 ++--- Engine/TrackMarker.cpp | 2 +- Engine/TrackerContext.cpp | 6 ++--- Engine/TrackerContext.h | 4 ++-- Engine/TrackerContextPrivate.cpp | 2 +- Engine/TrackerFrameAccessor.cpp | 2 +- Engine/TrackerNodeInteract.h | 4 ++-- Engine/TrackerUndoCommand.h | 2 +- Engine/Utils.cpp | 6 ++--- Engine/Variant.h | 12 +++++----- Engine/ViewerInstance.cpp | 12 +++++----- Engine/ViewerInstancePrivate.h | 10 ++++----- Engine/WriteNode.cpp | 2 +- Engine/pch.h | 2 +- Global/Enums.h | 4 ++-- Global/GlobalDefines.h | 6 ++--- Global/KeySymbols.h | 2 +- Global/QtCompat.h | 8 +++---- Gui/AboutWindow.cpp | 6 ++--- Gui/ActionShortcuts.h | 2 +- Gui/AddKnobDialog.cpp | 2 +- Gui/AnimatedCheckBox.h | 2 +- Gui/BackdropGui.cpp | 4 ++-- Gui/CMakeLists.txt | 3 --- Gui/ChannelsComboBox.cpp | 4 ++-- Gui/ClickableLabel.h | 2 +- Gui/ComboBox.cpp | 2 +- Gui/ComboBox.h | 6 ++--- Gui/CurveEditorUndoRedo.cpp | 2 +- Gui/CurveEditorUndoRedo.h | 2 +- Gui/CurveGui.cpp | 8 +++---- Gui/CurveGui.h | 4 ++-- Gui/CurveWidget.cpp | 4 ++-- Gui/CurveWidget.h | 6 ++--- Gui/CurveWidgetDialogs.cpp | 8 +++---- Gui/CurveWidgetDialogs.h | 4 ++-- Gui/CurveWidgetPrivate.cpp | 4 ++-- Gui/CurveWidgetPrivate.h | 2 +- Gui/CustomParamInteract.cpp | 8 +++---- Gui/DockablePanel.cpp | 8 +++---- Gui/DockablePanelPrivate.cpp | 2 +- Gui/DockablePanelPrivate.h | 2 +- Gui/DockablePanelTabWidget.h | 2 +- Gui/DocumentationManager.cpp | 6 ++--- Gui/DocumentationManager.h | 2 +- Gui/DopeSheet.cpp | 4 ++-- Gui/DopeSheetEditor.h | 4 ++-- Gui/DopeSheetEditorUndoRedo.cpp | 2 +- Gui/DopeSheetEditorUndoRedo.h | 2 +- Gui/DopeSheetHierarchyView.cpp | 4 ++-- Gui/DopeSheetHierarchyView.h | 6 ++--- Gui/DopeSheetView.cpp | 2 +- Gui/DotGui.cpp | 2 +- Gui/DotGui.h | 6 ++--- Gui/Edge.cpp | 2 +- Gui/EditExpressionDialog.cpp | 6 ++--- Gui/EditExpressionDialog.h | 2 +- Gui/EditScriptDialog.cpp | 6 ++--- Gui/EditScriptDialog.h | 4 ++-- Gui/ExportGroupTemplateDialog.cpp | 2 +- Gui/FileTypeMainWindow_win.cpp | 6 ++--- Gui/FloatingWidget.cpp | 2 +- Gui/GroupBoxLabel.cpp | 2 +- Gui/Gui.cpp | 6 ++--- Gui/Gui.h | 4 ++-- Gui/Gui05.cpp | 6 ++--- Gui/Gui20.cpp | 8 +++---- Gui/Gui30.cpp | 4 ++-- Gui/Gui40.cpp | 10 ++++----- Gui/Gui50.cpp | 10 ++++----- Gui/GuiAppInstance.cpp | 6 ++--- Gui/GuiApplicationManager.cpp | 6 ++--- Gui/GuiApplicationManager.h | 2 +- Gui/GuiApplicationManager10.cpp | 8 +++---- Gui/GuiApplicationManagerPrivate.cpp | 2 +- Gui/GuiApplicationManagerPrivate.h | 4 ++-- Gui/GuiFwd.h | 2 +- Gui/GuiPrivate.cpp | 14 ++++++------ Gui/GuiPrivate.h | 8 +++---- Gui/Histogram.cpp | 2 +- Gui/Histogram.h | 2 +- Gui/HostOverlay.cpp | 6 ++--- Gui/InfoViewerWidget.cpp | 6 ++--- Gui/InfoViewerWidget.h | 6 ++--- Gui/KnobGui.h | 2 +- Gui/KnobGuiBool.cpp | 2 +- Gui/KnobGuiBool.h | 2 +- Gui/KnobGuiButton.cpp | 2 +- Gui/KnobGuiButton.h | 2 +- Gui/KnobGuiChoice.cpp | 2 +- Gui/KnobGuiChoice.h | 2 +- Gui/KnobGuiColor.cpp | 2 +- Gui/KnobGuiColor.h | 2 +- Gui/KnobGuiFile.cpp | 2 +- Gui/KnobGuiFile.h | 4 ++-- Gui/KnobGuiGroup.cpp | 2 +- Gui/KnobGuiGroup.h | 2 +- Gui/KnobGuiParametric.cpp | 2 +- Gui/KnobGuiParametric.h | 2 +- Gui/KnobGuiPrivate.h | 4 ++-- Gui/KnobGuiSeparator.cpp | 2 +- Gui/KnobGuiSeparator.h | 2 +- Gui/KnobGuiString.cpp | 2 +- Gui/KnobGuiString.h | 2 +- Gui/KnobGuiValue.cpp | 2 +- Gui/KnobGuiValue.h | 2 +- Gui/KnobWidgetDnD.cpp | 2 +- Gui/KnobWidgetDnD.h | 2 +- Gui/Label.h | 2 +- Gui/LineEdit.cpp | 4 ++-- Gui/LinkToKnobDialog.cpp | 6 ++--- Gui/LinkToKnobDialog.h | 4 ++-- Gui/LogWindow.cpp | 4 ++-- Gui/MessageBox.cpp | 2 +- Gui/MultiInstancePanel.cpp | 22 +++++++++---------- Gui/MultiInstancePanel.h | 2 +- Gui/NewLayerDialog.cpp | 2 +- Gui/NodeCreationDialog.cpp | 6 ++--- Gui/NodeGraph10.cpp | 2 +- Gui/NodeGraph40.cpp | 2 +- Gui/NodeGraph45.cpp | 2 +- Gui/NodeGraphPrivate.h | 6 ++--- Gui/NodeGraphTextItem.cpp | 2 +- Gui/NodeGraphUndoRedo.cpp | 2 +- Gui/NodeGraphUndoRedo.h | 4 ++-- Gui/NodeGui.cpp | 6 ++--- Gui/NodeGui.h | 10 ++++----- Gui/NodeSettingsPanel.cpp | 2 +- Gui/NodeViewerContext.h | 2 +- Gui/PickKnobDialog.cpp | 2 +- Gui/PreviewThread.cpp | 4 ++-- Gui/PreviewThread.h | 2 +- Gui/ProgressPanel.cpp | 6 ++--- Gui/ProgressTaskInfo.cpp | 4 ++-- Gui/ProgressTaskInfo.h | 2 +- Gui/ProjectGui.cpp | 4 ++-- Gui/ProjectGui.h | 2 +- Gui/ProjectGuiSerialization.cpp | 2 +- Gui/Pyside_Gui_Python.h | 2 +- Gui/PythonPanels.cpp | 2 +- Gui/QtEnumConvert.cpp | 2 +- Gui/QtMac.mm | 2 +- Gui/RenderStatsDialog.cpp | 4 ++-- Gui/RightClickableWidget.cpp | 2 +- Gui/RotoPanel.cpp | 4 ++-- Gui/ScaleSliderQWidget.cpp | 6 ++--- Gui/ScaleSliderQWidget.h | 2 +- Gui/ScriptEditor.cpp | 10 ++++----- Gui/ScriptTextEdit.cpp | 4 ++-- Gui/ScriptTextEdit.h | 2 +- Gui/SequenceFileDialog.cpp | 28 ++++++++++++------------ Gui/SequenceFileDialog.h | 20 ++++++++--------- Gui/SerializableWindow.cpp | 2 +- Gui/SpinBox.cpp | 8 +++---- Gui/SplashScreen.h | 2 +- Gui/Splitter.h | 2 +- Gui/TabWidget.cpp | 20 ++++++++--------- Gui/TabWidget.h | 2 +- Gui/TableModelView.h | 6 ++--- Gui/TextRenderer.cpp | 8 +++---- Gui/TimeLineGui.cpp | 10 ++++----- Gui/TimeLineGui.h | 6 ++--- Gui/ToolButton.cpp | 2 +- Gui/ToolButton.h | 2 +- Gui/TrackerPanel.cpp | 2 +- Gui/VerticalColorBar.h | 6 ++--- Gui/ViewerGL.cpp | 10 ++++----- Gui/ViewerGL.h | 2 +- Gui/ViewerGLPrivate.h | 4 ++-- Gui/ViewerTab.cpp | 4 ++-- Gui/ViewerTab.h | 2 +- Gui/ViewerTab10.cpp | 6 ++--- Gui/ViewerTab20.cpp | 4 ++-- Gui/ViewerTab30.cpp | 2 +- Gui/ViewerTab40.cpp | 2 +- Gui/ViewerTabPrivate.cpp | 2 +- Gui/ViewerTabPrivate.h | 4 ++-- Gui/ViewerToolButton.cpp | 2 +- Gui/ZoomContext.h | 2 +- Renderer/NatronRenderer_main.cpp | 4 ++-- Tests/BaseTest.cpp | 4 ++-- Tests/BaseTest.h | 2 +- Tests/Curve_Test.cpp | 4 ++-- Tests/KnobFile_Test.cpp | 4 ++-- 316 files changed, 774 insertions(+), 781 deletions(-) diff --git a/App/NatronApp_main.cpp b/App/NatronApp_main.cpp index 88902f6eb..a43dc2de3 100644 --- a/App/NatronApp_main.cpp +++ b/App/NatronApp_main.cpp @@ -23,7 +23,7 @@ #include // ***** END PYTHON BLOCK ***** -#include // for Q_OS_* +#include // for Q_OS_* #if defined(Q_OS_UNIX) #include // for getrlimit on linux #include // for getrlimit diff --git a/CMakeLists.txt b/CMakeLists.txt index 13c18c12a..4d118b007 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -74,8 +74,7 @@ endif() find_package(PySide2 5.15 CONFIG REQUIRED COMPONENTS pyside2) set(QT_VERSION_MAJOR 5) get_target_property(PYSIDE_INCLUDE_DIRS PySide2::pyside2 INTERFACE_INCLUDE_DIRECTORIES) -string(REGEX REPLACE "(.*)QtCore$" "\\1" Qt5_INCLUDE_DIR ${Qt5Core_INCLUDE_DIRS}) -set(QTCORE_INCLUDE_DIRS ${Qt5_INCLUDE_DIR} ${Qt5Core_INCLUDE_DIRS}) +set(QTCORE_INCLUDE_DIRS ${Qt5Core_INCLUDE_DIRS}) set(QTGUI_INCLUDE_DIRS ${Qt5Gui_INCLUDE_DIRS}) set(QTWIDGETS_INCLUDE_DIRS ${Qt5Widgets_INCLUDE_DIRS}) diff --git a/Engine/AbortableRenderInfo.cpp b/Engine/AbortableRenderInfo.cpp index c61c4d9ce..2660c85bc 100644 --- a/Engine/AbortableRenderInfo.cpp +++ b/Engine/AbortableRenderInfo.cpp @@ -30,10 +30,10 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include #include "Engine/AppManager.h" #include "Engine/EffectInstance.h" diff --git a/Engine/AbortableRenderInfo.h b/Engine/AbortableRenderInfo.h index 30e035143..e098cb3fb 100644 --- a/Engine/AbortableRenderInfo.h +++ b/Engine/AbortableRenderInfo.h @@ -30,7 +30,7 @@ #include "Global/GlobalDefines.h" -#include +#include #include "Engine/EngineFwd.h" diff --git a/Engine/AppInstance.cpp b/Engine/AppInstance.cpp index c69ea7f51..e1067c87a 100644 --- a/Engine/AppInstance.cpp +++ b/Engine/AppInstance.cpp @@ -33,15 +33,15 @@ #include #include // stringstream -#include -#include -#include +#include +#include +#include #include // QtCore on Qt4, QtConcurrent on Qt5 -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include // ofxhPropertySuite.h:565:37: warning: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare] // clang-format off diff --git a/Engine/AppInstance.h b/Engine/AppInstance.h index 60b5856a2..8978b5946 100644 --- a/Engine/AppInstance.h +++ b/Engine/AppInstance.h @@ -35,9 +35,9 @@ #include #include // for NULL -#include // for Q_UNUSED -#include // for Q_OBJECT, Q_SIGNALS, Q_SLOTS -#include +#include // for Q_UNUSED +#include // for Q_OBJECT, Q_SIGNALS, Q_SLOTS +#include #include "Global/GlobalDefines.h" #include "Engine/RectD.h" diff --git a/Engine/AppManager.cpp b/Engine/AppManager.cpp index 8712eec00..9174556ee 100644 --- a/Engine/AppManager.cpp +++ b/Engine/AppManager.cpp @@ -56,7 +56,7 @@ #include // stringstream #include -#include // for Q_OS_* +#include // for Q_OS_* #if defined(Q_OS_LINUX) #include #ifndef __USE_GNU @@ -85,17 +85,17 @@ #include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include "Global/ProcInfo.h" diff --git a/Engine/AppManager.h b/Engine/AppManager.h index f7de29dda..5a7989137 100644 --- a/Engine/AppManager.h +++ b/Engine/AppManager.h @@ -35,14 +35,14 @@ #include "Global/GlobalDefines.h" CLANG_DIAG_OFF(deprecated) -#include // for Q_OS_* +#include // for Q_OS_* // /usr/include/qt5/QtCore/qgenericatomic.h:177:13: warning: 'register' storage class specifier is deprecated [-Wdeprecated] -#include +#include CLANG_DIAG_ON(deprecated) -#include -#include -#include -#include +#include +#include +#include +#include #include "Engine/AfterQuitProcessingI.h" #include "Engine/Plugin.h" diff --git a/Engine/AppManagerPrivate.cpp b/Engine/AppManagerPrivate.cpp index 6f396a3cb..cca26393e 100644 --- a/Engine/AppManagerPrivate.cpp +++ b/Engine/AppManagerPrivate.cpp @@ -25,7 +25,7 @@ #include "AppManagerPrivate.h" -#include // for Q_OS_* +#include // for Q_OS_* #if defined(Q_OS_UNIX) #include // for getrlimit on linux #include // for getrlimit @@ -48,12 +48,12 @@ GCC_DIAG_UNUSED_LOCAL_TYPEDEFS_ON GCC_DIAG_ON(unused-parameter) // clang-format on -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include #include "Global/QtCompat.h" // for removeRecursively #include "Global/GlobalDefines.h" diff --git a/Engine/AppManagerPrivate.h b/Engine/AppManagerPrivate.h index fd6231909..9aeb47f6b 100644 --- a/Engine/AppManagerPrivate.h +++ b/Engine/AppManagerPrivate.h @@ -33,11 +33,11 @@ #include #include -#include // for Q_OS_* -#include -#include -#include -#include +#include // for Q_OS_* +#include +#include +#include +#include #if defined(Q_OS_LINUX) || defined(Q_OS_FREEBSD) diff --git a/Engine/Bezier.cpp b/Engine/Bezier.cpp index 1b30f5be8..10df16438 100644 --- a/Engine/Bezier.cpp +++ b/Engine/Bezier.cpp @@ -33,8 +33,8 @@ #include #include -#include -#include +#include +#include #include "Engine/RotoContextPrivate.h" diff --git a/Engine/Bezier.h b/Engine/Bezier.h index 3cd4cf646..f50e16592 100644 --- a/Engine/Bezier.h +++ b/Engine/Bezier.h @@ -35,7 +35,7 @@ // clang-format off CLANG_DIAG_OFF(deprecated-declarations) -#include +#include CLANG_DIAG_ON(deprecated-declarations) // clang-format on diff --git a/Engine/BezierCP.cpp b/Engine/BezierCP.cpp index 5e9f45362..1978208ec 100644 --- a/Engine/BezierCP.cpp +++ b/Engine/BezierCP.cpp @@ -34,9 +34,9 @@ #include #include -#include -#include -#include +#include +#include +#include #include "Engine/Bezier.h" #include "Engine/KnobTypes.h" diff --git a/Engine/BezierCPPrivate.h b/Engine/BezierCPPrivate.h index 07501ba50..79d1af133 100644 --- a/Engine/BezierCPPrivate.h +++ b/Engine/BezierCPPrivate.h @@ -28,8 +28,8 @@ #include "Global/Macros.h" -#include -#include +#include +#include #include "Engine/Curve.h" #include "Engine/EngineFwd.h" diff --git a/Engine/BlockingBackgroundRender.cpp b/Engine/BlockingBackgroundRender.cpp index f3f761bbb..1f6b21b9c 100644 --- a/Engine/BlockingBackgroundRender.cpp +++ b/Engine/BlockingBackgroundRender.cpp @@ -31,7 +31,7 @@ #include "Global/Macros.h" // clang-format off CLANG_DIAG_OFF(deprecated-register) //'register' storage class specifier is deprecated -#include +#include CLANG_DIAG_ON(deprecated-register) // clang-format on diff --git a/Engine/BlockingBackgroundRender.h b/Engine/BlockingBackgroundRender.h index a6ce0c147..f096fdf4b 100644 --- a/Engine/BlockingBackgroundRender.h +++ b/Engine/BlockingBackgroundRender.h @@ -28,8 +28,8 @@ #include "Global/Macros.h" -#include -#include +#include +#include #include "Engine/EngineFwd.h" diff --git a/Engine/CLArgs.cpp b/Engine/CLArgs.cpp index c5f6dd61e..e91b46cee 100644 --- a/Engine/CLArgs.cpp +++ b/Engine/CLArgs.cpp @@ -35,10 +35,10 @@ #include // CommandLineToArgvW #endif -#include -#include -#include -#include +#include +#include +#include +#include #include "Global/GlobalDefines.h" #include "Global/GitVersion.h" diff --git a/Engine/CLArgs.h b/Engine/CLArgs.h index d3761387c..a6ca74cdf 100644 --- a/Engine/CLArgs.h +++ b/Engine/CLArgs.h @@ -36,9 +36,9 @@ #include "Global/GlobalDefines.h" CLANG_DIAG_OFF(deprecated) -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated) #include "Engine/EngineFwd.h" diff --git a/Engine/CMakeLists.txt b/Engine/CMakeLists.txt index bd9eebda1..971ab42f6 100644 --- a/Engine/CMakeLists.txt +++ b/Engine/CMakeLists.txt @@ -37,10 +37,7 @@ set(shiboken_args "-I." "-I.." "-I../Global" "-I../libs/OpenFX/include" ${PYENGINE_INCS} "-T${PYSIDE_TYPESYSTEMS}" "--output-directory=${PYENGINE_OUT}" "${PYENGINE_HEADER}" "typesystem_engine.xml") -if(APPLE) - list(PREPEND shiboken_args -I${Qt5_DIR}/../../../include) - endif() - + execute_process(COMMAND ${Python3_EXECUTABLE} ../tools/utils/sourceList.py typesystem_engine.xml ${PYENGINE_OUT} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} OUTPUT_VARIABLE PyEngine_SOURCES) diff --git a/Engine/Cache.h b/Engine/Cache.h index 018aef01f..6a25e3ddc 100644 --- a/Engine/Cache.h +++ b/Engine/Cache.h @@ -44,13 +44,13 @@ #include "Global/StrUtils.h" GCC_DIAG_OFF(deprecated) -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include GCC_DIAG_ON(deprecated) #include "Engine/AppManager.h" //for access to settings diff --git a/Engine/CacheEntry.h b/Engine/CacheEntry.h index c42a7ab4c..ec5053ae0 100644 --- a/Engine/CacheEntry.h +++ b/Engine/CacheEntry.h @@ -45,11 +45,11 @@ #include #endif -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #ifdef DEBUG #include // for removePath diff --git a/Engine/CurvePrivate.h b/Engine/CurvePrivate.h index 65101f32f..4d292c2b2 100644 --- a/Engine/CurvePrivate.h +++ b/Engine/CurvePrivate.h @@ -28,8 +28,8 @@ #include "Global/Macros.h" -#include -#include +#include +#include #include "Engine/Variant.h" #include "Engine/Knob.h" diff --git a/Engine/EffectInstance.cpp b/Engine/EffectInstance.cpp index ecbeceb22..0234ee387 100644 --- a/Engine/EffectInstance.cpp +++ b/Engine/EffectInstance.cpp @@ -36,8 +36,8 @@ #include #include // stringstream -#include -#include +#include +#include #include // QtCore on Qt4, QtConcurrent on Qt5 #include // QtCore on Qt4, QtConcurrent on Qt5 diff --git a/Engine/EffectInstancePrivate.h b/Engine/EffectInstancePrivate.h index 2ed88cafb..6b0233b8e 100644 --- a/Engine/EffectInstancePrivate.h +++ b/Engine/EffectInstancePrivate.h @@ -34,10 +34,10 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include #include "Global/GlobalDefines.h" diff --git a/Engine/EffectInstanceRenderRoI.cpp b/Engine/EffectInstanceRenderRoI.cpp index 42c080259..de9da7d0e 100644 --- a/Engine/EffectInstanceRenderRoI.cpp +++ b/Engine/EffectInstanceRenderRoI.cpp @@ -35,9 +35,9 @@ #include #include // stringstream -#include -#include -#include +#include +#include +#include #include // QtCore on Qt4, QtConcurrent on Qt5 #include // QtCore on Qt4, QtConcurrent on Qt5 diff --git a/Engine/ExistenceCheckThread.cpp b/Engine/ExistenceCheckThread.cpp index 5f9e64153..00590460c 100644 --- a/Engine/ExistenceCheckThread.cpp +++ b/Engine/ExistenceCheckThread.cpp @@ -30,10 +30,10 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include #ifdef DEBUG #include "Global/FloatingPointExceptions.h" diff --git a/Engine/ExistenceCheckThread.h b/Engine/ExistenceCheckThread.h index 8fdc3013f..339f94239 100644 --- a/Engine/ExistenceCheckThread.h +++ b/Engine/ExistenceCheckThread.h @@ -28,7 +28,7 @@ #include "Global/Macros.h" -#include +#include #include "Engine/EngineFwd.h" diff --git a/Engine/FileDownloader.cpp b/Engine/FileDownloader.cpp index dbbae92b4..a2bcf1454 100644 --- a/Engine/FileDownloader.cpp +++ b/Engine/FileDownloader.cpp @@ -28,11 +28,11 @@ #include #include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #define NATRON_FILE_DOWNLOAD_HEARBEAT_TIMEOUT_MS 5000 diff --git a/Engine/FileDownloader.h b/Engine/FileDownloader.h index 45e2986e4..ed79199af 100644 --- a/Engine/FileDownloader.h +++ b/Engine/FileDownloader.h @@ -30,7 +30,7 @@ // clang-format off CLANG_DIAG_OFF(deprecated-register) //'register' storage class specifier is deprecated -#include +#include CLANG_DIAG_ON(deprecated-register) // clang-format on diff --git a/Engine/FileSystemModel.cpp b/Engine/FileSystemModel.cpp index 63841176a..9529b707e 100644 --- a/Engine/FileSystemModel.cpp +++ b/Engine/FileSystemModel.cpp @@ -37,16 +37,16 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include // for Q_OS_* -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include // for Q_OS_* +#include +#include +#include +#include +#include +#include +#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/FileSystemModel.h b/Engine/FileSystemModel.h index 0484e9bd8..40a2c558e 100644 --- a/Engine/FileSystemModel.h +++ b/Engine/FileSystemModel.h @@ -30,9 +30,9 @@ #include -#include -#include -#include +#include +#include +#include #include "Global/GlobalDefines.h" #include "Engine/EngineFwd.h" diff --git a/Engine/Format.h b/Engine/Format.h index f0bd7b720..3192fa354 100644 --- a/Engine/Format.h +++ b/Engine/Format.h @@ -31,7 +31,7 @@ #include CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) #include "Engine/RectD.h" diff --git a/Engine/FrameEntry.h b/Engine/FrameEntry.h index 48d7b103d..785dcefc1 100644 --- a/Engine/FrameEntry.h +++ b/Engine/FrameEntry.h @@ -32,8 +32,8 @@ #include CLANG_DIAG_OFF(deprecated) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) #include "Global/GlobalDefines.h" diff --git a/Engine/GenericSchedulerThread.cpp b/Engine/GenericSchedulerThread.cpp index 3bd336a5b..70a4a7cfe 100644 --- a/Engine/GenericSchedulerThread.cpp +++ b/Engine/GenericSchedulerThread.cpp @@ -25,11 +25,11 @@ #include "GenericSchedulerThread.h" -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #ifdef DEBUG #include "Global/FloatingPointExceptions.h" diff --git a/Engine/GenericSchedulerThreadWatcher.cpp b/Engine/GenericSchedulerThreadWatcher.cpp index 59dddd7cf..7ba9af6a6 100644 --- a/Engine/GenericSchedulerThreadWatcher.cpp +++ b/Engine/GenericSchedulerThreadWatcher.cpp @@ -27,8 +27,8 @@ #include "GenericSchedulerThreadWatcher.h" -#include -#include +#include +#include #include "Engine/GenericSchedulerThread.h" #include "Engine/OutputSchedulerThread.h" diff --git a/Engine/Hash64.cpp b/Engine/Hash64.cpp index dfd47c389..6c1c2def1 100644 --- a/Engine/Hash64.cpp +++ b/Engine/Hash64.cpp @@ -32,7 +32,7 @@ #if !defined(Q_MOC_RUN) && !defined(SBK_RUN) #include #endif -#include +#include #include "Engine/Node.h" diff --git a/Engine/HistogramCPU.cpp b/Engine/HistogramCPU.cpp index e58d0702c..ce2330661 100644 --- a/Engine/HistogramCPU.cpp +++ b/Engine/HistogramCPU.cpp @@ -29,8 +29,8 @@ #include #include -#include -#include +#include +#include #ifdef DEBUG #include "Global/FloatingPointExceptions.h" diff --git a/Engine/HistogramCPU.h b/Engine/HistogramCPU.h index 4a9b961d2..2b7982524 100644 --- a/Engine/HistogramCPU.h +++ b/Engine/HistogramCPU.h @@ -30,7 +30,7 @@ #include -#include +#include #include "Engine/EngineFwd.h" diff --git a/Engine/Image.cpp b/Engine/Image.cpp index f356ed2c4..d3f1317a7 100644 --- a/Engine/Image.cpp +++ b/Engine/Image.cpp @@ -30,7 +30,7 @@ #include // for std::memcpy, std::memset #include -#include +#include #include "Engine/AppManager.h" #include "Engine/ViewIdx.h" diff --git a/Engine/Image.h b/Engine/Image.h index 36469b2d5..ee75ebf65 100644 --- a/Engine/Image.h +++ b/Engine/Image.h @@ -36,9 +36,9 @@ #include "Global/GlobalDefines.h" CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) -#include +#include #include "Engine/ImageKey.h" #include "Engine/ImagePlaneDesc.h" diff --git a/Engine/ImageConvert.cpp b/Engine/ImageConvert.cpp index a12ad661e..c8b1ae2e7 100644 --- a/Engine/ImageConvert.cpp +++ b/Engine/ImageConvert.cpp @@ -29,7 +29,7 @@ #include #include -#include +#include #include "Engine/AppManager.h" #include "Engine/Lut.h" diff --git a/Engine/ImageCopyChannels.cpp b/Engine/ImageCopyChannels.cpp index 55c017985..2239f145f 100644 --- a/Engine/ImageCopyChannels.cpp +++ b/Engine/ImageCopyChannels.cpp @@ -28,7 +28,7 @@ #include #include -#include +#include #include "Engine/OSGLContext.h" #include "Engine/GLShader.h" diff --git a/Engine/JoinViewsNode.cpp b/Engine/JoinViewsNode.cpp index f0e1bb6c3..5340eaee9 100644 --- a/Engine/JoinViewsNode.cpp +++ b/Engine/JoinViewsNode.cpp @@ -25,7 +25,7 @@ #include "JoinViewsNode.h" -#include +#include #include "Engine/AppInstance.h" #include "Engine/Project.h" diff --git a/Engine/Knob.cpp b/Engine/Knob.cpp index d3fd61651..48e5bd3c1 100644 --- a/Engine/Knob.cpp +++ b/Engine/Knob.cpp @@ -32,12 +32,12 @@ #include // stringstream #include // isspace -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include #include "Global/GlobalDefines.h" diff --git a/Engine/Knob.h b/Engine/Knob.h index 27d82d106..ff21c348a 100644 --- a/Engine/Knob.h +++ b/Engine/Knob.h @@ -33,11 +33,11 @@ #include #include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #include "Engine/Variant.h" #include "Engine/AppManager.h" // for AppManager::createKnob diff --git a/Engine/KnobFile.cpp b/Engine/KnobFile.cpp index f05343908..0db3804b2 100644 --- a/Engine/KnobFile.cpp +++ b/Engine/KnobFile.cpp @@ -30,9 +30,9 @@ #include #include // stringstream -#include -#include -#include +#include +#include +#include #include "Engine/EffectInstance.h" #include "Engine/Transform.h" diff --git a/Engine/KnobFile.h b/Engine/KnobFile.h index 3db97d523..8e74e1167 100644 --- a/Engine/KnobFile.h +++ b/Engine/KnobFile.h @@ -32,10 +32,10 @@ #include CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) -#include -#include +#include +#include #include "Engine/KnobTypes.h" #include "Engine/ViewIdx.h" diff --git a/Engine/KnobImpl.h b/Engine/KnobImpl.h index 9df9943c9..3fde421b4 100644 --- a/Engine/KnobImpl.h +++ b/Engine/KnobImpl.h @@ -35,10 +35,10 @@ #include #include // min, max -#include -#include -#include -#include +#include +#include +#include +#include #include "Global/PythonUtils.h" diff --git a/Engine/KnobSerialization.cpp b/Engine/KnobSerialization.cpp index 349aa6e07..bbb014d79 100644 --- a/Engine/KnobSerialization.cpp +++ b/Engine/KnobSerialization.cpp @@ -31,8 +31,8 @@ #include -#include -#include +#include +#include #include diff --git a/Engine/KnobTypes.cpp b/Engine/KnobTypes.cpp index 54c0ea0a1..6ec7dcbb4 100644 --- a/Engine/KnobTypes.cpp +++ b/Engine/KnobTypes.cpp @@ -34,9 +34,9 @@ #include #include // stringstream -#include -#include -#include +#include +#include +#include #include "Engine/AppInstance.h" #include "Engine/Bezier.h" diff --git a/Engine/KnobTypes.h b/Engine/KnobTypes.h index 387f37183..a60689fbc 100644 --- a/Engine/KnobTypes.h +++ b/Engine/KnobTypes.h @@ -33,14 +33,14 @@ #include CLANG_DIAG_OFF(deprecated) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) GCC_ONLY_DIAG_OFF(class-memaccess) -#include +#include GCC_ONLY_DIAG_ON(class-memaccess) -#include -#include +#include +#include #include "Global/GlobalDefines.h" #include "Engine/Knob.h" diff --git a/Engine/Log.cpp b/Engine/Log.cpp index d518d1030..4e1572b70 100644 --- a/Engine/Log.cpp +++ b/Engine/Log.cpp @@ -35,9 +35,9 @@ #include #include -#include -#include -#include +#include +#include +#include #include "Global/GlobalDefines.h" diff --git a/Engine/LogEntry.h b/Engine/LogEntry.h index 6b2cd4a37..74a2fb0fc 100644 --- a/Engine/LogEntry.h +++ b/Engine/LogEntry.h @@ -29,8 +29,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/Lut.h b/Engine/Lut.h index a1359c2e3..9d39ab726 100644 --- a/Engine/Lut.h +++ b/Engine/Lut.h @@ -38,7 +38,7 @@ #include CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) #include "Engine/EngineFwd.h" diff --git a/Engine/Markdown.cpp b/Engine/Markdown.cpp index 3bc939b95..718decd6a 100644 --- a/Engine/Markdown.cpp +++ b/Engine/Markdown.cpp @@ -29,8 +29,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/Markdown.h b/Engine/Markdown.h index 86d7d948e..f61954128 100644 --- a/Engine/Markdown.h +++ b/Engine/Markdown.h @@ -31,10 +31,10 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) GCC_ONLY_DIAG_OFF(class-memaccess) -#include +#include GCC_ONLY_DIAG_ON(class-memaccess) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/MemoryInfo.cpp b/Engine/MemoryInfo.cpp index 07ad4915e..18e8d7b14 100644 --- a/Engine/MemoryInfo.cpp +++ b/Engine/MemoryInfo.cpp @@ -70,10 +70,10 @@ # error "Cannot define getPeakRSS( ) or getCurrentRSS( ) for an unknown OS." #endif -#include -#include -#include -#include +#include +#include +#include +#include #include "Global/GlobalDefines.h" diff --git a/Engine/MemoryInfo.h b/Engine/MemoryInfo.h index 0c5903b70..07a6c27b2 100644 --- a/Engine/MemoryInfo.h +++ b/Engine/MemoryInfo.h @@ -30,7 +30,7 @@ #include // std::size_t -#include +#include #include "Global/GlobalDefines.h" diff --git a/Engine/Node.cpp b/Engine/Node.cpp index aa0a905d5..8d6add034 100644 --- a/Engine/Node.cpp +++ b/Engine/Node.cpp @@ -35,14 +35,14 @@ #include "Global/Macros.h" -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include #include diff --git a/Engine/Node.h b/Engine/Node.h index f5e433b75..d8d939a6d 100644 --- a/Engine/Node.h +++ b/Engine/Node.h @@ -35,10 +35,10 @@ #include CLANG_DIAG_OFF(deprecated) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) -#include +#include #include "Engine/AppManager.h" #include "Global/KeySymbols.h" diff --git a/Engine/NodeDocumentation.cpp b/Engine/NodeDocumentation.cpp index 6882309f6..4d1ff2af6 100644 --- a/Engine/NodeDocumentation.cpp +++ b/Engine/NodeDocumentation.cpp @@ -25,8 +25,8 @@ #include "NodePrivate.h" -#include -#include +#include +#include #include "Engine/EffectInstance.h" #include "Engine/KnobTypes.h" diff --git a/Engine/NodeGroup.cpp b/Engine/NodeGroup.cpp index 609d36592..4d5a6a68a 100644 --- a/Engine/NodeGroup.cpp +++ b/Engine/NodeGroup.cpp @@ -34,8 +34,8 @@ #include // stringstream #include -#include -#include +#include +#include #include "Engine/AppInstance.h" #include "Engine/Bezier.h" diff --git a/Engine/NodeGroup.h b/Engine/NodeGroup.h index b9c367540..701d35ef9 100644 --- a/Engine/NodeGroup.h +++ b/Engine/NodeGroup.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/NodeGroupSerialization.cpp b/Engine/NodeGroupSerialization.cpp index f32d0c115..be11ac90b 100644 --- a/Engine/NodeGroupSerialization.cpp +++ b/Engine/NodeGroupSerialization.cpp @@ -28,8 +28,8 @@ #include #include -#include -#include +#include +#include #include "Engine/AppManager.h" #include "Engine/CreateNodeArgs.h" diff --git a/Engine/NodeGroupSerialization.h b/Engine/NodeGroupSerialization.h index 253fd00d5..c0e8b9869 100644 --- a/Engine/NodeGroupSerialization.h +++ b/Engine/NodeGroupSerialization.h @@ -45,7 +45,7 @@ GCC_DIAG_ON(unused-parameter) CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/NodeInputs.cpp b/Engine/NodeInputs.cpp index 7af97bcf1..6baa55b4e 100644 --- a/Engine/NodeInputs.cpp +++ b/Engine/NodeInputs.cpp @@ -26,7 +26,7 @@ #include "NodePrivate.h" #include -#include +#include #include "Engine/NodeGroup.h" #include "Engine/PrecompNode.h" diff --git a/Engine/NodeMain.cpp b/Engine/NodeMain.cpp index fb03e30fb..13b9dfb91 100644 --- a/Engine/NodeMain.cpp +++ b/Engine/NodeMain.cpp @@ -25,7 +25,7 @@ #include "NodePrivate.h" -#include +#include #include "Engine/AppInstance.h" #include "Engine/CreateNodeArgs.h" diff --git a/Engine/NodeName.cpp b/Engine/NodeName.cpp index cb8b68174..5266e9e18 100644 --- a/Engine/NodeName.cpp +++ b/Engine/NodeName.cpp @@ -25,7 +25,7 @@ #include "NodePrivate.h" -#include +#include #include diff --git a/Engine/NodeOverlay.cpp b/Engine/NodeOverlay.cpp index 907c45904..6048e8bca 100644 --- a/Engine/NodeOverlay.cpp +++ b/Engine/NodeOverlay.cpp @@ -25,7 +25,7 @@ #include "NodePrivate.h" -#include +#include #include "Engine/EffectInstance.h" #include "Engine/KnobTypes.h" diff --git a/Engine/NodePrivate.h b/Engine/NodePrivate.h index d78813a1b..bbad79137 100644 --- a/Engine/NodePrivate.h +++ b/Engine/NodePrivate.h @@ -31,9 +31,9 @@ #include "Node.h" #include "Timer.h" // gettimeofday() -#include -#include -#include +#include +#include +#include #include "Engine/Hash64.h" diff --git a/Engine/OSGLContext.cpp b/Engine/OSGLContext.cpp index 5e4011ba0..b66a92133 100644 --- a/Engine/OSGLContext.cpp +++ b/Engine/OSGLContext.cpp @@ -29,9 +29,9 @@ #include #include // stringstream -#include -#include -#include +#include +#include +#include #include "Engine/AppManager.h" diff --git a/Engine/OSGLContext_win.cpp b/Engine/OSGLContext_win.cpp index 2e994c3eb..4d4f9abaf 100644 --- a/Engine/OSGLContext_win.cpp +++ b/Engine/OSGLContext_win.cpp @@ -29,7 +29,7 @@ #include // std::cerr #include // stringstream -#include // for Q_UNUSED +#include // for Q_UNUSED #include "Engine/AppManager.h" #include "Engine/MemoryInfo.h" // isApplication32Bits diff --git a/Engine/OfxClipInstance.cpp b/Engine/OfxClipInstance.cpp index f79463156..9a674f3bf 100644 --- a/Engine/OfxClipInstance.cpp +++ b/Engine/OfxClipInstance.cpp @@ -32,9 +32,9 @@ #include #include // stringstream -#include -#include -#include +#include +#include +#include #include "Engine/CacheEntry.h" #include "Engine/OfxEffectInstance.h" diff --git a/Engine/OfxClipInstance.h b/Engine/OfxClipInstance.h index 4b016025e..39c92c45d 100644 --- a/Engine/OfxClipInstance.h +++ b/Engine/OfxClipInstance.h @@ -32,7 +32,7 @@ #include CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) //ofx diff --git a/Engine/OfxEffectInstance.cpp b/Engine/OfxEffectInstance.cpp index 325ec3b72..bfb96b568 100644 --- a/Engine/OfxEffectInstance.cpp +++ b/Engine/OfxEffectInstance.cpp @@ -30,10 +30,10 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include // ofxhPropertySuite.h:565:37: warning: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare] // clang-format off diff --git a/Engine/OfxEffectInstance.h b/Engine/OfxEffectInstance.h index 005dd826b..e8fb05489 100644 --- a/Engine/OfxEffectInstance.h +++ b/Engine/OfxEffectInstance.h @@ -32,11 +32,11 @@ #include CLANG_DIAG_OFF(deprecated) -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated) -#include +#include #include "Engine/OutputEffectInstance.h" #include "Engine/ViewIdx.h" diff --git a/Engine/OfxHost.cpp b/Engine/OfxHost.cpp index 6d1e0e8c1..b857d6a8a 100644 --- a/Engine/OfxHost.cpp +++ b/Engine/OfxHost.cpp @@ -40,18 +40,18 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) // clang-format off CLANG_DIAG_OFF(deprecated-register) //'register' storage class specifier is deprecated -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include CLANG_DIAG_ON(deprecated-register) // clang-format on #ifdef OFX_SUPPORTS_MULTITHREAD -#include -#include +#include +#include #include // QtCore on Qt4, QtConcurrent on Qt5 #endif CLANG_DIAG_ON(deprecated) diff --git a/Engine/OfxHost.h b/Engine/OfxHost.h index 2ce626c6d..9ba0325a4 100644 --- a/Engine/OfxHost.h +++ b/Engine/OfxHost.h @@ -32,7 +32,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/OfxImageEffectInstance.cpp b/Engine/OfxImageEffectInstance.cpp index e5bda6ad3..cceafdd90 100644 --- a/Engine/OfxImageEffectInstance.cpp +++ b/Engine/OfxImageEffectInstance.cpp @@ -36,8 +36,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/OfxImageEffectInstance.h b/Engine/OfxImageEffectInstance.h index 60b7e77d2..54091d3f3 100644 --- a/Engine/OfxImageEffectInstance.h +++ b/Engine/OfxImageEffectInstance.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/OfxMemory.cpp b/Engine/OfxMemory.cpp index fba96559c..4600a24d7 100644 --- a/Engine/OfxMemory.cpp +++ b/Engine/OfxMemory.cpp @@ -29,7 +29,7 @@ #include CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) #include "Engine/EffectInstance.h" diff --git a/Engine/OfxParamInstance.cpp b/Engine/OfxParamInstance.cpp index 91facaf65..f4d954986 100644 --- a/Engine/OfxParamInstance.cpp +++ b/Engine/OfxParamInstance.cpp @@ -36,7 +36,7 @@ #include #include -#include +#include #include "Global/GlobalDefines.h" #include "Engine/AppManager.h" diff --git a/Engine/OfxParamInstance.h b/Engine/OfxParamInstance.h index 45eb573f8..2f16ccf70 100644 --- a/Engine/OfxParamInstance.h +++ b/Engine/OfxParamInstance.h @@ -33,8 +33,8 @@ #include CLANG_DIAG_OFF(deprecated) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) diff --git a/Engine/OutputEffectInstance.cpp b/Engine/OutputEffectInstance.cpp index 00a591483..0db16894f 100644 --- a/Engine/OutputEffectInstance.cpp +++ b/Engine/OutputEffectInstance.cpp @@ -32,10 +32,10 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include #include // QtCore on Qt4, QtConcurrent on Qt5 #include // QtCore on Qt4, QtConcurrent on Qt5 diff --git a/Engine/OutputEffectInstance.h b/Engine/OutputEffectInstance.h index 977f98aff..0c3478b96 100644 --- a/Engine/OutputEffectInstance.h +++ b/Engine/OutputEffectInstance.h @@ -30,7 +30,7 @@ #include -#include +#include #include "Engine/EffectInstance.h" #include "Engine/ViewIdx.h" diff --git a/Engine/OutputSchedulerThread.cpp b/Engine/OutputSchedulerThread.cpp index 49d7910bc..048b7acd7 100644 --- a/Engine/OutputSchedulerThread.cpp +++ b/Engine/OutputSchedulerThread.cpp @@ -34,15 +34,15 @@ #include #include // stringstream -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include "Global/MathUtils.h" #ifdef DEBUG diff --git a/Engine/OutputSchedulerThread.h b/Engine/OutputSchedulerThread.h index 9effc483d..856f53451 100644 --- a/Engine/OutputSchedulerThread.h +++ b/Engine/OutputSchedulerThread.h @@ -30,8 +30,8 @@ #include -#include -#include +#include +#include #include "Global/GlobalDefines.h" diff --git a/Engine/OverlaySupport.h b/Engine/OverlaySupport.h index e03fe0616..06cc290e9 100644 --- a/Engine/OverlaySupport.h +++ b/Engine/OverlaySupport.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/Plugin.cpp b/Engine/Plugin.cpp index 1478a5e36..d9df86cad 100644 --- a/Engine/Plugin.cpp +++ b/Engine/Plugin.cpp @@ -30,7 +30,7 @@ #include #include -#include +#include #include "Engine/AppManager.h" #include "Engine/LibraryBinary.h" diff --git a/Engine/Plugin.h b/Engine/Plugin.h index 3f1b74334..1873bc5a9 100644 --- a/Engine/Plugin.h +++ b/Engine/Plugin.h @@ -32,9 +32,9 @@ #include #include #include -#include -#include -#include +#include +#include +#include #include "Global/Enums.h" #include "Engine/EngineFwd.h" diff --git a/Engine/PluginMemory.cpp b/Engine/PluginMemory.cpp index 26a2697c9..290149c0c 100644 --- a/Engine/PluginMemory.cpp +++ b/Engine/PluginMemory.cpp @@ -30,7 +30,7 @@ #include CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) #include "Engine/EffectInstance.h" #include "Engine/CacheEntry.h" diff --git a/Engine/PrecompNode.cpp b/Engine/PrecompNode.cpp index a6af1facf..ef52908e1 100644 --- a/Engine/PrecompNode.cpp +++ b/Engine/PrecompNode.cpp @@ -34,7 +34,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/ProcessHandler.cpp b/Engine/ProcessHandler.cpp index f1204af73..f1ba52a27 100644 --- a/Engine/ProcessHandler.cpp +++ b/Engine/ProcessHandler.cpp @@ -28,16 +28,16 @@ #include #include -#include // for Q_OS_* -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include // for Q_OS_* +#include +#include +#include +#include +#include +#include +#include +#include +#include #ifdef DEBUG #include "Global/FloatingPointExceptions.h" diff --git a/Engine/ProcessHandler.h b/Engine/ProcessHandler.h index abae69ea1..2bbc3e73b 100644 --- a/Engine/ProcessHandler.h +++ b/Engine/ProcessHandler.h @@ -29,12 +29,12 @@ #include "Global/Macros.h" CLANG_DIAG_OFF(deprecated) -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include CLANG_DIAG_ON(deprecated) #include "Global/GlobalDefines.h" diff --git a/Engine/Project.cpp b/Engine/Project.cpp index 1f4ffc4b0..cc6c75cf9 100644 --- a/Engine/Project.cpp +++ b/Engine/Project.cpp @@ -44,16 +44,16 @@ #endif -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include // QtCore on Qt4, QtConcurrent on Qt5 #include // OFX::XML::escape diff --git a/Engine/Project.h b/Engine/Project.h index c18f25c27..9e3bedce4 100644 --- a/Engine/Project.h +++ b/Engine/Project.h @@ -33,8 +33,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/ProjectPrivate.cpp b/Engine/ProjectPrivate.cpp index 7a298e4c2..bd5035fca 100644 --- a/Engine/ProjectPrivate.cpp +++ b/Engine/ProjectPrivate.cpp @@ -30,11 +30,11 @@ #include #include // stringstream -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #include "Global/PythonUtils.h" diff --git a/Engine/ProjectPrivate.h b/Engine/ProjectPrivate.h index 0935016cd..edfc391b4 100644 --- a/Engine/ProjectPrivate.h +++ b/Engine/ProjectPrivate.h @@ -33,12 +33,12 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include -#include +#include +#include +#include #include #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/PyAppInstance.cpp b/Engine/PyAppInstance.cpp index d9ae1f858..38b4a04bd 100644 --- a/Engine/PyAppInstance.cpp +++ b/Engine/PyAppInstance.cpp @@ -29,7 +29,7 @@ #include #include // stringstream -#include +#include #include "Engine/AppInstance.h" #include "Engine/CreateNodeArgs.h" diff --git a/Engine/PyAppInstance.h b/Engine/PyAppInstance.h index 5a704a138..18bbca23e 100644 --- a/Engine/PyAppInstance.h +++ b/Engine/PyAppInstance.h @@ -37,8 +37,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/ReadNode.cpp b/Engine/ReadNode.cpp index 4f86bb8f4..3b4af89f9 100644 --- a/Engine/ReadNode.cpp +++ b/Engine/ReadNode.cpp @@ -48,8 +48,8 @@ GCC_DIAG_ON(unused-parameter) CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/RenderStats.cpp b/Engine/RenderStats.cpp index 4f6b77956..b0314435a 100644 --- a/Engine/RenderStats.cpp +++ b/Engine/RenderStats.cpp @@ -29,7 +29,7 @@ #include #include -#include +#include #include "Engine/Node.h" #include "Engine/Timer.h" diff --git a/Engine/RotoContext.cpp b/Engine/RotoContext.cpp index e07710d6e..36281f7c1 100644 --- a/Engine/RotoContext.cpp +++ b/Engine/RotoContext.cpp @@ -34,8 +34,8 @@ #include // for std::memcpy, std::memset #include // stringstream -#include -#include +#include +#include //#define ROTO_RENDER_TRIANGLES_ONLY diff --git a/Engine/RotoContext.h b/Engine/RotoContext.h index eaaff66f4..18c9057ef 100644 --- a/Engine/RotoContext.h +++ b/Engine/RotoContext.h @@ -34,9 +34,9 @@ // clang-format off CLANG_DIAG_OFF(deprecated-declarations) -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated-declarations) // clang-format on diff --git a/Engine/RotoContextPrivate.h b/Engine/RotoContextPrivate.h index aad27495e..8eff9599d 100644 --- a/Engine/RotoContextPrivate.h +++ b/Engine/RotoContextPrivate.h @@ -38,12 +38,12 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/RotoDrawableItem.cpp b/Engine/RotoDrawableItem.cpp index b27498721..08bd6a20f 100644 --- a/Engine/RotoDrawableItem.cpp +++ b/Engine/RotoDrawableItem.cpp @@ -33,8 +33,8 @@ #include // for std::memcpy #include -#include -#include +#include +#include #include "Engine/RotoContextPrivate.h" diff --git a/Engine/RotoDrawableItem.h b/Engine/RotoDrawableItem.h index e81870cc3..c4c5c638e 100644 --- a/Engine/RotoDrawableItem.h +++ b/Engine/RotoDrawableItem.h @@ -34,9 +34,9 @@ // clang-format off CLANG_DIAG_OFF(deprecated-declarations) -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated-declarations) // clang-format on diff --git a/Engine/RotoItem.cpp b/Engine/RotoItem.cpp index b8d59a861..db33f5752 100644 --- a/Engine/RotoItem.cpp +++ b/Engine/RotoItem.cpp @@ -32,8 +32,8 @@ #include #include -#include -#include +#include +#include #include "Engine/AppInstance.h" #include "Engine/BezierCP.h" diff --git a/Engine/RotoItem.h b/Engine/RotoItem.h index a37e50340..4160f000d 100644 --- a/Engine/RotoItem.h +++ b/Engine/RotoItem.h @@ -34,9 +34,9 @@ // clang-format off CLANG_DIAG_OFF(deprecated-declarations) -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated-declarations) // clang-format on diff --git a/Engine/RotoLayer.cpp b/Engine/RotoLayer.cpp index fa2d53287..734d4d5e0 100644 --- a/Engine/RotoLayer.cpp +++ b/Engine/RotoLayer.cpp @@ -32,8 +32,8 @@ #include #include -#include -#include +#include +#include #include "Engine/AppInstance.h" #include "Engine/Bezier.h" diff --git a/Engine/RotoLayer.h b/Engine/RotoLayer.h index 6dbc0a7ed..2f6b39e20 100644 --- a/Engine/RotoLayer.h +++ b/Engine/RotoLayer.h @@ -34,9 +34,9 @@ // clang-format off CLANG_DIAG_OFF(deprecated-declarations) -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated-declarations) // clang-format on diff --git a/Engine/RotoPaintInteract.cpp b/Engine/RotoPaintInteract.cpp index 2ea85156b..9ceac356f 100644 --- a/Engine/RotoPaintInteract.cpp +++ b/Engine/RotoPaintInteract.cpp @@ -28,7 +28,7 @@ #include -#include +#include #include "Global/GLIncludes.h" #include "Engine/KnobTypes.h" diff --git a/Engine/RotoPaintInteract.h b/Engine/RotoPaintInteract.h index e80d614d7..c5c638c00 100644 --- a/Engine/RotoPaintInteract.h +++ b/Engine/RotoPaintInteract.h @@ -29,8 +29,8 @@ #include "Global/Macros.h" #include -#include -#include +#include +#include #include diff --git a/Engine/RotoPoint.h b/Engine/RotoPoint.h index e0cb6876f..63ebe0abc 100644 --- a/Engine/RotoPoint.h +++ b/Engine/RotoPoint.h @@ -34,9 +34,9 @@ // clang-format off CLANG_DIAG_OFF(deprecated-declarations) -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated-declarations) // clang-format on diff --git a/Engine/RotoStrokeItem.cpp b/Engine/RotoStrokeItem.cpp index 12cf842e9..a682f99b9 100644 --- a/Engine/RotoStrokeItem.cpp +++ b/Engine/RotoStrokeItem.cpp @@ -32,8 +32,8 @@ #include #include -#include -#include +#include +#include #include "Engine/AppInstance.h" diff --git a/Engine/RotoStrokeItem.h b/Engine/RotoStrokeItem.h index b816fe10e..d6d571d07 100644 --- a/Engine/RotoStrokeItem.h +++ b/Engine/RotoStrokeItem.h @@ -34,9 +34,9 @@ // clang-format off CLANG_DIAG_OFF(deprecated-declarations) -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated-declarations) // clang-format on diff --git a/Engine/RotoUndoCommand.cpp b/Engine/RotoUndoCommand.cpp index 2cbf6a453..461db98fe 100644 --- a/Engine/RotoUndoCommand.cpp +++ b/Engine/RotoUndoCommand.cpp @@ -29,7 +29,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/RotoUndoCommand.h b/Engine/RotoUndoCommand.h index b6656ce4b..611e19657 100644 --- a/Engine/RotoUndoCommand.h +++ b/Engine/RotoUndoCommand.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/ScriptObject.cpp b/Engine/ScriptObject.cpp index 205e02ca5..c21090103 100644 --- a/Engine/ScriptObject.cpp +++ b/Engine/ScriptObject.cpp @@ -29,7 +29,7 @@ #include #include -#include +#include NATRON_NAMESPACE_ENTER diff --git a/Engine/Settings.cpp b/Engine/Settings.cpp index 02c52afec..64b63b4c7 100644 --- a/Engine/Settings.cpp +++ b/Engine/Settings.cpp @@ -29,12 +29,12 @@ #include #include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include #ifdef WINDOWS #include diff --git a/Engine/Singleton.h b/Engine/Singleton.h index 22558203d..63fce8b1f 100644 --- a/Engine/Singleton.h +++ b/Engine/Singleton.h @@ -30,7 +30,7 @@ #include // for std::atexit() -#include +#include #include "Engine/EngineFwd.h" diff --git a/Engine/StandardPaths.cpp b/Engine/StandardPaths.cpp index ae7549246..adf0572fe 100644 --- a/Engine/StandardPaths.cpp +++ b/Engine/StandardPaths.cpp @@ -28,14 +28,14 @@ #include #include -#include -#include -#include +#include +#include +#include #include #include "Global/GlobalDefines.h" -#include // for Q_OS_* +#include // for Q_OS_* #if defined(Q_OS_WIN) #include #include @@ -44,7 +44,7 @@ #define CSIDL_MYMUSIC 13 #define CSIDL_MYVIDEO 14 #endif -#include +#include #elif defined(Q_OS_LINUX) || defined(Q_OS_FREEBSD) #include @@ -53,7 +53,7 @@ #include #include CLANG_DIAG_OFF(deprecated) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Engine/StandardPaths.h b/Engine/StandardPaths.h index cc8092dd4..7cff5ebcb 100644 --- a/Engine/StandardPaths.h +++ b/Engine/StandardPaths.h @@ -28,7 +28,7 @@ #include "Global/Macros.h" -#include +#include #include "Engine/EngineFwd.h" diff --git a/Engine/StringAnimationManager.cpp b/Engine/StringAnimationManager.cpp index 173779188..0b92d6b39 100644 --- a/Engine/StringAnimationManager.cpp +++ b/Engine/StringAnimationManager.cpp @@ -30,7 +30,7 @@ #include #include -#include +#include #include #include // PropSpec diff --git a/Engine/TLSHolder.cpp b/Engine/TLSHolder.cpp index 235bc67ea..b2fca830a 100644 --- a/Engine/TLSHolder.cpp +++ b/Engine/TLSHolder.cpp @@ -35,9 +35,9 @@ #include "Engine/Project.h" #include "Engine/ThreadPool.h" -#include -#include -#include +#include +#include +#include NATRON_NAMESPACE_ENTER diff --git a/Engine/TLSHolder.h b/Engine/TLSHolder.h index 25968365a..48eb354aa 100644 --- a/Engine/TLSHolder.h +++ b/Engine/TLSHolder.h @@ -36,8 +36,8 @@ #include "Global/GlobalDefines.h" -#include -#include +#include +#include #include "Engine/EngineFwd.h" diff --git a/Engine/ThreadPool.cpp b/Engine/ThreadPool.cpp index 03fd1e03e..02f27989e 100644 --- a/Engine/ThreadPool.cpp +++ b/Engine/ThreadPool.cpp @@ -28,10 +28,10 @@ #include #include // stringstream -#include -#include -#include -#include +#include +#include +#include +#include #include "Engine/AbortableRenderInfo.h" #include "Engine/Node.h" diff --git a/Engine/ThreadPool.h b/Engine/ThreadPool.h index 9fc9bcfe1..6a7b4ae4d 100644 --- a/Engine/ThreadPool.h +++ b/Engine/ThreadPool.h @@ -28,7 +28,7 @@ #include "Global/Macros.h" -#include // defines QT_CUSTOM_THREADPOOL (or not) +#include // defines QT_CUSTOM_THREADPOOL (or not) #include "Engine/EngineFwd.h" diff --git a/Engine/ThreadStorage.h b/Engine/ThreadStorage.h index ac48b4702..de8e421b1 100644 --- a/Engine/ThreadStorage.h +++ b/Engine/ThreadStorage.h @@ -28,9 +28,9 @@ #include "Global/Macros.h" -#include -#include -#include +#include +#include +#include #include "Engine/EngineFwd.h" diff --git a/Engine/TimeLine.cpp b/Engine/TimeLine.cpp index 2b0a84eae..be658fcbc 100644 --- a/Engine/TimeLine.cpp +++ b/Engine/TimeLine.cpp @@ -29,8 +29,8 @@ #include #ifndef NDEBUG -#include -#include +#include +#include #endif #include "Engine/Project.h" diff --git a/Engine/TimeLine.h b/Engine/TimeLine.h index 63b1de056..f07aca84b 100644 --- a/Engine/TimeLine.h +++ b/Engine/TimeLine.h @@ -31,8 +31,8 @@ #include CLANG_DIAG_OFF(deprecated) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) #include "Global/GlobalDefines.h" diff --git a/Engine/Timer.cpp b/Engine/Timer.cpp index aa7e59a42..9fd75b7c3 100644 --- a/Engine/Timer.cpp +++ b/Engine/Timer.cpp @@ -31,8 +31,8 @@ #include #include -#include -#include +#include +#include #include "Global/GlobalDefines.h" diff --git a/Engine/Timer.h b/Engine/Timer.h index ae58ae72a..f7015e295 100644 --- a/Engine/Timer.h +++ b/Engine/Timer.h @@ -41,9 +41,9 @@ #endif -#include -#include -#include +#include +#include +#include #include "Engine/EngineFwd.h" diff --git a/Engine/TrackMarker.cpp b/Engine/TrackMarker.cpp index eb98dcd13..a5493c3f3 100644 --- a/Engine/TrackMarker.cpp +++ b/Engine/TrackMarker.cpp @@ -25,7 +25,7 @@ #include "TrackMarker.h" -#include +#include #include "Engine/AbortableRenderInfo.h" #include "Engine/CreateNodeArgs.h" diff --git a/Engine/TrackerContext.cpp b/Engine/TrackerContext.cpp index 0ddad33c3..33eb0ed7e 100644 --- a/Engine/TrackerContext.cpp +++ b/Engine/TrackerContext.cpp @@ -31,9 +31,9 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/TrackerContext.h b/Engine/TrackerContext.h index 19d69cc27..740b4b8bf 100644 --- a/Engine/TrackerContext.h +++ b/Engine/TrackerContext.h @@ -33,8 +33,8 @@ #include "Global/GlobalDefines.h" -#include -#include +#include +#include #include "Global/KeySymbols.h" #include "Engine/EngineFwd.h" diff --git a/Engine/TrackerContextPrivate.cpp b/Engine/TrackerContextPrivate.cpp index 57ba0f20f..449fb603b 100644 --- a/Engine/TrackerContextPrivate.cpp +++ b/Engine/TrackerContextPrivate.cpp @@ -31,7 +31,7 @@ #include #endif -#include +#include #include "Engine/AppInstance.h" #include "Engine/Curve.h" diff --git a/Engine/TrackerFrameAccessor.cpp b/Engine/TrackerFrameAccessor.cpp index 3f2b3a633..00e07841f 100644 --- a/Engine/TrackerFrameAccessor.cpp +++ b/Engine/TrackerFrameAccessor.cpp @@ -35,7 +35,7 @@ GCC_DIAG_ON(unused-function) GCC_DIAG_ON(unused-parameter) // clang-format on -#include +#include #include "Engine/AbortableRenderInfo.h" #include "Engine/AppInstance.h" diff --git a/Engine/TrackerNodeInteract.h b/Engine/TrackerNodeInteract.h index cbef0c1b9..b845f11bd 100644 --- a/Engine/TrackerNodeInteract.h +++ b/Engine/TrackerNodeInteract.h @@ -30,8 +30,8 @@ #include #include -#include -#include +#include +#include #include diff --git a/Engine/TrackerUndoCommand.h b/Engine/TrackerUndoCommand.h index 45d225075..4527cb08a 100644 --- a/Engine/TrackerUndoCommand.h +++ b/Engine/TrackerUndoCommand.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/Utils.cpp b/Engine/Utils.cpp index 738f26619..e2b647104 100644 --- a/Engine/Utils.cpp +++ b/Engine/Utils.cpp @@ -27,9 +27,9 @@ #include -#include -#include -#include +#include +#include +#include NATRON_NAMESPACE_ENTER diff --git a/Engine/Variant.h b/Engine/Variant.h index f08639bc5..efad8dcd9 100644 --- a/Engine/Variant.h +++ b/Engine/Variant.h @@ -29,12 +29,12 @@ #include "Global/Macros.h" CLANG_DIAG_OFF(deprecated) -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include CLANG_DIAG_ON(deprecated) #include "Engine/EngineFwd.h" diff --git a/Engine/ViewerInstance.cpp b/Engine/ViewerInstance.cpp index 75f86ff27..acd55c5e6 100644 --- a/Engine/ViewerInstance.cpp +++ b/Engine/ViewerInstance.cpp @@ -33,13 +33,13 @@ #include CLANG_DIAG_OFF(deprecated) -#include +#include #include // QtCore on Qt4, QtConcurrent on Qt5 -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include CLANG_DIAG_ON(deprecated) #include "Engine/AppInstance.h" diff --git a/Engine/ViewerInstancePrivate.h b/Engine/ViewerInstancePrivate.h index 7fa3ec0ca..6910488c5 100644 --- a/Engine/ViewerInstancePrivate.h +++ b/Engine/ViewerInstancePrivate.h @@ -37,11 +37,11 @@ #include #include // min, max -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #include "Engine/AbortableRenderInfo.h" #include "Engine/OutputSchedulerThread.h" diff --git a/Engine/WriteNode.cpp b/Engine/WriteNode.cpp index 47834783b..68984d921 100644 --- a/Engine/WriteNode.cpp +++ b/Engine/WriteNode.cpp @@ -46,7 +46,7 @@ GCC_DIAG_ON(unused-parameter) CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Engine/pch.h b/Engine/pch.h index db89a8bb8..30724c08d 100644 --- a/Engine/pch.h +++ b/Engine/pch.h @@ -34,7 +34,7 @@ GCC_DIAG_UNUSED_LOCAL_TYPEDEFS_OFF GCC_ONLY_DIAG_OFF(class-memaccess) -#include +#include GCC_ONLY_DIAG_ON(class-memaccess) #include GCC_DIAG_UNUSED_LOCAL_TYPEDEFS_ON diff --git a/Global/Enums.h b/Global/Enums.h index fbcb456ff..11440d611 100644 --- a/Global/Enums.h +++ b/Global/Enums.h @@ -22,9 +22,9 @@ #include "Global/Macros.h" -#include +#include CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) NATRON_NAMESPACE_ENTER diff --git a/Global/GlobalDefines.h b/Global/GlobalDefines.h index 2b2476511..1c4ecde28 100644 --- a/Global/GlobalDefines.h +++ b/Global/GlobalDefines.h @@ -48,10 +48,10 @@ #undef isalpha #undef isalnum -#include -#include +#include +#include CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) #include "Global/Enums.h" diff --git a/Global/KeySymbols.h b/Global/KeySymbols.h index 70b1f0d4a..a44d5094f 100644 --- a/Global/KeySymbols.h +++ b/Global/KeySymbols.h @@ -21,7 +21,7 @@ #define KEYSYMBOLS_H #include -#include +#include NATRON_NAMESPACE_ENTER enum Key { diff --git a/Global/QtCompat.h b/Global/QtCompat.h index 10a68eac2..53e36c366 100644 --- a/Global/QtCompat.h +++ b/Global/QtCompat.h @@ -21,10 +21,10 @@ #include "Global/Macros.h" -#include // for Q_OS_* -#include -#include -#include +#include // for Q_OS_* +#include +#include +#include NATRON_NAMESPACE_ENTER diff --git a/Gui/AboutWindow.cpp b/Gui/AboutWindow.cpp index e7827a128..8dc8f5fda 100644 --- a/Gui/AboutWindow.cpp +++ b/Gui/AboutWindow.cpp @@ -36,11 +36,11 @@ CLANG_DIAG_OFF(deprecated) #include #include #include -#include -#include +#include +#include #include #include -#include +#include CLANG_DIAG_ON(deprecated) #include diff --git a/Gui/ActionShortcuts.h b/Gui/ActionShortcuts.h index 2605ae77e..68e8d4b9b 100644 --- a/Gui/ActionShortcuts.h +++ b/Gui/ActionShortcuts.h @@ -40,7 +40,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include #include -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/AddKnobDialog.cpp b/Gui/AddKnobDialog.cpp index 03a47901b..789b6fa3d 100644 --- a/Gui/AddKnobDialog.cpp +++ b/Gui/AddKnobDialog.cpp @@ -32,7 +32,7 @@ #include #include -#include +#include #include #include "Engine/EffectInstance.h" diff --git a/Gui/AnimatedCheckBox.h b/Gui/AnimatedCheckBox.h index b13a34715..7e2cbf360 100644 --- a/Gui/AnimatedCheckBox.h +++ b/Gui/AnimatedCheckBox.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/BackdropGui.cpp b/Gui/BackdropGui.cpp index 7aabce4ba..ca5d768d1 100644 --- a/Gui/BackdropGui.cpp +++ b/Gui/BackdropGui.cpp @@ -31,8 +31,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/CMakeLists.txt b/Gui/CMakeLists.txt index d20159d93..301e0c8e6 100644 --- a/Gui/CMakeLists.txt +++ b/Gui/CMakeLists.txt @@ -37,9 +37,6 @@ set(shiboken_args ${PYGUI_INCS} "-T../Engine" "-T${PYSIDE_TYPESYSTEMS}" "--output-directory=${PYGUI_OUT}" "${PYGUI_HEADER}" "typesystem_natronGui.xml") -if(APPLE) - list(APPEND shiboken_args -I${Qt5_DIR}/../../../include) -endif() execute_process(COMMAND ${Python3_EXECUTABLE} ../tools/utils/sourceList.py typesystem_natronGui.xml ${PYGUI_OUT} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} diff --git a/Gui/ChannelsComboBox.cpp b/Gui/ChannelsComboBox.cpp index 54c7aa95b..33fa93de5 100644 --- a/Gui/ChannelsComboBox.cpp +++ b/Gui/ChannelsComboBox.cpp @@ -28,11 +28,11 @@ #include #include -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include diff --git a/Gui/ClickableLabel.h b/Gui/ClickableLabel.h index bea19c181..668f1005a 100644 --- a/Gui/ClickableLabel.h +++ b/Gui/ClickableLabel.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ComboBox.cpp b/Gui/ComboBox.cpp index a8c67678d..f3e7dd384 100644 --- a/Gui/ComboBox.cpp +++ b/Gui/ComboBox.cpp @@ -34,7 +34,7 @@ #include #include #include -#include +#include #include #include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF diff --git a/Gui/ComboBox.h b/Gui/ComboBox.h index cb24ee5bc..65296a718 100644 --- a/Gui/ComboBox.h +++ b/Gui/ComboBox.h @@ -32,10 +32,10 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/CurveEditorUndoRedo.cpp b/Gui/CurveEditorUndoRedo.cpp index 64c5b70e4..72ec83c9e 100644 --- a/Gui/CurveEditorUndoRedo.cpp +++ b/Gui/CurveEditorUndoRedo.cpp @@ -28,7 +28,7 @@ #include #include -#include +#include #include "Global/GlobalDefines.h" diff --git a/Gui/CurveEditorUndoRedo.h b/Gui/CurveEditorUndoRedo.h index 8706eb864..31834c51e 100644 --- a/Gui/CurveEditorUndoRedo.h +++ b/Gui/CurveEditorUndoRedo.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include // in QtGui on Qt4, in QtWidgets on Qt5 CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/CurveGui.cpp b/Gui/CurveGui.cpp index 0452af3ae..32386f637 100644 --- a/Gui/CurveGui.cpp +++ b/Gui/CurveGui.cpp @@ -30,10 +30,10 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include #include "Engine/Bezier.h" #include "Engine/Knob.h" diff --git a/Gui/CurveGui.h b/Gui/CurveGui.h index 83f54f98f..20c15d6b4 100644 --- a/Gui/CurveGui.h +++ b/Gui/CurveGui.h @@ -30,8 +30,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include // QObject -#include // QColor +#include // QObject +#include // QColor CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/CurveWidget.cpp b/Gui/CurveWidget.cpp index 9fe4a612e..67fe8b60e 100644 --- a/Gui/CurveWidget.cpp +++ b/Gui/CurveWidget.cpp @@ -34,8 +34,8 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include -#include +#include +#include #include #include #include diff --git a/Gui/CurveWidget.h b/Gui/CurveWidget.h index 248e89775..1d9015a34 100644 --- a/Gui/CurveWidget.h +++ b/Gui/CurveWidget.h @@ -34,10 +34,10 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/CurveWidgetDialogs.cpp b/Gui/CurveWidgetDialogs.cpp index 5d0f4df48..19d694e77 100644 --- a/Gui/CurveWidgetDialogs.cpp +++ b/Gui/CurveWidgetDialogs.cpp @@ -32,13 +32,13 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF //// /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include #include // in QtGui on Qt4, in QtWidgets on Qt5 #include // in QtGui on Qt4, in QtWidgets on Qt5 -#include -#include -#include +#include +#include +#include #include "Engine/AppManager.h" // appPTR #include "Engine/Knob.h" diff --git a/Gui/CurveWidgetDialogs.h b/Gui/CurveWidgetDialogs.h index d705dd4ab..63705c63b 100644 --- a/Gui/CurveWidgetDialogs.h +++ b/Gui/CurveWidgetDialogs.h @@ -32,9 +32,9 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/CurveWidgetPrivate.cpp b/Gui/CurveWidgetPrivate.cpp index 0cad9bf80..dc3eea48a 100644 --- a/Gui/CurveWidgetPrivate.cpp +++ b/Gui/CurveWidgetPrivate.cpp @@ -30,9 +30,9 @@ #include #include -#include +#include #include -#include +#include #include "Engine/Bezier.h" #include "Engine/TimeLine.h" diff --git a/Gui/CurveWidgetPrivate.h b/Gui/CurveWidgetPrivate.h index 8797e3d0a..e35b3f857 100644 --- a/Gui/CurveWidgetPrivate.h +++ b/Gui/CurveWidgetPrivate.h @@ -38,7 +38,7 @@ #include "Gui/GuiFwd.h" #include "Engine/OfxOverlayInteract.h" -#include +#include #define CURVEWIDGET_DERIVATIVE_ROUND_PRECISION 3 diff --git a/Gui/CustomParamInteract.cpp b/Gui/CustomParamInteract.cpp index a63a4c3bd..3ae944bbd 100644 --- a/Gui/CustomParamInteract.cpp +++ b/Gui/CustomParamInteract.cpp @@ -27,11 +27,11 @@ #include -#include -#include -#include +#include +#include +#include #include -#include +#include #include diff --git a/Gui/DockablePanel.cpp b/Gui/DockablePanel.cpp index bc90fc1d6..2ca62895c 100644 --- a/Gui/DockablePanel.cpp +++ b/Gui/DockablePanel.cpp @@ -29,16 +29,16 @@ #include // qApp #include -#include -#include +#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include -#include -#include +#include +#include #include #include diff --git a/Gui/DockablePanelPrivate.cpp b/Gui/DockablePanelPrivate.cpp index 617dd3dad..8d86f9243 100644 --- a/Gui/DockablePanelPrivate.cpp +++ b/Gui/DockablePanelPrivate.cpp @@ -29,7 +29,7 @@ #include #include -#include +#include #include #include #include diff --git a/Gui/DockablePanelPrivate.h b/Gui/DockablePanelPrivate.h index b8ced07a0..bac1465fb 100644 --- a/Gui/DockablePanelPrivate.h +++ b/Gui/DockablePanelPrivate.h @@ -32,7 +32,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include #include diff --git a/Gui/DockablePanelTabWidget.h b/Gui/DockablePanelTabWidget.h index 87f9e6860..3b3dac07a 100644 --- a/Gui/DockablePanelTabWidget.h +++ b/Gui/DockablePanelTabWidget.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/DocumentationManager.cpp b/Gui/DocumentationManager.cpp index c064dec14..f112edd5e 100644 --- a/Gui/DocumentationManager.cpp +++ b/Gui/DocumentationManager.cpp @@ -25,10 +25,10 @@ #include "DocumentationManager.h" -#include -#include +#include +#include GCC_ONLY_DIAG_OFF(class-memaccess) -#include +#include GCC_ONLY_DIAG_ON(class-memaccess) #include diff --git a/Gui/DocumentationManager.h b/Gui/DocumentationManager.h index 1b081be9d..d52536cf1 100644 --- a/Gui/DocumentationManager.h +++ b/Gui/DocumentationManager.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/DopeSheet.cpp b/Gui/DopeSheet.cpp index dfb56d14b..547b57762 100644 --- a/Gui/DopeSheet.cpp +++ b/Gui/DopeSheet.cpp @@ -30,8 +30,8 @@ #include // Qt includes -#include -#include +#include +#include #include #include #include diff --git a/Gui/DopeSheetEditor.h b/Gui/DopeSheetEditor.h index cfda33044..91f02a978 100644 --- a/Gui/DopeSheetEditor.h +++ b/Gui/DopeSheetEditor.h @@ -31,8 +31,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/DopeSheetEditorUndoRedo.cpp b/Gui/DopeSheetEditorUndoRedo.cpp index aaba9cb49..dd4755ce3 100644 --- a/Gui/DopeSheetEditorUndoRedo.cpp +++ b/Gui/DopeSheetEditorUndoRedo.cpp @@ -27,7 +27,7 @@ #include -#include +#include #ifndef NATRON_ENABLE_IO_META_NODES #include "Engine/AppInstance.h" diff --git a/Gui/DopeSheetEditorUndoRedo.h b/Gui/DopeSheetEditorUndoRedo.h index c3fe3f3f6..ae9a7288a 100644 --- a/Gui/DopeSheetEditorUndoRedo.h +++ b/Gui/DopeSheetEditorUndoRedo.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include // in QtGui on Qt4, in QtWidgets on Qt5 CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/DopeSheetHierarchyView.cpp b/Gui/DopeSheetHierarchyView.cpp index 5edb84ea8..a65f46b37 100644 --- a/Gui/DopeSheetHierarchyView.cpp +++ b/Gui/DopeSheetHierarchyView.cpp @@ -27,8 +27,8 @@ #include -#include //REMOVEME -#include +#include //REMOVEME +#include #include #include #include diff --git a/Gui/DopeSheetHierarchyView.h b/Gui/DopeSheetHierarchyView.h index d99b6160c..c47de8da6 100644 --- a/Gui/DopeSheetHierarchyView.h +++ b/Gui/DopeSheetHierarchyView.h @@ -33,10 +33,10 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/DopeSheetView.cpp b/Gui/DopeSheetView.cpp index bbaa4e3c2..b0c7bc016 100644 --- a/Gui/DopeSheetView.cpp +++ b/Gui/DopeSheetView.cpp @@ -33,7 +33,7 @@ #include #include #include -#include +#include #include #include diff --git a/Gui/DotGui.cpp b/Gui/DotGui.cpp index 407b3d225..e59249918 100644 --- a/Gui/DotGui.cpp +++ b/Gui/DotGui.cpp @@ -38,7 +38,7 @@ CLANG_DIAG_OFF(uninitialized) #include #include #include -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/DotGui.h b/Gui/DotGui.h index 85298ea64..27ea37afa 100644 --- a/Gui/DotGui.h +++ b/Gui/DotGui.h @@ -32,11 +32,11 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include #include #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/Edge.cpp b/Gui/Edge.cpp index 903cb82ea..a960ef0f2 100644 --- a/Gui/Edge.cpp +++ b/Gui/Edge.cpp @@ -29,7 +29,7 @@ #include #include -#include +#include #include #include #include diff --git a/Gui/EditExpressionDialog.cpp b/Gui/EditExpressionDialog.cpp index d93081c75..60fcc01dc 100644 --- a/Gui/EditExpressionDialog.cpp +++ b/Gui/EditExpressionDialog.cpp @@ -29,14 +29,14 @@ #include #include -#include +#include #include #include #include #include #include #include // in QtGui on Qt4, in QtWidgets on Qt5 -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] @@ -44,7 +44,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include -#include +#include #include #include diff --git a/Gui/EditExpressionDialog.h b/Gui/EditExpressionDialog.h index ef6ee9ff5..014155184 100644 --- a/Gui/EditExpressionDialog.h +++ b/Gui/EditExpressionDialog.h @@ -31,7 +31,7 @@ #include #include -#include +#include #include "Gui/EditScriptDialog.h" #include "Gui/GuiFwd.h" diff --git a/Gui/EditScriptDialog.cpp b/Gui/EditScriptDialog.cpp index 2dfed072b..0af24a054 100644 --- a/Gui/EditScriptDialog.cpp +++ b/Gui/EditScriptDialog.cpp @@ -29,14 +29,14 @@ #include #include -#include +#include #include #include #include #include #include #include // in QtGui on Qt4, in QtWidgets on Qt5 -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] @@ -44,7 +44,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include -#include +#include #include #include diff --git a/Gui/EditScriptDialog.h b/Gui/EditScriptDialog.h index 686010ae0..082035e6e 100644 --- a/Gui/EditScriptDialog.h +++ b/Gui/EditScriptDialog.h @@ -32,8 +32,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ExportGroupTemplateDialog.cpp b/Gui/ExportGroupTemplateDialog.cpp index a299070a6..9e7fe97c7 100644 --- a/Gui/ExportGroupTemplateDialog.cpp +++ b/Gui/ExportGroupTemplateDialog.cpp @@ -31,7 +31,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/FileTypeMainWindow_win.cpp b/Gui/FileTypeMainWindow_win.cpp index 025f0fea1..5cf275db4 100644 --- a/Gui/FileTypeMainWindow_win.cpp +++ b/Gui/FileTypeMainWindow_win.cpp @@ -49,9 +49,9 @@ #include #include -#include -#include -#include +#include +#include +#include NATRON_NAMESPACE_ENTER diff --git a/Gui/FloatingWidget.cpp b/Gui/FloatingWidget.cpp index cca745a26..ea6ca0083 100644 --- a/Gui/FloatingWidget.cpp +++ b/Gui/FloatingWidget.cpp @@ -29,7 +29,7 @@ #include // min, max #include -#include +#include #include #include // qApp diff --git a/Gui/GroupBoxLabel.cpp b/Gui/GroupBoxLabel.cpp index 174235f77..b242cca68 100644 --- a/Gui/GroupBoxLabel.cpp +++ b/Gui/GroupBoxLabel.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/Gui.cpp b/Gui/Gui.cpp index bb48affe7..b6972b2fd 100644 --- a/Gui/Gui.cpp +++ b/Gui/Gui.cpp @@ -28,8 +28,8 @@ #include #include -#include // for Q_OS_* -#include +#include // for Q_OS_* +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include @@ -38,7 +38,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include #include -#include +#include #include "Engine/Node.h" #include "Engine/Project.h" diff --git a/Gui/Gui.h b/Gui/Gui.h index 69187ceaa..8c0a6b52a 100644 --- a/Gui/Gui.h +++ b/Gui/Gui.h @@ -30,9 +30,9 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include // for Q_OS_* +#include // for Q_OS_* #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/Gui05.cpp b/Gui/Gui05.cpp index aec7cc088..dc4719fcd 100644 --- a/Gui/Gui05.cpp +++ b/Gui/Gui05.cpp @@ -28,9 +28,9 @@ #include #include -#include -#include -#include +#include +#include +#include #include #include diff --git a/Gui/Gui20.cpp b/Gui/Gui20.cpp index 7c7b976b3..1ccbb77d1 100644 --- a/Gui/Gui20.cpp +++ b/Gui/Gui20.cpp @@ -33,10 +33,10 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include #include #include diff --git a/Gui/Gui30.cpp b/Gui/Gui30.cpp index c949835de..d5ab9446a 100644 --- a/Gui/Gui30.cpp +++ b/Gui/Gui30.cpp @@ -32,8 +32,8 @@ #include #include -#include -#include +#include +#include #include #include // qApp diff --git a/Gui/Gui40.cpp b/Gui/Gui40.cpp index 820a5bd14..181f12497 100644 --- a/Gui/Gui40.cpp +++ b/Gui/Gui40.cpp @@ -33,12 +33,12 @@ #include #include -#include -#include -#include -#include +#include +#include +#include +#include -#include +#include #include #include // qApp diff --git a/Gui/Gui50.cpp b/Gui/Gui50.cpp index b126c9dab..ef6aa4191 100644 --- a/Gui/Gui50.cpp +++ b/Gui/Gui50.cpp @@ -33,10 +33,10 @@ #include #include -#include // for Q_OS_* -#include -#include -#include +#include // for Q_OS_* +#include +#include +#include #include // qApp GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF @@ -58,7 +58,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include #ifdef Q_WS_X11 -#include +#include #endif #include "Global/QtCompat.h" diff --git a/Gui/GuiAppInstance.cpp b/Gui/GuiAppInstance.cpp index 5a904f897..a4eddc679 100644 --- a/Gui/GuiAppInstance.cpp +++ b/Gui/GuiAppInstance.cpp @@ -28,10 +28,10 @@ #include #include // stringstream -#include +#include #include -#include -#include +#include +#include #include "Engine/CLArgs.h" #include "Engine/Project.h" diff --git a/Gui/GuiApplicationManager.cpp b/Gui/GuiApplicationManager.cpp index f59bcaf90..25df689ca 100644 --- a/Gui/GuiApplicationManager.cpp +++ b/Gui/GuiApplicationManager.cpp @@ -30,9 +30,9 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include // for Q_OS_* -#include -#include +#include // for Q_OS_* +#include +#include #include #include #include diff --git a/Gui/GuiApplicationManager.h b/Gui/GuiApplicationManager.h index 2ceb5ccb6..00d9ad3d6 100644 --- a/Gui/GuiApplicationManager.h +++ b/Gui/GuiApplicationManager.h @@ -31,7 +31,7 @@ #include -#include // for Q_OS_* +#include // for Q_OS_* #include "Engine/AppManager.h" #include "Engine/Variant.h" diff --git a/Gui/GuiApplicationManager10.cpp b/Gui/GuiApplicationManager10.cpp index 99bda2614..452b4255c 100644 --- a/Gui/GuiApplicationManager10.cpp +++ b/Gui/GuiApplicationManager10.cpp @@ -36,10 +36,10 @@ ///gui CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include // for Q_OS_* -#include -#include -#include +#include // for Q_OS_* +#include +#include +#include #include #include #include diff --git a/Gui/GuiApplicationManagerPrivate.cpp b/Gui/GuiApplicationManagerPrivate.cpp index 5d5e5cdc3..63ae44844 100644 --- a/Gui/GuiApplicationManagerPrivate.cpp +++ b/Gui/GuiApplicationManagerPrivate.cpp @@ -31,7 +31,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/GuiApplicationManagerPrivate.h b/Gui/GuiApplicationManagerPrivate.h index e7fd4a761..36fd49206 100644 --- a/Gui/GuiApplicationManagerPrivate.h +++ b/Gui/GuiApplicationManagerPrivate.h @@ -35,8 +35,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/GuiFwd.h b/Gui/GuiFwd.h index 693895126..d939dbe92 100644 --- a/Gui/GuiFwd.h +++ b/Gui/GuiFwd.h @@ -36,7 +36,7 @@ #endif // Qt -#include +#include class QAbstractButton; class QAction; diff --git a/Gui/GuiPrivate.cpp b/Gui/GuiPrivate.cpp index 30cc04b0b..d5fdde1c4 100644 --- a/Gui/GuiPrivate.cpp +++ b/Gui/GuiPrivate.cpp @@ -30,16 +30,16 @@ #include // min, max #include -#include -#include -#include -#include +#include +#include +#include +#include #include #include -#include -#include +#include +#include #include -#include +#include #include #include diff --git a/Gui/GuiPrivate.h b/Gui/GuiPrivate.h index 5ed3d5f15..059d812ce 100644 --- a/Gui/GuiPrivate.h +++ b/Gui/GuiPrivate.h @@ -34,10 +34,10 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include -#include -#include +#include +#include +#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/Histogram.cpp b/Gui/Histogram.cpp index 73a130273..6f09fab58 100644 --- a/Gui/Histogram.cpp +++ b/Gui/Histogram.cpp @@ -37,7 +37,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include #include #include diff --git a/Gui/Histogram.h b/Gui/Histogram.h index cad1f3854..5abbbdbe3 100644 --- a/Gui/Histogram.h +++ b/Gui/Histogram.h @@ -31,7 +31,7 @@ #include "Global/GLIncludes.h" //! +#include CLANG_DIAG_ON(uninitialized) #include diff --git a/Gui/HostOverlay.cpp b/Gui/HostOverlay.cpp index 922046de8..5efe644f5 100644 --- a/Gui/HostOverlay.cpp +++ b/Gui/HostOverlay.cpp @@ -47,9 +47,9 @@ #include "Global/KeySymbols.h" #include "Global/GLIncludes.h" //! -#include -#include +#include +#include +#include #include #include #include diff --git a/Gui/InfoViewerWidget.cpp b/Gui/InfoViewerWidget.cpp index 79fcd6bb6..c796854ff 100644 --- a/Gui/InfoViewerWidget.cpp +++ b/Gui/InfoViewerWidget.cpp @@ -28,12 +28,12 @@ #include #include -#include +#include #include -#include +#include #include #include -#include +#include #include "Engine/ViewerInstance.h" #include "Engine/Lut.h" diff --git a/Gui/InfoViewerWidget.h b/Gui/InfoViewerWidget.h index fa6334404..a537721c8 100644 --- a/Gui/InfoViewerWidget.h +++ b/Gui/InfoViewerWidget.h @@ -31,9 +31,9 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include -#include -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGui.h b/Gui/KnobGui.h index 173249891..1a84a7635 100644 --- a/Gui/KnobGui.h +++ b/Gui/KnobGui.h @@ -32,7 +32,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiBool.cpp b/Gui/KnobGuiBool.cpp index d7a7deede..1af3e8918 100644 --- a/Gui/KnobGuiBool.cpp +++ b/Gui/KnobGuiBool.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiBool.h b/Gui/KnobGuiBool.h index de5a79dab..ad86679b8 100644 --- a/Gui/KnobGuiBool.h +++ b/Gui/KnobGuiBool.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/KnobGuiButton.cpp b/Gui/KnobGuiButton.cpp index 7cffd5741..2d3da0e61 100644 --- a/Gui/KnobGuiButton.cpp +++ b/Gui/KnobGuiButton.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiButton.h b/Gui/KnobGuiButton.h index 0429f8fa9..85d9ee102 100644 --- a/Gui/KnobGuiButton.h +++ b/Gui/KnobGuiButton.h @@ -33,7 +33,7 @@ #include "Global/Macros.h" CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/KnobGuiChoice.cpp b/Gui/KnobGuiChoice.cpp index 2991cb5b1..2a9ae4955 100644 --- a/Gui/KnobGuiChoice.cpp +++ b/Gui/KnobGuiChoice.cpp @@ -47,7 +47,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiChoice.h b/Gui/KnobGuiChoice.h index 1dad91b46..1b4218c80 100644 --- a/Gui/KnobGuiChoice.h +++ b/Gui/KnobGuiChoice.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/KnobGuiColor.cpp b/Gui/KnobGuiColor.cpp index 90d8f4359..683c7cfe6 100644 --- a/Gui/KnobGuiColor.cpp +++ b/Gui/KnobGuiColor.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiColor.h b/Gui/KnobGuiColor.h index c90b9a67c..7dd3df212 100644 --- a/Gui/KnobGuiColor.h +++ b/Gui/KnobGuiColor.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include #include diff --git a/Gui/KnobGuiFile.cpp b/Gui/KnobGuiFile.cpp index 4508880b5..5d857118a 100644 --- a/Gui/KnobGuiFile.cpp +++ b/Gui/KnobGuiFile.cpp @@ -29,7 +29,7 @@ #include // in QtGui on Qt4, in QtWidgets on Qt5 #include // in QtGui on Qt4, in QtWidgets on Qt5 -#include +#include #include #include #include diff --git a/Gui/KnobGuiFile.h b/Gui/KnobGuiFile.h index 53d260dc5..5ca042d7e 100644 --- a/Gui/KnobGuiFile.h +++ b/Gui/KnobGuiFile.h @@ -32,8 +32,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiGroup.cpp b/Gui/KnobGuiGroup.cpp index 969d6a15f..710c916c2 100644 --- a/Gui/KnobGuiGroup.cpp +++ b/Gui/KnobGuiGroup.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiGroup.h b/Gui/KnobGuiGroup.h index b99ecb65a..f2f2455eb 100644 --- a/Gui/KnobGuiGroup.h +++ b/Gui/KnobGuiGroup.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/KnobGuiParametric.cpp b/Gui/KnobGuiParametric.cpp index a54f0e290..7594a4594 100644 --- a/Gui/KnobGuiParametric.cpp +++ b/Gui/KnobGuiParametric.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiParametric.h b/Gui/KnobGuiParametric.h index be06ae359..70e40c6ed 100644 --- a/Gui/KnobGuiParametric.h +++ b/Gui/KnobGuiParametric.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/KnobGuiPrivate.h b/Gui/KnobGuiPrivate.h index 94588250f..410d91609 100644 --- a/Gui/KnobGuiPrivate.h +++ b/Gui/KnobGuiPrivate.h @@ -35,7 +35,7 @@ #include #include -#include +#include #include #include #include @@ -50,7 +50,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include -#include +#include #include #include #include diff --git a/Gui/KnobGuiSeparator.cpp b/Gui/KnobGuiSeparator.cpp index d4f19e5b4..08aedcaee 100644 --- a/Gui/KnobGuiSeparator.cpp +++ b/Gui/KnobGuiSeparator.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiSeparator.h b/Gui/KnobGuiSeparator.h index 060d791f8..cbf322f6e 100644 --- a/Gui/KnobGuiSeparator.h +++ b/Gui/KnobGuiSeparator.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/KnobGuiString.cpp b/Gui/KnobGuiString.cpp index ed2dff80a..d0ef55d9e 100644 --- a/Gui/KnobGuiString.cpp +++ b/Gui/KnobGuiString.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiString.h b/Gui/KnobGuiString.h index 196762d14..0217f1843 100644 --- a/Gui/KnobGuiString.h +++ b/Gui/KnobGuiString.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/KnobGuiValue.cpp b/Gui/KnobGuiValue.cpp index 4bd693f8f..10512d2eb 100644 --- a/Gui/KnobGuiValue.cpp +++ b/Gui/KnobGuiValue.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/KnobGuiValue.h b/Gui/KnobGuiValue.h index 5d503ebd6..a697fea24 100644 --- a/Gui/KnobGuiValue.h +++ b/Gui/KnobGuiValue.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/KnobWidgetDnD.cpp b/Gui/KnobWidgetDnD.cpp index 25c863de6..1905adfac 100644 --- a/Gui/KnobWidgetDnD.cpp +++ b/Gui/KnobWidgetDnD.cpp @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include -#include +#include #include #include #include diff --git a/Gui/KnobWidgetDnD.h b/Gui/KnobWidgetDnD.h index cdb511e17..549f3eb7a 100644 --- a/Gui/KnobWidgetDnD.h +++ b/Gui/KnobWidgetDnD.h @@ -28,7 +28,7 @@ #include "Global/Macros.h" -#include +#include #include "Gui/GuiFwd.h" diff --git a/Gui/Label.h b/Gui/Label.h index 63b38f4d6..03da0a5c6 100644 --- a/Gui/Label.h +++ b/Gui/Label.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include // in QtGui on Qt4, in QtWidgets on Qt5 CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/LineEdit.cpp b/Gui/LineEdit.cpp index 658b5c9f3..2a9722aa7 100644 --- a/Gui/LineEdit.cpp +++ b/Gui/LineEdit.cpp @@ -38,8 +38,8 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include #include -#include -#include +#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/LinkToKnobDialog.cpp b/Gui/LinkToKnobDialog.cpp index 2d57914d5..418c72090 100644 --- a/Gui/LinkToKnobDialog.cpp +++ b/Gui/LinkToKnobDialog.cpp @@ -29,14 +29,14 @@ #include #include -#include +#include #include #include #include #include #include #include // in QtGui on Qt4, in QtWidgets on Qt5 -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] @@ -44,7 +44,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include -#include +#include #include #include diff --git a/Gui/LinkToKnobDialog.h b/Gui/LinkToKnobDialog.h index f8a704d63..cbf6dbfb6 100644 --- a/Gui/LinkToKnobDialog.h +++ b/Gui/LinkToKnobDialog.h @@ -33,8 +33,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/LogWindow.cpp b/Gui/LogWindow.cpp index 921b57d07..3d36f71bd 100644 --- a/Gui/LogWindow.cpp +++ b/Gui/LogWindow.cpp @@ -30,8 +30,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include #include #include #include diff --git a/Gui/MessageBox.cpp b/Gui/MessageBox.cpp index 29f754d3c..e12c5d372 100644 --- a/Gui/MessageBox.cpp +++ b/Gui/MessageBox.cpp @@ -30,7 +30,7 @@ #include "Global/Macros.h" CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include // for Q_OS_* +#include // for Q_OS_* #include #include #include diff --git a/Gui/MultiInstancePanel.cpp b/Gui/MultiInstancePanel.cpp index 22b788d09..65368cf9a 100644 --- a/Gui/MultiInstancePanel.cpp +++ b/Gui/MultiInstancePanel.cpp @@ -31,20 +31,20 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include -#include +#include +#include +#include #include // QtCore on Qt4, QtConcurrent on Qt5 -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/MultiInstancePanel.h b/Gui/MultiInstancePanel.h index 8dc4ca320..17995cef1 100644 --- a/Gui/MultiInstancePanel.h +++ b/Gui/MultiInstancePanel.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/NewLayerDialog.cpp b/Gui/NewLayerDialog.cpp index 2a748bb81..167c24adb 100644 --- a/Gui/NewLayerDialog.cpp +++ b/Gui/NewLayerDialog.cpp @@ -45,7 +45,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] #include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/NodeCreationDialog.cpp b/Gui/NodeCreationDialog.cpp index 912610c86..f73f142bd 100644 --- a/Gui/NodeCreationDialog.cpp +++ b/Gui/NodeCreationDialog.cpp @@ -30,15 +30,15 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include -#include +#include #include #include -#include +#include #include #include #include #include -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/NodeGraph10.cpp b/Gui/NodeGraph10.cpp index 0decd50bb..bf30258a2 100644 --- a/Gui/NodeGraph10.cpp +++ b/Gui/NodeGraph10.cpp @@ -32,7 +32,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/NodeGraph40.cpp b/Gui/NodeGraph40.cpp index 4dcfd66b0..bc82a215f 100644 --- a/Gui/NodeGraph40.cpp +++ b/Gui/NodeGraph40.cpp @@ -47,7 +47,7 @@ GCC_DIAG_ON(unused-parameter) #include #include -#include +#include #include "Engine/Node.h" #include "Engine/NodeGroup.h" diff --git a/Gui/NodeGraph45.cpp b/Gui/NodeGraph45.cpp index 574267ca2..b3e428c3f 100644 --- a/Gui/NodeGraph45.cpp +++ b/Gui/NodeGraph45.cpp @@ -33,7 +33,7 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include #include diff --git a/Gui/NodeGraphPrivate.h b/Gui/NodeGraphPrivate.h index 5d7c948f9..e4630c626 100644 --- a/Gui/NodeGraphPrivate.h +++ b/Gui/NodeGraphPrivate.h @@ -36,13 +36,13 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include #include #include #include #include -#include +#include #include #include #include diff --git a/Gui/NodeGraphTextItem.cpp b/Gui/NodeGraphTextItem.cpp index 211274f0a..5f1977a0a 100644 --- a/Gui/NodeGraphTextItem.cpp +++ b/Gui/NodeGraphTextItem.cpp @@ -28,7 +28,7 @@ #include #include -#include +#include #include #include "Engine/Settings.h" diff --git a/Gui/NodeGraphUndoRedo.cpp b/Gui/NodeGraphUndoRedo.cpp index 317b42cf9..84434d131 100644 --- a/Gui/NodeGraphUndoRedo.cpp +++ b/Gui/NodeGraphUndoRedo.cpp @@ -31,7 +31,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/NodeGraphUndoRedo.h b/Gui/NodeGraphUndoRedo.h index cdc82c7bd..d5c7d4bdb 100644 --- a/Gui/NodeGraphUndoRedo.h +++ b/Gui/NodeGraphUndoRedo.h @@ -32,8 +32,8 @@ #include #include -#include -#include +#include +#include #include #include "Global/GlobalDefines.h" diff --git a/Gui/NodeGui.cpp b/Gui/NodeGui.cpp index 3efe12077..48a009549 100644 --- a/Gui/NodeGui.cpp +++ b/Gui/NodeGui.cpp @@ -31,16 +31,16 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include -#include +#include #include #include #include #include #include -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/NodeGui.h b/Gui/NodeGui.h index ef7634449..c7140a9cb 100644 --- a/Gui/NodeGui.h +++ b/Gui/NodeGui.h @@ -36,15 +36,15 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include -#include +#include +#include +#include GCC_ONLY_DIAG_OFF(class-memaccess) -#include +#include GCC_ONLY_DIAG_ON(class-memaccess) #include #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/NodeSettingsPanel.cpp b/Gui/NodeSettingsPanel.cpp index cc0bd37fc..89f49afad 100644 --- a/Gui/NodeSettingsPanel.cpp +++ b/Gui/NodeSettingsPanel.cpp @@ -32,7 +32,7 @@ #include #include -#include +#include #include "Global/FStreamsSupport.h" diff --git a/Gui/NodeViewerContext.h b/Gui/NodeViewerContext.h index 7bdfb5431..8ba4b5944 100644 --- a/Gui/NodeViewerContext.h +++ b/Gui/NodeViewerContext.h @@ -29,7 +29,7 @@ #include "Global/Macros.h" CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) #include "Engine/ViewIdx.h" diff --git a/Gui/PickKnobDialog.cpp b/Gui/PickKnobDialog.cpp index 49ef89e10..39f06b0d8 100644 --- a/Gui/PickKnobDialog.cpp +++ b/Gui/PickKnobDialog.cpp @@ -32,7 +32,7 @@ #include #include -#include +#include #include "Engine/Knob.h" // KnobI #include "Engine/KnobTypes.h" // KnobButton... diff --git a/Gui/PreviewThread.cpp b/Gui/PreviewThread.cpp index bbbcf3f97..5bf319d30 100644 --- a/Gui/PreviewThread.cpp +++ b/Gui/PreviewThread.cpp @@ -30,8 +30,8 @@ #include #include // for std::memcpy, std::memset -#include -#include +#include +#include #include "Gui/GuiDefines.h" #include "Gui/NodeGui.h" diff --git a/Gui/PreviewThread.h b/Gui/PreviewThread.h index c6ba4fbd7..42bf798c3 100644 --- a/Gui/PreviewThread.h +++ b/Gui/PreviewThread.h @@ -28,7 +28,7 @@ #include "Global/Macros.h" -#include +#include #include "Engine/GenericSchedulerThread.h" diff --git a/Gui/ProgressPanel.cpp b/Gui/ProgressPanel.cpp index 5c0485408..b5797aefa 100644 --- a/Gui/ProgressPanel.cpp +++ b/Gui/ProgressPanel.cpp @@ -30,18 +30,18 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include #include #include #include #include -#include +#include #include #include #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ProgressTaskInfo.cpp b/Gui/ProgressTaskInfo.cpp index a1395ba58..c27cb2085 100644 --- a/Gui/ProgressTaskInfo.cpp +++ b/Gui/ProgressTaskInfo.cpp @@ -27,10 +27,10 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/ProgressTaskInfo.h b/Gui/ProgressTaskInfo.h index 8f196b0db..0c17b8f28 100644 --- a/Gui/ProgressTaskInfo.h +++ b/Gui/ProgressTaskInfo.h @@ -28,7 +28,7 @@ #include "Global/Macros.h" -#include +#include #include "Gui/GuiFwd.h" diff --git a/Gui/ProjectGui.cpp b/Gui/ProjectGui.cpp index 8640f946b..0eddd2e6f 100644 --- a/Gui/ProjectGui.cpp +++ b/Gui/ProjectGui.cpp @@ -33,8 +33,8 @@ CLANG_DIAG_OFF(uninitialized) #include #include #include -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ProjectGui.h b/Gui/ProjectGui.h index f4377b0e0..7021f327e 100644 --- a/Gui/ProjectGui.h +++ b/Gui/ProjectGui.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ProjectGuiSerialization.cpp b/Gui/ProjectGuiSerialization.cpp index f596877cf..2f0daaeca 100644 --- a/Gui/ProjectGuiSerialization.cpp +++ b/Gui/ProjectGuiSerialization.cpp @@ -31,7 +31,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/Pyside_Gui_Python.h b/Gui/Pyside_Gui_Python.h index a6533e901..e29904ff6 100644 --- a/Gui/Pyside_Gui_Python.h +++ b/Gui/Pyside_Gui_Python.h @@ -40,7 +40,7 @@ #include #include -#include +#include //Global #include diff --git a/Gui/PythonPanels.cpp b/Gui/PythonPanels.cpp index 20f8f6d28..4173a01b8 100644 --- a/Gui/PythonPanels.cpp +++ b/Gui/PythonPanels.cpp @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/QtEnumConvert.cpp b/Gui/QtEnumConvert.cpp index 202f350c6..5637f86ad 100644 --- a/Gui/QtEnumConvert.cpp +++ b/Gui/QtEnumConvert.cpp @@ -25,7 +25,7 @@ #include "QtEnumConvert.h" -#include +#include #include NATRON_NAMESPACE_ENTER diff --git a/Gui/QtMac.mm b/Gui/QtMac.mm index ebc0e09a1..dd64086b9 100644 --- a/Gui/QtMac.mm +++ b/Gui/QtMac.mm @@ -19,7 +19,7 @@ #include "Gui/Gui.h" -#include // for Q_OS_* +#include // for Q_OS_* #ifdef Q_OS_DARWIN #include diff --git a/Gui/RenderStatsDialog.cpp b/Gui/RenderStatsDialog.cpp index a0ca89171..a3bb460be 100644 --- a/Gui/RenderStatsDialog.cpp +++ b/Gui/RenderStatsDialog.cpp @@ -28,13 +28,13 @@ #include #include -#include +#include #include #include #include #include #include -#include +#include #include "Engine/Node.h" #include "Engine/Timer.h" diff --git a/Gui/RightClickableWidget.cpp b/Gui/RightClickableWidget.cpp index d101d4577..a1050b2ce 100644 --- a/Gui/RightClickableWidget.cpp +++ b/Gui/RightClickableWidget.cpp @@ -27,7 +27,7 @@ #include -#include +#include #include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] diff --git a/Gui/RotoPanel.cpp b/Gui/RotoPanel.cpp index 9c4f8a8a1..d102d70d7 100644 --- a/Gui/RotoPanel.cpp +++ b/Gui/RotoPanel.cpp @@ -42,8 +42,8 @@ CLANG_DIAG_OFF(uninitialized) #include #include #include -#include -#include +#include +#include #include #include #include diff --git a/Gui/ScaleSliderQWidget.cpp b/Gui/ScaleSliderQWidget.cpp index 1f556802f..195d4ce43 100644 --- a/Gui/ScaleSliderQWidget.cpp +++ b/Gui/ScaleSliderQWidget.cpp @@ -32,10 +32,10 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include -#include +#include +#include #include #include diff --git a/Gui/ScaleSliderQWidget.h b/Gui/ScaleSliderQWidget.h index 279825a81..642b4d777 100644 --- a/Gui/ScaleSliderQWidget.h +++ b/Gui/ScaleSliderQWidget.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ScriptEditor.cpp b/Gui/ScriptEditor.cpp index 612d4d987..a5957e524 100644 --- a/Gui/ScriptEditor.cpp +++ b/Gui/ScriptEditor.cpp @@ -31,14 +31,14 @@ #include #include #include -#include -#include +#include +#include #include -#include +#include #include #include -#include -#include +#include +#include #include #include #include diff --git a/Gui/ScriptTextEdit.cpp b/Gui/ScriptTextEdit.cpp index 74cd9779f..5d58f1ad9 100644 --- a/Gui/ScriptTextEdit.cpp +++ b/Gui/ScriptTextEdit.cpp @@ -33,8 +33,8 @@ CLANG_DIAG_OFF(uninitialized) #include #include #include -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ScriptTextEdit.h b/Gui/ScriptTextEdit.h index 8f3c3d7a8..f3ee988c8 100644 --- a/Gui/ScriptTextEdit.h +++ b/Gui/ScriptTextEdit.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include #include #include diff --git a/Gui/SequenceFileDialog.cpp b/Gui/SequenceFileDialog.cpp index eb73ea80e..01a6c8019 100644 --- a/Gui/SequenceFileDialog.cpp +++ b/Gui/SequenceFileDialog.cpp @@ -25,12 +25,12 @@ #include "SequenceFileDialog.h" -#include // for Q_OS_* +#include // for Q_OS_* #if defined(Q_OS_UNIX) #include #include // for pathconf() on OS X #elif defined(Q_OS_WIN) -# include +# include #endif #include #include @@ -42,7 +42,7 @@ CLANG_DIAG_OFF(uninitialized) #include #include #include -#include +#include #include #include #include @@ -50,7 +50,7 @@ CLANG_DIAG_OFF(uninitialized) #include //#include #include -#include +#include #include #include #include @@ -58,19 +58,19 @@ CLANG_DIAG_OFF(uninitialized) #include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #include -#include -#include -#include +#include +#include +#include #include // QtCore on Qt4, QtConcurrent on Qt5 -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/SequenceFileDialog.h b/Gui/SequenceFileDialog.h index eecdc6437..e9a2f92f9 100644 --- a/Gui/SequenceFileDialog.h +++ b/Gui/SequenceFileDialog.h @@ -37,19 +37,19 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include // for Q_OS_* +#include // for Q_OS_* #include #include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include +#include +#include +#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/SerializableWindow.cpp b/Gui/SerializableWindow.cpp index e4d60a121..9a8bf2dd2 100644 --- a/Gui/SerializableWindow.cpp +++ b/Gui/SerializableWindow.cpp @@ -27,7 +27,7 @@ #include -#include +#include NATRON_NAMESPACE_ENTER diff --git a/Gui/SpinBox.cpp b/Gui/SpinBox.cpp index 64de42c30..df81b71a7 100644 --- a/Gui/SpinBox.cpp +++ b/Gui/SpinBox.cpp @@ -32,13 +32,13 @@ GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include -#include +#include +#include #include // in QtGui on Qt4, in QtWidgets on Qt5 #include -#include +#include #include #include diff --git a/Gui/SplashScreen.h b/Gui/SplashScreen.h index 75f2c25ae..ad8753f8b 100644 --- a/Gui/SplashScreen.h +++ b/Gui/SplashScreen.h @@ -32,7 +32,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/Splitter.h b/Gui/Splitter.h index 4d9114305..a68efb59c 100644 --- a/Gui/Splitter.h +++ b/Gui/Splitter.h @@ -33,7 +33,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/TabWidget.cpp b/Gui/TabWidget.cpp index 9ab7d999e..182ea6971 100644 --- a/Gui/TabWidget.cpp +++ b/Gui/TabWidget.cpp @@ -29,23 +29,23 @@ #include // stringstream CLANG_DIAG_OFF(deprecated) -#include +#include #include #include #include -#include -#include -#include -#include -#include +#include +#include +#include +#include +#include #include -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include -#include +#include +#include #include #include CLANG_DIAG_ON(deprecated) diff --git a/Gui/TabWidget.h b/Gui/TabWidget.h index b285c39b7..96b30e84c 100644 --- a/Gui/TabWidget.h +++ b/Gui/TabWidget.h @@ -35,7 +35,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/TableModelView.h b/Gui/TableModelView.h index d81040e3b..d3657f72b 100644 --- a/Gui/TableModelView.h +++ b/Gui/TableModelView.h @@ -33,13 +33,13 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) GCC_ONLY_DIAG_OFF(class-memaccess) -#include +#include GCC_ONLY_DIAG_ON(class-memaccess) #include #include #include -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/TextRenderer.cpp b/Gui/TextRenderer.cpp index e24922a9c..013d6bc9c 100644 --- a/Gui/TextRenderer.cpp +++ b/Gui/TextRenderer.cpp @@ -29,10 +29,10 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include -#include -#include +#include +#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/TimeLineGui.cpp b/Gui/TimeLineGui.cpp index 585466e7a..0a077ea85 100644 --- a/Gui/TimeLineGui.cpp +++ b/Gui/TimeLineGui.cpp @@ -29,14 +29,14 @@ #include #include -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON -#include -#include -#include +#include +#include +#include #include "Global/GlobalDefines.h" diff --git a/Gui/TimeLineGui.h b/Gui/TimeLineGui.h index 43dbbcd23..db13f5ff7 100644 --- a/Gui/TimeLineGui.h +++ b/Gui/TimeLineGui.h @@ -33,9 +33,9 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include "Global/GLIncludes.h" //! -#include -#include +#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ToolButton.cpp b/Gui/ToolButton.cpp index 1b1ed4622..657e3da84 100644 --- a/Gui/ToolButton.cpp +++ b/Gui/ToolButton.cpp @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) #include -#include +#include CLANG_DIAG_ON(deprecated) #include "Gui/GuiAppInstance.h" diff --git a/Gui/ToolButton.h b/Gui/ToolButton.h index f9ec12782..1c5cd15e8 100644 --- a/Gui/ToolButton.h +++ b/Gui/ToolButton.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include #include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/TrackerPanel.cpp b/Gui/TrackerPanel.cpp index dd0c32be2..65422e76f 100644 --- a/Gui/TrackerPanel.cpp +++ b/Gui/TrackerPanel.cpp @@ -36,7 +36,7 @@ #include #include #include -#include +#include #include "Engine/Settings.h" diff --git a/Gui/VerticalColorBar.h b/Gui/VerticalColorBar.h index ba8dabaec..e28d4dbcf 100644 --- a/Gui/VerticalColorBar.h +++ b/Gui/VerticalColorBar.h @@ -30,11 +30,11 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include -#include +#include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ViewerGL.cpp b/Gui/ViewerGL.cpp index 98ed44f43..eeb97bf44 100644 --- a/Gui/ViewerGL.cpp +++ b/Gui/ViewerGL.cpp @@ -34,16 +34,16 @@ #include "Global/GLIncludes.h" //! -#include -#include // qApp +#include +#include +#include // qApp #include #include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] -#include -#include +#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include #include diff --git a/Gui/ViewerGL.h b/Gui/ViewerGL.h index 7da7b4161..631fe88bf 100644 --- a/Gui/ViewerGL.h +++ b/Gui/ViewerGL.h @@ -34,7 +34,7 @@ #include "Global/GLIncludes.h" //! +#include #include diff --git a/Gui/ViewerGLPrivate.h b/Gui/ViewerGLPrivate.h index 5348df658..c3d66782d 100644 --- a/Gui/ViewerGLPrivate.h +++ b/Gui/ViewerGLPrivate.h @@ -30,8 +30,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ViewerTab.cpp b/Gui/ViewerTab.cpp index 0292f8ef9..92853dcf5 100644 --- a/Gui/ViewerTab.cpp +++ b/Gui/ViewerTab.cpp @@ -29,8 +29,8 @@ #include #include -#include -#include +#include +#include #include #include diff --git a/Gui/ViewerTab.h b/Gui/ViewerTab.h index d6480031d..c94f7f3c8 100644 --- a/Gui/ViewerTab.h +++ b/Gui/ViewerTab.h @@ -38,7 +38,7 @@ #include "Gui/PanelWidget.h" #include "Gui/GuiFwd.h" -#include +#include NATRON_NAMESPACE_ENTER diff --git a/Gui/ViewerTab10.cpp b/Gui/ViewerTab10.cpp index b4e8e1b8b..86e6857a5 100644 --- a/Gui/ViewerTab10.cpp +++ b/Gui/ViewerTab10.cpp @@ -28,13 +28,13 @@ #include #include -#include +#include #include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] -#include -#include +#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include "Engine/Node.h" diff --git a/Gui/ViewerTab20.cpp b/Gui/ViewerTab20.cpp index ef4159efc..3e48665c5 100644 --- a/Gui/ViewerTab20.cpp +++ b/Gui/ViewerTab20.cpp @@ -31,11 +31,11 @@ #include "Global/GLIncludes.h" //! +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_OFF // /opt/local/include/QtGui/qmime.h:119:10: warning: private field 'type' is not used [-Wunused-private-field] -#include +#include GCC_DIAG_UNUSED_PRIVATE_FIELD_ON #include "Engine/Node.h" diff --git a/Gui/ViewerTab30.cpp b/Gui/ViewerTab30.cpp index 330d49506..f0aa5bc79 100644 --- a/Gui/ViewerTab30.cpp +++ b/Gui/ViewerTab30.cpp @@ -31,7 +31,7 @@ #include #include // stringstream -#include +#include #include #include diff --git a/Gui/ViewerTab40.cpp b/Gui/ViewerTab40.cpp index a74139d29..76529f87b 100644 --- a/Gui/ViewerTab40.cpp +++ b/Gui/ViewerTab40.cpp @@ -29,7 +29,7 @@ #include #include -#include +#include #include #include diff --git a/Gui/ViewerTabPrivate.cpp b/Gui/ViewerTabPrivate.cpp index 10e9e3570..a99997976 100644 --- a/Gui/ViewerTabPrivate.cpp +++ b/Gui/ViewerTabPrivate.cpp @@ -28,7 +28,7 @@ #include #include -#include +#include #include "Engine/EffectInstance.h" #include "Engine/Node.h" diff --git a/Gui/ViewerTabPrivate.h b/Gui/ViewerTabPrivate.h index a2b9a994e..c2a0df662 100644 --- a/Gui/ViewerTabPrivate.h +++ b/Gui/ViewerTabPrivate.h @@ -33,8 +33,8 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include -#include +#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ViewerToolButton.cpp b/Gui/ViewerToolButton.cpp index da6984ef8..ed4c32a63 100644 --- a/Gui/ViewerToolButton.cpp +++ b/Gui/ViewerToolButton.cpp @@ -29,7 +29,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) #include #include -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Gui/ZoomContext.h b/Gui/ZoomContext.h index 60e4bc65a..98dff2c3d 100644 --- a/Gui/ZoomContext.h +++ b/Gui/ZoomContext.h @@ -30,7 +30,7 @@ CLANG_DIAG_OFF(deprecated) CLANG_DIAG_OFF(uninitialized) -#include +#include CLANG_DIAG_ON(deprecated) CLANG_DIAG_ON(uninitialized) diff --git a/Renderer/NatronRenderer_main.cpp b/Renderer/NatronRenderer_main.cpp index 385adf75d..59112444b 100644 --- a/Renderer/NatronRenderer_main.cpp +++ b/Renderer/NatronRenderer_main.cpp @@ -23,7 +23,7 @@ #include // ***** END PYTHON BLOCK ***** -#include // for Q_OS_* +#include // for Q_OS_* #if defined(Q_OS_UNIX) #include // for getrlimit on linux #include // for getrlimit @@ -36,7 +36,7 @@ #include // exit #include -#include +#include #ifdef DEBUG #include "Global/FloatingPointExceptions.h" diff --git a/Tests/BaseTest.cpp b/Tests/BaseTest.cpp index 76a9f333e..2e9d207c3 100644 --- a/Tests/BaseTest.cpp +++ b/Tests/BaseTest.cpp @@ -29,8 +29,8 @@ #include "BaseTest.h" -#include -#include +#include +#include // ofxhPropertySuite.h:565:37: warning: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare] // clang-format off diff --git a/Tests/BaseTest.h b/Tests/BaseTest.h index b57d3e138..06e6a0818 100644 --- a/Tests/BaseTest.h +++ b/Tests/BaseTest.h @@ -38,7 +38,7 @@ #include CLANG_DIAG_OFF(deprecated) -#include +#include CLANG_DIAG_ON(deprecated) #include "Engine/EngineFwd.h" diff --git a/Tests/Curve_Test.cpp b/Tests/Curve_Test.cpp index c71413d5a..8408b6611 100644 --- a/Tests/Curve_Test.cpp +++ b/Tests/Curve_Test.cpp @@ -27,8 +27,8 @@ #include -#include -#include +#include +#include #include "Engine/Curve.h" diff --git a/Tests/KnobFile_Test.cpp b/Tests/KnobFile_Test.cpp index 2a41d9e4f..1f134687a 100644 --- a/Tests/KnobFile_Test.cpp +++ b/Tests/KnobFile_Test.cpp @@ -27,8 +27,8 @@ #include -#include -#include +#include +#include #include From 4d6a9002cae0373d150871427f23a88809d3a881 Mon Sep 17 00:00:00 2001 From: Martin Rodriguez Reboredo Date: Mon, 16 Dec 2024 18:54:55 -0300 Subject: [PATCH 2/4] Enum Shiboken fix --- Engine/AppInstance.h | 16 ++-- Engine/AppManager.h | 18 ++--- Engine/Knob.h | 140 +++++++++++++++++------------------ Engine/KnobTypes.h | 30 ++++---- Engine/MergingEnum.h | 8 +- Engine/Plugin.h | 12 +-- Engine/PyNode.h | 6 +- Engine/PyParameter.h | 20 ++--- Engine/PyRoto.h | 4 +- Engine/typesystem_engine.xml | 4 +- Global/Enums.h | 4 +- Global/Macros.h | 2 - Gui/GuiAppInstance.h | 12 +-- Gui/GuiApplicationManager.h | 8 +- Gui/PyGlobalGui.h | 4 +- Gui/PyGuiApp.h | 12 +-- Gui/PythonPanels.h | 4 +- 17 files changed, 151 insertions(+), 153 deletions(-) diff --git a/Engine/AppInstance.h b/Engine/AppInstance.h index 8978b5946..ab3561194 100644 --- a/Engine/AppInstance.h +++ b/Engine/AppInstance.h @@ -193,22 +193,22 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON virtual void warningDialog(const std::string & title, const std::string & message, bool* stopAsking, bool useHtml) const; virtual void informationDialog(const std::string & title, const std::string & message, bool useHtml) const; virtual void informationDialog(const std::string & title, const std::string & message, bool* stopAsking, bool useHtml) const; - virtual NATRON_ENUM::StandardButtonEnum questionDialog(const std::string & title, + virtual Natron::StandardButtonEnum questionDialog(const std::string & title, const std::string & message, bool useHtml, - NATRON_ENUM::StandardButtons buttons = - NATRON_ENUM::StandardButtons(NATRON_ENUM::eStandardButtonYes | NATRON_ENUM::eStandardButtonNo), - NATRON_ENUM::StandardButtonEnum defaultButton = NATRON_ENUM::eStandardButtonNoButton) const WARN_UNUSED_RETURN; + Natron::StandardButtons buttons = + Natron::StandardButtons(Natron::StandardButtonEnum::eStandardButtonYes | Natron::StandardButtonEnum::eStandardButtonNo), + Natron::StandardButtonEnum defaultButton = Natron::StandardButtonEnum::eStandardButtonNoButton) const WARN_UNUSED_RETURN; /** * @brief Asks a question to the user and returns the reply. * @param stopAsking Set to true if the user do not want Natron to ask the question again. **/ - virtual NATRON_ENUM::StandardButtonEnum questionDialog(const std::string & /*title*/, + virtual Natron::StandardButtonEnum questionDialog(const std::string & /*title*/, const std::string & /*message*/, bool /*useHtml*/, - NATRON_ENUM::StandardButtons /*buttons*/, - NATRON_ENUM::StandardButtonEnum /*defaultButton*/, + Natron::StandardButtons /*buttons*/, + Natron::StandardButtonEnum /*defaultButton*/, bool* /*stopAsking*/) { return eStandardButtonYes; @@ -281,7 +281,7 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON { } - NATRON_ENUM::ViewerColorSpaceEnum getDefaultColorSpaceForBitDepth(NATRON_ENUM::ImageBitDepthEnum bitdepth) const; + Natron::ViewerColorSpaceEnum getDefaultColorSpaceForBitDepth(Natron::ImageBitDepthEnum bitdepth) const; double getProjectFrameRate() const; diff --git a/Engine/AppManager.h b/Engine/AppManager.h index 5a7989137..9b56ff0ec 100644 --- a/Engine/AppManager.h +++ b/Engine/AppManager.h @@ -494,7 +494,7 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON void setOFXHostHandle(void* handle); OFX::Host::ImageEffect::Descriptor* getPluginContextAndDescribe(OFX::Host::ImageEffect::ImageEffectPlugin* plugin, - NATRON_ENUM::ContextEnum* ctx); + Natron::ContextEnum* ctx); AppTLS* getAppTLS() const; const OfxHost* getOFXHost() const; GPUContextPool* getGPUContextPool() const; @@ -567,7 +567,7 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON bool isTextureFloatSupported() const; - bool hasOpenGLForRequirements(NATRON_ENUM::OpenGLRequirementsTypeEnum type, QString* missingOpenGLError = 0) const; + bool hasOpenGLForRequirements(Natron::OpenGLRequirementsTypeEnum type, QString* missingOpenGLError = 0) const; virtual void updateAboutWindowLibrariesVersion() {} @@ -736,14 +736,14 @@ void warningDialog(const std::string & title, const std::string & message, bool* void informationDialog(const std::string & title, const std::string & message, bool useHtml = false); void informationDialog(const std::string & title, const std::string & message, bool* stopAsking, bool useHtml = false); -NATRON_ENUM::StandardButtonEnum questionDialog(const std::string & title, const std::string & message, bool useHtml, - NATRON_ENUM::StandardButtons buttons = - NATRON_ENUM::StandardButtons(NATRON_ENUM::eStandardButtonYes | NATRON_ENUM::eStandardButtonNo), - NATRON_ENUM::StandardButtonEnum defaultButton = NATRON_ENUM::eStandardButtonNoButton); +Natron::StandardButtonEnum questionDialog(const std::string & title, const std::string & message, bool useHtml, + Natron::StandardButtons buttons = + Natron::StandardButtons(Natron::StandardButtonEnum::eStandardButtonYes | Natron::StandardButtonEnum::eStandardButtonNo), + Natron::StandardButtonEnum defaultButton = Natron::StandardButtonEnum::eStandardButtonNoButton); -NATRON_ENUM::StandardButtonEnum questionDialog(const std::string & title, const std::string & message, bool useHtml, - NATRON_ENUM::StandardButtons buttons, - NATRON_ENUM::StandardButtonEnum defaultButton, +Natron::StandardButtonEnum questionDialog(const std::string & title, const std::string & message, bool useHtml, + Natron::StandardButtons buttons, + Natron::StandardButtonEnum defaultButton, bool* stopAsking); } // namespace Dialogs diff --git a/Engine/Knob.h b/Engine/Knob.h index ff21c348a..1e3cd0e26 100644 --- a/Engine/Knob.h +++ b/Engine/Knob.h @@ -153,7 +153,7 @@ class KnobSignalSlotHandler Q_EMIT setValueWithUndoStack(v, view, dim); } - void s_appendParamEditChange(NATRON_ENUM::ValueChangedReasonEnum reason, + void s_appendParamEditChange(Natron::ValueChangedReasonEnum reason, Variant v, ViewSpec view, int dim, @@ -182,7 +182,7 @@ class KnobSignalSlotHandler Q_EMIT keyFrameMoved(view, dimension, oldTime, newTime); } - void s_redrawGuiCurve(NATRON_ENUM::CurveChangeReason reason, + void s_redrawGuiCurve(Natron::CurveChangeReason reason, ViewSpec view, int dimension) { @@ -354,7 +354,7 @@ public Q_SLOTS: struct KnobChange { KnobIPtr knob; - NATRON_ENUM::ValueChangedReasonEnum reason, originalReason; + Natron::ValueChangedReasonEnum reason, originalReason; bool originatedFromMainThread; bool refreshGui; double time; @@ -485,7 +485,7 @@ class KnobI * evaluate the new value (cause a render). * @returns true if the knobChanged handler was called once for this knob **/ - virtual bool evaluateValueChange(int dimension, double time, ViewSpec view, NATRON_ENUM::ValueChangedReasonEnum reason) = 0; + virtual bool evaluateValueChange(int dimension, double time, ViewSpec view, Natron::ValueChangedReasonEnum reason) = 0; /** * @brief Copies all the values, animations and extra data the other knob might have @@ -561,28 +561,28 @@ class KnobI /** * @brief Removes all the keyframes in the given dimension. **/ - virtual void removeAnimationWithReason(ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason) = 0; + virtual void removeAnimationWithReason(ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason) = 0; public: /** * @brief Removes the keyframe at the given time and dimension if it matches any. **/ - virtual void deleteValueAtTime(NATRON_ENUM::CurveChangeReason curveChangeReason, double time, ViewSpec view, int dimension, bool copyCurveValueAtTimeToInternalValue) = 0; - virtual void deleteValuesAtTime(NATRON_ENUM::CurveChangeReason curveChangeReason, const std::list& times, ViewSpec view, int dimension, bool copyCurveValueAtTimeToInternalValue) = 0; + virtual void deleteValueAtTime(Natron::CurveChangeReason curveChangeReason, double time, ViewSpec view, int dimension, bool copyCurveValueAtTimeToInternalValue) = 0; + virtual void deleteValuesAtTime(Natron::CurveChangeReason curveChangeReason, const std::list& times, ViewSpec view, int dimension, bool copyCurveValueAtTimeToInternalValue) = 0; /** * @brief Moves a keyframe by a given delta and emits the signal keyframeMoved **/ - virtual bool moveValueAtTime(NATRON_ENUM::CurveChangeReason reason, double time, ViewSpec view, int dimension, double dt, double dv, KeyFrame* newKey) = 0; - virtual bool moveValuesAtTime(NATRON_ENUM::CurveChangeReason reason, ViewSpec view, int dimension, double dt, double dv, std::vector* keyframes) = 0; + virtual bool moveValueAtTime(Natron::CurveChangeReason reason, double time, ViewSpec view, int dimension, double dt, double dv, KeyFrame* newKey) = 0; + virtual bool moveValuesAtTime(Natron::CurveChangeReason reason, ViewSpec view, int dimension, double dt, double dv, std::vector* keyframes) = 0; /** * @brief Transforms a keyframe by a given matrix. The matrix must not contain any skew or rotation. **/ - virtual bool transformValueAtTime(NATRON_ENUM::CurveChangeReason curveChangeReason, double time, ViewSpec view, int dimension, const Transform::Matrix3x3& matrix, KeyFrame* newKey) = 0; - virtual bool transformValuesAtTime(NATRON_ENUM::CurveChangeReason curveChangeReason, ViewSpec view, int dimension, const Transform::Matrix3x3& matrix, std::vector* keyframes) = 0; + virtual bool transformValueAtTime(Natron::CurveChangeReason curveChangeReason, double time, ViewSpec view, int dimension, const Transform::Matrix3x3& matrix, KeyFrame* newKey) = 0; + virtual bool transformValuesAtTime(Natron::CurveChangeReason curveChangeReason, ViewSpec view, int dimension, const Transform::Matrix3x3& matrix, std::vector* keyframes) = 0; /** * @brief Copies all the animation of *curve* into the animation curve at the given dimension. @@ -592,25 +592,25 @@ class KnobI /** * @brief Changes the interpolation type for the given keyframe **/ - virtual bool setInterpolationAtTime(NATRON_ENUM::CurveChangeReason reason, ViewSpec view, int dimension, double time, NATRON_ENUM::KeyframeTypeEnum interpolation, KeyFrame* newKey) = 0; + virtual bool setInterpolationAtTime(Natron::CurveChangeReason reason, ViewSpec view, int dimension, double time, Natron::KeyframeTypeEnum interpolation, KeyFrame* newKey) = 0; /** * @brief Set the left/right derivatives of the control point at the given time. **/ - virtual bool moveDerivativesAtTime(NATRON_ENUM::CurveChangeReason reason, ViewSpec view, int dimension, double time, double left, double right) = 0; - virtual bool moveDerivativeAtTime(NATRON_ENUM::CurveChangeReason reason, ViewSpec view, int dimension, double time, double derivative, bool isLeft) = 0; + virtual bool moveDerivativesAtTime(Natron::CurveChangeReason reason, ViewSpec view, int dimension, double time, double left, double right) = 0; + virtual bool moveDerivativeAtTime(Natron::CurveChangeReason reason, ViewSpec view, int dimension, double time, double derivative, bool isLeft) = 0; /** * @brief Removes animation before the given time and dimension. If the reason is different than eValueChangedReasonUserEdited * a signal will be emitted **/ - virtual void deleteAnimationBeforeTime(double time, ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason) = 0; + virtual void deleteAnimationBeforeTime(double time, ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason) = 0; /** * @brief Removes animation before the given time and dimension. If the reason is different than eValueChangedReasonUserEdited * a signal will be emitted **/ - virtual void deleteAnimationAfterTime(double time, ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason) = 0; + virtual void deleteAnimationAfterTime(double time, ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason) = 0; /** * @brief Calls removeAnimation with a reason of eValueChangedReasonNatronInternalEdited. @@ -689,7 +689,7 @@ class KnobI protected: - virtual void refreshListenersAfterValueChange(ViewSpec view, NATRON_ENUM::ValueChangedReasonEnum reason, int dimension) = 0; + virtual void refreshListenersAfterValueChange(ViewSpec view, Natron::ValueChangedReasonEnum reason, int dimension) = 0; public: @@ -710,7 +710,7 @@ class KnobI **/ virtual bool onKeyFrameSet(double time, ViewSpec view, int dimension) = 0; virtual bool onKeyFrameSet(double time, ViewSpec view, const KeyFrame& key, int dimension) = 0; - virtual bool setKeyFrame(const KeyFrame& key, ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason) = 0; + virtual bool setKeyFrame(const KeyFrame& key, ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason) = 0; /** * @brief Called when the current time of the timeline changes. @@ -1163,14 +1163,14 @@ class KnobI * at the same dimension for the knob 'other'. * In case of success, this function returns true, otherwise false. **/ - virtual bool slaveToInternal(int dimension, const KnobIPtr & other, int otherDimension, NATRON_ENUM::ValueChangedReasonEnum reason, + virtual bool slaveToInternal(int dimension, const KnobIPtr & other, int otherDimension, Natron::ValueChangedReasonEnum reason, bool ignoreMasterPersistence) = 0; /** * @brief Unslaves a previously slaved dimension. The implementation should assert that * the dimension was really slaved. **/ - virtual void unSlaveInternal(int dimension, NATRON_ENUM::ValueChangedReasonEnum reason, bool copyState) = 0; + virtual void unSlaveInternal(int dimension, Natron::ValueChangedReasonEnum reason, bool copyState) = 0; public: @@ -1279,7 +1279,7 @@ class KnobI /** * @brief Get the current animation level. **/ - virtual NATRON_ENUM::AnimationLevelEnum getAnimationLevel(int dimension) const = 0; + virtual Natron::AnimationLevelEnum getAnimationLevel(int dimension) const = 0; /** * @brief Restores the default value @@ -1389,15 +1389,15 @@ class KnobHelper virtual void blockListenersNotification() OVERRIDE FINAL; virtual void unblockListenersNotification() OVERRIDE FINAL; virtual bool isListenersNotificationBlocked() const OVERRIDE FINAL WARN_UNUSED_RETURN; - virtual bool evaluateValueChange(int dimension, double time, ViewSpec view, NATRON_ENUM::ValueChangedReasonEnum reason) OVERRIDE FINAL; + virtual bool evaluateValueChange(int dimension, double time, ViewSpec view, Natron::ValueChangedReasonEnum reason) OVERRIDE FINAL; protected: // Returns true if the knobChanged handler was called bool evaluateValueChangeInternal(int dimension, double time, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason, - NATRON_ENUM::ValueChangedReasonEnum originalReason); + Natron::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum originalReason); virtual void onInternalValueChanged(int /*dimension*/, double /*time*/, @@ -1426,15 +1426,15 @@ class KnobHelper private: - virtual void removeAnimationWithReason(ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason) OVERRIDE FINAL; - virtual void deleteValueAtTime(NATRON_ENUM::CurveChangeReason curveChangeReason, double time, ViewSpec view, int dimension,bool copyCurveValueAtTimeToInternalValue) OVERRIDE FINAL; - virtual void deleteValuesAtTime(NATRON_ENUM::CurveChangeReason curveChangeReason, const std::list& times, ViewSpec view, int dimension, bool copyCurveValueAtTimeToInternalValue) OVERRIDE FINAL; + virtual void removeAnimationWithReason(ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason) OVERRIDE FINAL; + virtual void deleteValueAtTime(Natron::CurveChangeReason curveChangeReason, double time, ViewSpec view, int dimension,bool copyCurveValueAtTimeToInternalValue) OVERRIDE FINAL; + virtual void deleteValuesAtTime(Natron::CurveChangeReason curveChangeReason, const std::list& times, ViewSpec view, int dimension, bool copyCurveValueAtTimeToInternalValue) OVERRIDE FINAL; public: virtual void onKeyFrameRemoved(double time, ViewSpec view, int dimension, bool copyCurveValueAtTimeToInternalValue) OVERRIDE FINAL; - virtual bool moveValueAtTime(NATRON_ENUM::CurveChangeReason reason, double time, ViewSpec view, int dimension, double dt, double dv, KeyFrame* newKey) OVERRIDE FINAL; - virtual bool moveValuesAtTime(NATRON_ENUM::CurveChangeReason reason, ViewSpec view, int dimension, double dt, double dv, std::vector* keyframes) OVERRIDE FINAL; + virtual bool moveValueAtTime(Natron::CurveChangeReason reason, double time, ViewSpec view, int dimension, double dt, double dv, KeyFrame* newKey) OVERRIDE FINAL; + virtual bool moveValuesAtTime(Natron::CurveChangeReason reason, ViewSpec view, int dimension, double dt, double dv, std::vector* keyframes) OVERRIDE FINAL; private: bool moveValueAtTimeInternal(bool useGuiCurve, double time, ViewSpec view, int dimension, double dt, double dv, KeyFrame* newKey); @@ -1442,8 +1442,8 @@ class KnobHelper public: - virtual bool transformValueAtTime(NATRON_ENUM::CurveChangeReason curveChangeReason, double time, ViewSpec view, int dimension, const Transform::Matrix3x3& matrix, KeyFrame* newKey) OVERRIDE FINAL; - virtual bool transformValuesAtTime(NATRON_ENUM::CurveChangeReason curveChangeReason, ViewSpec view, int dimension, const Transform::Matrix3x3& matrix, std::vector* keyframes) OVERRIDE FINAL; + virtual bool transformValueAtTime(Natron::CurveChangeReason curveChangeReason, double time, ViewSpec view, int dimension, const Transform::Matrix3x3& matrix, KeyFrame* newKey) OVERRIDE FINAL; + virtual bool transformValuesAtTime(Natron::CurveChangeReason curveChangeReason, ViewSpec view, int dimension, const Transform::Matrix3x3& matrix, std::vector* keyframes) OVERRIDE FINAL; private: bool transformValueAtTimeInternal(bool useGuiCurve, double time, ViewSpec view, int dimension, const Transform::Matrix3x3& matrix, KeyFrame* newKey); @@ -1451,15 +1451,15 @@ class KnobHelper public: virtual void cloneCurve(ViewSpec view, int dimension, const Curve& curve) OVERRIDE FINAL; - virtual bool setInterpolationAtTime(NATRON_ENUM::CurveChangeReason reason, ViewSpec view, int dimension, double time, NATRON_ENUM::KeyframeTypeEnum interpolation, KeyFrame* newKey) OVERRIDE FINAL; - virtual bool moveDerivativesAtTime(NATRON_ENUM::CurveChangeReason reason, ViewSpec view, int dimension, double time, double left, double right) OVERRIDE FINAL WARN_UNUSED_RETURN; - virtual bool moveDerivativeAtTime(NATRON_ENUM::CurveChangeReason reason, ViewSpec view, int dimension, double time, double derivative, bool isLeft) OVERRIDE FINAL WARN_UNUSED_RETURN; - virtual void deleteAnimationBeforeTime(double time, ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason) OVERRIDE FINAL; - virtual void deleteAnimationAfterTime(double time, ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason) OVERRIDE FINAL; + virtual bool setInterpolationAtTime(Natron::CurveChangeReason reason, ViewSpec view, int dimension, double time, Natron::KeyframeTypeEnum interpolation, KeyFrame* newKey) OVERRIDE FINAL; + virtual bool moveDerivativesAtTime(Natron::CurveChangeReason reason, ViewSpec view, int dimension, double time, double left, double right) OVERRIDE FINAL WARN_UNUSED_RETURN; + virtual bool moveDerivativeAtTime(Natron::CurveChangeReason reason, ViewSpec view, int dimension, double time, double derivative, bool isLeft) OVERRIDE FINAL WARN_UNUSED_RETURN; + virtual void deleteAnimationBeforeTime(double time, ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason) OVERRIDE FINAL; + virtual void deleteAnimationAfterTime(double time, ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason) OVERRIDE FINAL; private: - void deleteAnimationConditional(double time, ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason, bool before); + void deleteAnimationConditional(double time, ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason, bool before); public: @@ -1494,7 +1494,7 @@ class KnobHelper template static T pyObjectToType(PyObject* o); - virtual void refreshListenersAfterValueChange(ViewSpec view, NATRON_ENUM::ValueChangedReasonEnum reason, int dimension) OVERRIDE FINAL; + virtual void refreshListenersAfterValueChange(ViewSpec view, Natron::ValueChangedReasonEnum reason, int dimension) OVERRIDE FINAL; public: @@ -1612,7 +1612,7 @@ class KnobHelper private: - virtual bool slaveToInternal(int dimension, const KnobIPtr & other, int otherDimension, NATRON_ENUM::ValueChangedReasonEnum reason + virtual bool slaveToInternal(int dimension, const KnobIPtr & other, int otherDimension, Natron::ValueChangedReasonEnum reason , bool ignoreMasterPersistence) OVERRIDE FINAL WARN_UNUSED_RETURN; protected: @@ -1638,7 +1638,7 @@ class KnobHelper virtual std::pair getMaster(int dimension) const OVERRIDE FINAL WARN_UNUSED_RETURN; virtual bool isSlave(int dimension) const OVERRIDE FINAL WARN_UNUSED_RETURN; - virtual NATRON_ENUM::AnimationLevelEnum getAnimationLevel(int dimension) const OVERRIDE FINAL WARN_UNUSED_RETURN; + virtual Natron::AnimationLevelEnum getAnimationLevel(int dimension) const OVERRIDE FINAL WARN_UNUSED_RETURN; virtual bool isTypeCompatible(const KnobIPtr & other) const OVERRIDE WARN_UNUSED_RETURN = 0; /** @@ -1748,19 +1748,19 @@ class KnobHelper { } - void cloneGuiCurvesIfNeeded(std::map& modifiedDimensions); + void cloneGuiCurvesIfNeeded(std::map& modifiedDimensions); - void cloneInternalCurvesIfNeeded(std::map& modifiedDimensions); + void cloneInternalCurvesIfNeeded(std::map& modifiedDimensions); void setInternalCurveHasChanged(ViewSpec view, int dimension, bool changed); - void guiCurveCloneInternalCurve(NATRON_ENUM::CurveChangeReason curveChangeReason, ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason); + void guiCurveCloneInternalCurve(Natron::CurveChangeReason curveChangeReason, ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason); virtual std::shared_ptr getGuiCurve(ViewSpec view, int dimension, bool byPassMaster = false) const OVERRIDE FINAL; void setGuiCurveHasChanged(ViewSpec view, int dimension, bool changed); bool hasGuiCurveChanged(ViewSpec view, int dimension) const; - void clearExpressionsResultsIfNeeded(std::map& modifiedDimensions); + void clearExpressionsResultsIfNeeded(std::map& modifiedDimensions); std::shared_ptr _signalSlotHandler; @@ -1842,7 +1842,7 @@ class Knob virtual void unSlaveInternal(int dimension, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, bool copyState) OVERRIDE FINAL; public: @@ -1857,11 +1857,11 @@ class Knob const T & v, ViewSpec view, int dimension, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, KeyFrame* newKey, bool hasChanged = false); //!< set to true if any previous dimension of the same knob have changed - virtual bool setKeyFrame(const KeyFrame& key, ViewSpec view, int dimension, NATRON_ENUM::ValueChangedReasonEnum reason) OVERRIDE FINAL; + virtual bool setKeyFrame(const KeyFrame& key, ViewSpec view, int dimension, Natron::ValueChangedReasonEnum reason) OVERRIDE FINAL; /** * @brief Set the value of the knob in the given dimension with the given reason. @@ -1871,7 +1871,7 @@ class Knob ValueChangedReturnCodeEnum setValue(const T & v, ViewSpec view, int dimension, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, KeyFrame* newKey, bool hasChanged = false); //!< set to true if any previous dimension of the same knob have changed @@ -1889,25 +1889,25 @@ class Knob void setValues(const T& value0, const T& value1, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason); + Natron::ValueChangedReasonEnum reason); void setValues(const T& value0, const T& value1, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, int dimensionOffset); void setValues(const T& value0, const T& value1, const T& value2, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason); + Natron::ValueChangedReasonEnum reason); void setValues(const T& value0, const T& value1, const T& value2, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, int dimensionOffset); @@ -1916,7 +1916,7 @@ class Knob const T& value2, const T& value3, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason); + Natron::ValueChangedReasonEnum reason); /** * @brief Calls setValue @@ -1928,7 +1928,7 @@ class Knob ValueChangedReturnCodeEnum onValueChanged(const T & v, ViewSpec view, int dimension, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, KeyFrame* newKey); /** @@ -1959,13 +1959,13 @@ class Knob const T& value0, const T& value1, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason); + Natron::ValueChangedReasonEnum reason); void setValuesAtTime(double time, const T& value0, const T& value1, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, int dimensionOffset); void setValuesAtTime(double time, @@ -1973,14 +1973,14 @@ class Knob const T& value1, const T& value2, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason); + Natron::ValueChangedReasonEnum reason); void setValuesAtTime(double time, const T& value0, const T& value1, const T& value2, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, int dimensionOffset); void setValuesAtTime(double time, @@ -1989,7 +1989,7 @@ class Knob const T& value2, const T& value3, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum reason); + Natron::ValueChangedReasonEnum reason); /** * @brief Unlike getValueAtTime this function doesn't interpolate the values. @@ -2180,7 +2180,7 @@ class Knob const T& value, const KeyFrame& key, bool useKey, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, bool valueChangesBlocked); virtual bool isSetValueAtTime() const { return false; } @@ -2196,7 +2196,7 @@ class Knob bool useKey() const; - NATRON_ENUM::ValueChangedReasonEnum reason() const; + Natron::ValueChangedReasonEnum reason() const; bool valueChangesBlocked() const; @@ -2215,7 +2215,7 @@ class Knob int dimension, const T& value, const KeyFrame& key, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, bool valueChangesBlocked) : QueuedSetValue(view, dimension, value, key, true, reason, valueChangesBlocked) , _time(time) @@ -2544,8 +2544,8 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON bool refreshGui, double time, ViewSpec view, - NATRON_ENUM::ValueChangedReasonEnum originalReason, - NATRON_ENUM::ValueChangedReasonEnum reason); + Natron::ValueChangedReasonEnum originalReason, + Natron::ValueChangedReasonEnum reason); bool isSetValueCurrentlyPossible() const; @@ -2610,14 +2610,14 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON * You should NEVER CALL THIS YOURSELF as it would break the bracketing system. * You can overload this to prepare yourself to a lot of value changes. **/ - void beginKnobsValuesChanged_public(NATRON_ENUM::ValueChangedReasonEnum reason); + void beginKnobsValuesChanged_public(Natron::ValueChangedReasonEnum reason); /** * @brief The virtual portion of notifyProjectEndKnobsValuesChanged(). This is called by the project * You should NEVER CALL THIS YOURSELF as it would break the bracketing system. * You can overload this to finish a serie of value changes, thus limiting the amount of changes to do. **/ - void endKnobsValuesChanged_public(NATRON_ENUM::ValueChangedReasonEnum reason); + void endKnobsValuesChanged_public(Natron::ValueChangedReasonEnum reason); /** @@ -2626,7 +2626,7 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON * You can overload this to do things when a value is changed. Bear in mind that you can compress * the change by using the begin/end[ValueChanges] to optimize the changes. **/ - virtual bool onKnobValueChanged_public(KnobI* k, NATRON_ENUM::ValueChangedReasonEnum reason, double time, ViewSpec view, + virtual bool onKnobValueChanged_public(KnobI* k, Natron::ValueChangedReasonEnum reason, double time, ViewSpec view, bool originatedFromMainThread); @@ -2708,7 +2708,7 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON * You should NEVER CALL THIS YOURSELF as it would break the bracketing system. * You can overload this to prepare yourself to a lot of value changes. **/ - virtual void beginKnobsValuesChanged(NATRON_ENUM::ValueChangedReasonEnum reason) + virtual void beginKnobsValuesChanged(Natron::ValueChangedReasonEnum reason) { Q_UNUSED(reason); } @@ -2718,7 +2718,7 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON * You should NEVER CALL THIS YOURSELF as it would break the bracketing system. * You can overload this to finish a serie of value changes, thus limiting the amount of changes to do. **/ - virtual void endKnobsValuesChanged(NATRON_ENUM::ValueChangedReasonEnum reason) + virtual void endKnobsValuesChanged(Natron::ValueChangedReasonEnum reason) { Q_UNUSED(reason); } @@ -2730,7 +2730,7 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON * the change by using the begin/end[ValueChanges] to optimize the changes. **/ virtual bool onKnobValueChanged(KnobI* /*k*/, - NATRON_ENUM::ValueChangedReasonEnum /*reason*/, + Natron::ValueChangedReasonEnum /*reason*/, double /*time*/, ViewSpec /*view*/, bool /*originatedFromMainThread*/) diff --git a/Engine/KnobTypes.h b/Engine/KnobTypes.h index a60689fbc..3c307954c 100644 --- a/Engine/KnobTypes.h +++ b/Engine/KnobTypes.h @@ -248,13 +248,13 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON static const std::string & typeNameStatic(); - NATRON_ENUM::ValueIsNormalizedEnum getValueIsNormalized(int dimension) const + Natron::ValueIsNormalizedEnum getValueIsNormalized(int dimension) const { return _valueIsNormalized[dimension]; } void setValueIsNormalized(int dimension, - NATRON_ENUM::ValueIsNormalizedEnum state) + Natron::ValueIsNormalizedEnum state) { _valueIsNormalized[dimension] = state; } @@ -372,7 +372,7 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON /// - kOfxParamDoubleTypeNormalisedYAbsolute - normalised absolute position on the Y axis (1D only) /// - kOfxParamDoubleTypeNormalisedXY - normalised to the project's X and Y size (2D only), /// - kOfxParamDoubleTypeNormalisedXYAbsolute - normalised to the projects X and Y size, and is an absolute position on the image plane, - std::vector _valueIsNormalized; + std::vector _valueIsNormalized; ///For double params respecting the kOfxParamCoordinatesNormalised ///This tells us that only the default value is stored normalized. @@ -1009,33 +1009,33 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON std::pair getParametricRange() const WARN_UNUSED_RETURN; CurvePtr getParametricCurve(int dimension) const; CurvePtr getDefaultParametricCurve(int dimension) const; - NATRON_ENUM::StatusEnum addControlPoint(NATRON_ENUM::ValueChangedReasonEnum reason, int dimension, double key, double value, NATRON_ENUM::KeyframeTypeEnum interpolation = NATRON_ENUM::eKeyframeTypeSmooth) WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum addControlPoint(NATRON_ENUM::ValueChangedReasonEnum reason, int dimension, double key, double value, double leftDerivative, double rightDerivative, NATRON_ENUM::KeyframeTypeEnum interpolation = NATRON_ENUM::eKeyframeTypeSmooth) WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum getValue(int dimension, double parametricPosition, double *returnValue) const WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum getNControlPoints(int dimension, int *returnValue) const WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum getNthControlPoint(int dimension, + Natron::StatusEnum addControlPoint(Natron::ValueChangedReasonEnum reason, int dimension, double key, double value, Natron::KeyframeTypeEnum interpolation = Natron::KeyframeTypeEnum::eKeyframeTypeSmooth) WARN_UNUSED_RETURN; + Natron::StatusEnum addControlPoint(Natron::ValueChangedReasonEnum reason, int dimension, double key, double value, double leftDerivative, double rightDerivative, Natron::KeyframeTypeEnum interpolation = Natron::KeyframeTypeEnum::eKeyframeTypeSmooth) WARN_UNUSED_RETURN; + Natron::StatusEnum getValue(int dimension, double parametricPosition, double *returnValue) const WARN_UNUSED_RETURN; + Natron::StatusEnum getNControlPoints(int dimension, int *returnValue) const WARN_UNUSED_RETURN; + Natron::StatusEnum getNthControlPoint(int dimension, int nthCtl, double *key, double *value) const WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum getNthControlPoint(int dimension, + Natron::StatusEnum getNthControlPoint(int dimension, int nthCtl, double *key, double *value, double *leftDerivative, double *rightDerivative) const WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum setNthControlPointInterpolation(NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::StatusEnum setNthControlPointInterpolation(Natron::ValueChangedReasonEnum reason, int dimension, int nThCtl, - NATRON_ENUM::KeyframeTypeEnum interpolation) WARN_UNUSED_RETURN; + Natron::KeyframeTypeEnum interpolation) WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum setNthControlPoint(NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::StatusEnum setNthControlPoint(Natron::ValueChangedReasonEnum reason, int dimension, int nthCtl, double key, double value) WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum setNthControlPoint(NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::StatusEnum setNthControlPoint(Natron::ValueChangedReasonEnum reason, int dimension, int nthCtl, double key, @@ -1044,8 +1044,8 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON double rightDerivative) WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum deleteControlPoint(NATRON_ENUM::ValueChangedReasonEnum reason, int dimension, int nthCtl) WARN_UNUSED_RETURN; - NATRON_ENUM::StatusEnum deleteAllControlPoints(NATRON_ENUM::ValueChangedReasonEnum reason, int dimension) WARN_UNUSED_RETURN; + Natron::StatusEnum deleteControlPoint(Natron::ValueChangedReasonEnum reason, int dimension, int nthCtl) WARN_UNUSED_RETURN; + Natron::StatusEnum deleteAllControlPoints(Natron::ValueChangedReasonEnum reason, int dimension) WARN_UNUSED_RETURN; static const std::string & typeNameStatic() WARN_UNUSED_RETURN; void saveParametricCurves(std::list* curves) const; diff --git a/Engine/MergingEnum.h b/Engine/MergingEnum.h index 1084a658a..b6cf303cf 100644 --- a/Engine/MergingEnum.h +++ b/Engine/MergingEnum.h @@ -43,7 +43,7 @@ namespace Merge { * Keep this in sync with the Merge node's operators otherwise everything will fall apart. **/ inline std::string -getOperatorString(NATRON_ENUM::MergingFunctionEnum operation) +getOperatorString(Natron::MergingFunctionEnum operation) { switch (operation) { case eMergeATop: @@ -169,7 +169,7 @@ getOperatorString(NATRON_ENUM::MergingFunctionEnum operation) } // getOperationString inline std::string -getOperatorHelpString(NATRON_ENUM::MergingFunctionEnum operation) +getOperatorHelpString(Natron::MergingFunctionEnum operation) { switch (operation) { case eMergeATop: @@ -295,8 +295,8 @@ getOperatorHelpString(NATRON_ENUM::MergingFunctionEnum operation) } // getOperationHelpString inline -NATRON_ENUM::PixmapEnum -getOperatorPixmap(NATRON_ENUM::MergingFunctionEnum operation) +Natron::PixmapEnum +getOperatorPixmap(Natron::MergingFunctionEnum operation) { switch (operation) { case eMergeATop: diff --git a/Engine/Plugin.h b/Engine/Plugin.h index 1873bc5a9..c48b13643 100644 --- a/Engine/Plugin.h +++ b/Engine/Plugin.h @@ -173,7 +173,7 @@ class Plugin int _majorVersion; int _minorVersion; - NATRON_ENUM::ContextEnum _ofxContext; + Natron::ContextEnum _ofxContext; mutable bool _hasShortcutSet; //< to speed up the keypress event of Nodegraph, this is used to find out quickly whether it has a shortcut or not. bool _isReader, _isWriter; @@ -195,7 +195,7 @@ class Plugin bool _multiThreadingEnabled; bool _openglActivated; - NATRON_ENUM::PluginOpenGLRenderSupport _openglRenderSupport; + Natron::PluginOpenGLRenderSupport _openglRenderSupport; public: @@ -357,9 +357,9 @@ class Plugin void setOfxPlugin(OFX::Host::ImageEffect::ImageEffectPlugin* p); OFX::Host::ImageEffect::ImageEffectPlugin* getOfxPlugin() const; - OFX::Host::ImageEffect::Descriptor* getOfxDesc(NATRON_ENUM::ContextEnum* ctx) const; + OFX::Host::ImageEffect::Descriptor* getOfxDesc(Natron::ContextEnum* ctx) const; - void setOfxDesc(OFX::Host::ImageEffect::Descriptor* desc, NATRON_ENUM::ContextEnum ctx); + void setOfxDesc(OFX::Host::ImageEffect::Descriptor* desc, Natron::ContextEnum ctx); bool isRenderScaleEnabled() const; void setRenderScaleEnabled(bool b); @@ -373,8 +373,8 @@ class Plugin bool isOpenGLEnabled() const; void setOpenGLEnabled(bool b); - void setOpenGLRenderSupport(NATRON_ENUM::PluginOpenGLRenderSupport support); - NATRON_ENUM::PluginOpenGLRenderSupport getPluginOpenGLRenderSupport() const; + void setOpenGLRenderSupport(Natron::PluginOpenGLRenderSupport support); + Natron::PluginOpenGLRenderSupport getPluginOpenGLRenderSupport() const; }; struct Plugin_compare_version diff --git a/Engine/PyNode.h b/Engine/PyNode.h index 805587b2b..0d0b244e9 100644 --- a/Engine/PyNode.h +++ b/Engine/PyNode.h @@ -200,7 +200,7 @@ class UserParamHolder void refreshUserParamsGUI(); virtual bool onKnobValueChanged(KnobI* k, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, double time, ViewSpec view, bool originatedFromMainThread) @@ -383,8 +383,8 @@ class Effect double getPixelAspectRatio() const; - NATRON_ENUM::ImageBitDepthEnum getBitDepth() const; - NATRON_ENUM::ImagePremultiplicationEnum getPremult() const; + Natron::ImageBitDepthEnum getBitDepth() const; + Natron::ImagePremultiplicationEnum getPremult() const; void setPagesOrder(const QStringList& pages); }; diff --git a/Engine/PyParameter.h b/Engine/PyParameter.h index ca1e240c1..78aee842f 100644 --- a/Engine/PyParameter.h +++ b/Engine/PyParameter.h @@ -264,7 +264,7 @@ class AnimatedParam bool setExpression(const QString& expr, bool hasRetVariable, int dimension = 0); QString getExpression(int dimension, bool* hasRetVariable) const; - bool setInterpolationAtTime(double time, NATRON_ENUM::KeyframeTypeEnum interpolation, int dimension = 0); + bool setInterpolationAtTime(double time, Natron::KeyframeTypeEnum interpolation, int dimension = 0); }; /** @@ -1169,31 +1169,31 @@ class ParametricParam void getCurveColor(int dimension, ColorTuple& ret) const; - NATRON_ENUM::StatusEnum addControlPoint(int dimension, double key, double value, NATRON_ENUM::KeyframeTypeEnum interpolation = NATRON_ENUM::eKeyframeTypeSmooth); - NATRON_ENUM::StatusEnum addControlPoint(int dimension, double key, double value, double leftDerivative, double rightDerivative, NATRON_ENUM::KeyframeTypeEnum interpolation = NATRON_ENUM::eKeyframeTypeSmooth); + Natron::StatusEnum addControlPoint(int dimension, double key, double value, Natron::KeyframeTypeEnum interpolation = Natron::KeyframeTypeEnum::eKeyframeTypeSmooth); + Natron::StatusEnum addControlPoint(int dimension, double key, double value, double leftDerivative, double rightDerivative, Natron::KeyframeTypeEnum interpolation = Natron::KeyframeTypeEnum::eKeyframeTypeSmooth); double getValue(int dimension, double parametricPosition) const; int getNControlPoints(int dimension) const; - // NATRON_ENUM:: is necessary for shiboken - NATRON_ENUM::StatusEnum getNthControlPoint(int dimension, + // Natron:: is necessary for shiboken + Natron::StatusEnum getNthControlPoint(int dimension, int nthCtl, double *key, double *value, double *leftDerivative, double *rightDerivative) const; - NATRON_ENUM::StatusEnum setNthControlPoint(int dimension, + Natron::StatusEnum setNthControlPoint(int dimension, int nthCtl, double key, double value, double leftDerivative, double rightDerivative); - NATRON_ENUM::StatusEnum setNthControlPointInterpolation(int dimension, + Natron::StatusEnum setNthControlPointInterpolation(int dimension, int nThCtl, - NATRON_ENUM::KeyframeTypeEnum interpolation); - NATRON_ENUM::StatusEnum deleteControlPoint(int dimension, int nthCtl); - NATRON_ENUM::StatusEnum deleteAllControlPoints(int dimension); + Natron::KeyframeTypeEnum interpolation); + Natron::StatusEnum deleteControlPoint(int dimension, int nthCtl); + Natron::StatusEnum deleteAllControlPoints(int dimension); void setDefaultCurvesFromCurrentCurves(); }; diff --git a/Engine/PyRoto.h b/Engine/PyRoto.h index 7725846fd..38bb985e8 100644 --- a/Engine/PyRoto.h +++ b/Engine/PyRoto.h @@ -153,8 +153,8 @@ class BezierCurve ColorTuple getColor(double time); void setColor(double time, double r, double g, double b); - void setCompositingOperator(NATRON_ENUM::MergingFunctionEnum op); - NATRON_ENUM::MergingFunctionEnum getCompositingOperator() const; + void setCompositingOperator(Natron::MergingFunctionEnum op); + Natron::MergingFunctionEnum getCompositingOperator() const; BooleanParam* getActivatedParam() const; DoubleParam* getOpacityParam() const; DoubleParam* getFeatherDistanceParam() const; diff --git a/Engine/typesystem_engine.xml b/Engine/typesystem_engine.xml index e01264e84..670e6a85b 100644 --- a/Engine/typesystem_engine.xml +++ b/Engine/typesystem_engine.xml @@ -210,7 +210,7 @@ - + @@ -1502,7 +1502,7 @@ double key,value,left,right; %RETURN_TYPE %0 = %CPPSELF.%FUNCTION_NAME(%1, %2,&key,&value, &left, &right); %PYARG_0 = PyTuple_New(5); - PyTuple_SET_ITEM(%PYARG_0, 0, %CONVERTTOPYTHON[NATRON_ENUM::StatusEnum](%0)); + PyTuple_SET_ITEM(%PYARG_0, 0, %CONVERTTOPYTHON[Natron::StatusEnum](%0)); PyTuple_SET_ITEM(%PYARG_0, 1, %CONVERTTOPYTHON[double](key)); PyTuple_SET_ITEM(%PYARG_0, 2, %CONVERTTOPYTHON[double](value)); PyTuple_SET_ITEM(%PYARG_0, 3, %CONVERTTOPYTHON[double](left)); diff --git a/Global/Enums.h b/Global/Enums.h index 11440d611..37f75d66c 100644 --- a/Global/Enums.h +++ b/Global/Enums.h @@ -31,7 +31,7 @@ NATRON_NAMESPACE_ENTER #ifdef SBK_RUN // shiboken doesn't generate SbkNatronEngine_StandardButtonEnum_as_number unless it is put in a class or namespace NATRON_NAMESPACE_EXIT -namespace NATRON_ENUM { +namespace Natron { #endif enum ScaleTypeEnum @@ -693,7 +693,7 @@ NATRON_NAMESPACE_ENTER NATRON_NAMESPACE_EXIT -Q_DECLARE_METATYPE(NATRON_ENUM::StandardButtons) +Q_DECLARE_METATYPE(Natron::StandardButtons) #endif // NATRON_GLOBAL_ENUMS_H diff --git a/Global/Macros.h b/Global/Macros.h index 4462278f5..ef8652608 100644 --- a/Global/Macros.h +++ b/Global/Macros.h @@ -52,7 +52,6 @@ namespace Python { } // run shiboken without the Natron namespace, and add NATRON_NAMESPACE_USING to each cpp afterwards #define NATRON_NAMESPACE -#undef NATRON_ENUM #define NATRON_NAMESPACE_ENTER #define NATRON_NAMESPACE_EXIT #define NATRON_PYTHON_NAMESPACE @@ -62,7 +61,6 @@ namespace Python { } #else // !SBK_RUN #define NATRON_NAMESPACE Natron -#define NATRON_ENUM NATRON_NAMESPACE // Macros to use in each file to enter and exit the right name spaces. #define NATRON_NAMESPACE_ENTER namespace NATRON_NAMESPACE { #define NATRON_NAMESPACE_EXIT } diff --git a/Gui/GuiAppInstance.h b/Gui/GuiAppInstance.h index bbb125b82..e542fb665 100644 --- a/Gui/GuiAppInstance.h +++ b/Gui/GuiAppInstance.h @@ -120,16 +120,16 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON virtual void warningDialog(const std::string & title, const std::string & message, bool* stopAsking, bool useHtml) const OVERRIDE FINAL; virtual void informationDialog(const std::string & title, const std::string & message, bool useHtml) const OVERRIDE FINAL; virtual void informationDialog(const std::string & title, const std::string & message, bool* stopAsking, bool useHtml) const OVERRIDE FINAL; - virtual NATRON_ENUM::StandardButtonEnum questionDialog(const std::string & title, + virtual Natron::StandardButtonEnum questionDialog(const std::string & title, const std::string & message, bool useHtml, - NATRON_ENUM::StandardButtons buttons = NATRON_ENUM::StandardButtons(NATRON_ENUM::eStandardButtonYes | NATRON_ENUM::eStandardButtonNo), - NATRON_ENUM::StandardButtonEnum defaultButton = NATRON_ENUM::eStandardButtonNoButton) const OVERRIDE FINAL WARN_UNUSED_RETURN; - virtual NATRON_ENUM::StandardButtonEnum questionDialog(const std::string & title, + Natron::StandardButtons buttons = Natron::StandardButtons(Natron::StandardButtonEnum::eStandardButtonYes | Natron::StandardButtonEnum::eStandardButtonNo), + Natron::StandardButtonEnum defaultButton = Natron::StandardButtonEnum::eStandardButtonNoButton) const OVERRIDE FINAL WARN_UNUSED_RETURN; + virtual Natron::StandardButtonEnum questionDialog(const std::string & title, const std::string & message, bool useHtml, - NATRON_ENUM::StandardButtons buttons, - NATRON_ENUM::StandardButtonEnum defaultButton, + Natron::StandardButtons buttons, + Natron::StandardButtonEnum defaultButton, bool* stopAsking) OVERRIDE FINAL WARN_UNUSED_RETURN; virtual void loadProjectGui(bool isAutosave, boost::archive::xml_iarchive & archive) const OVERRIDE FINAL; virtual void saveProjectGui(boost::archive::xml_oarchive & archive) OVERRIDE FINAL; diff --git a/Gui/GuiApplicationManager.h b/Gui/GuiApplicationManager.h index 00d9ad3d6..64d9d100f 100644 --- a/Gui/GuiApplicationManager.h +++ b/Gui/GuiApplicationManager.h @@ -100,15 +100,15 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON return false; } - void getIcon(NATRON_ENUM::PixmapEnum e, QPixmap* pix) const; - void getIcon(NATRON_ENUM::PixmapEnum e, int size, QPixmap* pix) const; + void getIcon(Natron::PixmapEnum e, QPixmap* pix) const; + void getIcon(Natron::PixmapEnum e, int size, QPixmap* pix) const; - void setKnobClipBoard(NATRON_ENUM::KnobClipBoardType type, + void setKnobClipBoard(Natron::KnobClipBoardType type, const KnobIPtr& serialization, int dimension); - void getKnobClipBoard(NATRON_ENUM::KnobClipBoardType *type, + void getKnobClipBoard(Natron::KnobClipBoardType *type, KnobIPtr* serialization, int *dimension) const; diff --git a/Gui/PyGlobalGui.h b/Gui/PyGlobalGui.h index f14836dac..f96fc2a1e 100644 --- a/Gui/PyGlobalGui.h +++ b/Gui/PyGlobalGui.h @@ -59,7 +59,7 @@ class PyGuiApplication { } - QPixmap getIcon(NATRON_ENUM::PixmapEnum val) const + QPixmap getIcon(Natron::PixmapEnum val) const { QPixmap ret; @@ -101,7 +101,7 @@ class PyGuiApplication Dialogs::errorDialog( title.toStdString(), message.toStdString() ); } - NATRON_ENUM::StandardButtonEnum questionDialog(const QString& title, + Natron::StandardButtonEnum questionDialog(const QString& title, const QString& message) { return Dialogs::questionDialog(title.toStdString(), message.toStdString(), false); diff --git a/Gui/PyGuiApp.h b/Gui/PyGuiApp.h index b045e1bbf..57c785723 100644 --- a/Gui/PyGuiApp.h +++ b/Gui/PyGuiApp.h @@ -74,13 +74,13 @@ class PyViewer void getFrameRange(int* firstFrame, int* lastFrame) const; - void setPlaybackMode(NATRON_ENUM::PlaybackModeEnum mode); + void setPlaybackMode(Natron::PlaybackModeEnum mode); - NATRON_ENUM::PlaybackModeEnum getPlaybackMode() const; + Natron::PlaybackModeEnum getPlaybackMode() const; - NATRON_ENUM::ViewerCompositingOperatorEnum getCompositingOperator() const; + Natron::ViewerCompositingOperatorEnum getCompositingOperator() const; - void setCompositingOperator(NATRON_ENUM::ViewerCompositingOperatorEnum op); + void setCompositingOperator(Natron::ViewerCompositingOperatorEnum op); int getAInput() const; @@ -90,9 +90,9 @@ class PyViewer void setBInput(int index); - void setChannels(NATRON_ENUM::DisplayChannelsEnum channels); + void setChannels(Natron::DisplayChannelsEnum channels); - NATRON_ENUM::DisplayChannelsEnum getChannels() const; + Natron::DisplayChannelsEnum getChannels() const; void setProxyModeEnabled(bool enabled); diff --git a/Gui/PythonPanels.h b/Gui/PythonPanels.h index c5f83ed52..b4acbe6f4 100644 --- a/Gui/PythonPanels.h +++ b/Gui/PythonPanels.h @@ -74,7 +74,7 @@ GCC_DIAG_SUGGEST_OVERRIDE_ON virtual void initializeKnobs() OVERRIDE FINAL {} virtual bool onKnobValueChanged(KnobI* k, - NATRON_ENUM::ValueChangedReasonEnum reason, + Natron::ValueChangedReasonEnum reason, double time, ViewSpec view, bool originatedFromMainThread) OVERRIDE FINAL; @@ -91,7 +91,7 @@ class PyModalDialog public: PyModalDialog( Gui* gui, - NATRON_ENUM::StandardButtons defaultButtons = NATRON_ENUM::StandardButtons(NATRON_ENUM::eStandardButtonOk | NATRON_ENUM::eStandardButtonCancel) ); + Natron::StandardButtons defaultButtons = Natron::StandardButtons(Natron::StandardButtonEnum::eStandardButtonOk | Natron::StandardButtonEnum::eStandardButtonCancel) ); virtual ~PyModalDialog(); From 24fc3769af523b7e8297f2fd03adbf9e92478355 Mon Sep 17 00:00:00 2001 From: Martin Rodriguez Reboredo Date: Tue, 29 Nov 2022 15:47:34 -0300 Subject: [PATCH 3/4] Qt6 support in CMake --- CMakeLists.txt | 56 ++++++++++++++++++++++++--------- Engine/CMakeLists.txt | 11 ++++--- Gui/CMakeLists.txt | 19 ++++++----- Renderer/CMakeLists.txt | 6 ++-- Tests/CMakeLists.txt | 2 +- libs/qhttpserver/CMakeLists.txt | 2 +- 6 files changed, 64 insertions(+), 32 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4d118b007..5a1be4f4d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -28,6 +28,9 @@ project(Natron set(CMAKE_CXX_STANDARD 17) +include(GNUInstallDirs) + +option(NATRON_QT6 "use Qt6" OFF) option(NATRON_SYSTEM_LIBS "use system versions of dependencies instead of bundled ones" OFF) option(NATRON_BUILD_TESTS "build the Natron test suite" ON) @@ -55,28 +58,53 @@ if(WIN32) set(Python3_FIND_REGISTRY NEVER) endif() find_package(Python3 COMPONENTS Interpreter Development) -find_package(Qt5 5.15 CONFIG REQUIRED COMPONENTS Core Gui Network Widgets Concurrent) if(IS_DEBUG_BUILD AND WIN32) # Explicitly setting SHIBOKEN_PYTHON_LIBRARIES variable to avoid PYTHON_DEBUG_LIBRARY-NOTFOUND # link errors on Windows debug builds. set(SHIBOKEN_PYTHON_LIBRARIES ${Python3_LIBRARIES}) endif() -find_package(Shiboken2 5.15 CONFIG REQUIRED COMPONENTS libshiboken2 shiboken2) -if(IS_DEBUG_BUILD AND WIN32) - # Remove NDEBUG from Shiboken2 INTERFACE_COMPILE_DEFINITIONS so it is not inherited in debug builds. - get_property(ShibokenInterfaceDefs TARGET Shiboken2::libshiboken PROPERTY INTERFACE_COMPILE_DEFINITIONS) - list(REMOVE_ITEM ShibokenInterfaceDefs NDEBUG) - set_property(TARGET Shiboken2::libshiboken PROPERTY INTERFACE_COMPILE_DEFINITIONS ShibokenInterfaceDefs) +set(QT_COMPONENTS Core Gui Network Widgets Concurrent) +if(NATRON_QT6) + list(APPEND QT_COMPONENTS OpenGLWidgets) + find_package(Qt6 6.3 CONFIG REQUIRED COMPONENTS ${QT_COMPONENTS}) + find_package(Shiboken6 6.3 CONFIG REQUIRED COMPONENTS libshiboken6) + find_package(Shiboken6Tools 6.3 CONFIG REQUIRED COMPONENTS shiboken6) + find_package(PySide6 6.3 CONFIG REQUIRED COMPONENTS pyside6) + set(QT_VERSION_MAJOR 6) + + get_target_property(PYSIDE_INCLUDE_DIRS PySide6::pyside6 INTERFACE_INCLUDE_DIRECTORIES) + set(QTCORE_INCLUDE_DIRS ${Qt6Core_INCLUDE_DIRS}) + set(QTGUI_INCLUDE_DIRS ${Qt6Gui_INCLUDE_DIRS}) + set(QTWIDGETS_INCLUDE_DIRS ${Qt6Widgets_INCLUDE_DIRS}) + + set(SHIBOKEN_EXE Shiboken6::shiboken6) + set(SHIBOKEN_LIB Shiboken6::libshiboken) + set(PYSIDE_LIB PySide6::pyside6) +else() + find_package(Qt5 5.15 CONFIG REQUIRED COMPONENTS ${QT_COMPONENTS}) + find_package(Shiboken2 5.15 CONFIG REQUIRED COMPONENTS libshiboken2 shiboken2) + + find_package(PySide2 5.15 CONFIG REQUIRED COMPONENTS pyside2) + set(QT_VERSION_MAJOR 5) + + get_target_property(PYSIDE_INCLUDE_DIRS PySide2::pyside2 INTERFACE_INCLUDE_DIRECTORIES) + set(QTCORE_INCLUDE_DIRS ${Qt5Core_INCLUDE_DIRS}) + set(QTGUI_INCLUDE_DIRS ${Qt5Gui_INCLUDE_DIRS}) + set(QTWIDGETS_INCLUDE_DIRS ${Qt5Widgets_INCLUDE_DIRS}) + + set(SHIBOKEN_EXE Shiboken2::shiboken2) + set(SHIBOKEN_LIB Shiboken2::libshiboken) + set(PYSIDE_LIB PySide2::pyside2) endif() -find_package(PySide2 5.15 CONFIG REQUIRED COMPONENTS pyside2) -set(QT_VERSION_MAJOR 5) -get_target_property(PYSIDE_INCLUDE_DIRS PySide2::pyside2 INTERFACE_INCLUDE_DIRECTORIES) -set(QTCORE_INCLUDE_DIRS ${Qt5Core_INCLUDE_DIRS}) -set(QTGUI_INCLUDE_DIRS ${Qt5Gui_INCLUDE_DIRS}) -set(QTWIDGETS_INCLUDE_DIRS ${Qt5Widgets_INCLUDE_DIRS}) +if(IS_DEBUG_BUILD AND WIN32) + # Remove NDEBUG from Shiboken INTERFACE_COMPILE_DEFINITIONS so it is not inherited in debug builds. + get_property(SHIBOKEN_DEFS TARGET ${SHIBOKEN_LIB} PROPERTY INTERFACE_COMPILE_DEFINITIONS) + list(REMOVE_ITEM SHIBOKEN_DEFS NDEBUG) + set_property(TARGET ${SHIBOKEN_LIB} PROPERTY INTERFACE_COMPILE_DEFINITIONS SHIBOKEN_DEFS) +endif() #Since in Natron and OpenFX all strings are supposed UTF-8 and that the constructor #for QString(const char*) assumes ASCII strings, we may run into troubles @@ -119,8 +147,6 @@ elseif(WIN32) endif() endif() -include(GNUInstallDirs) - set(CMAKE_AUTOMOC ON) set(CMAKE_AUTORCC ON) diff --git a/Engine/CMakeLists.txt b/Engine/CMakeLists.txt index 971ab42f6..256dcfd1d 100644 --- a/Engine/CMakeLists.txt +++ b/Engine/CMakeLists.txt @@ -75,11 +75,11 @@ target_link_libraries(NatronEngine Boost::serialization PkgConfig::Cairo PRIVATE - Shiboken2::libshiboken - PySide2::pyside2 - Qt5::Core - Qt5::Concurrent - Qt5::Network + ${SHIBOKEN_LIB} + ${PYSIDE_LIB} + Qt::Core + Qt::Concurrent + Qt::Network Python3::Module ${XDG_LIBS} ceres @@ -109,5 +109,6 @@ target_compile_definitions(NatronEngine PRIVATE NATRON_CUSTOM_BUILD_USER_TOKEN="${BUILD_USER_NAME}" NATRON_BUILD_NUMBER=0 + QT_NO_KEYWORDS ${XDG_DEFS} ) diff --git a/Gui/CMakeLists.txt b/Gui/CMakeLists.txt index 301e0c8e6..08b3ceeb0 100644 --- a/Gui/CMakeLists.txt +++ b/Gui/CMakeLists.txt @@ -31,6 +31,10 @@ list(TRANSFORM PYGUI_INCLUDE_DIRS PREPEND "-I" OUTPUT_VARIABLE PYGUI_INCS) set(PYGUI_HEADER PySide2_Gui_Python.h) set(POST_SHIBOKEN ../tools/utils/runPostShiboken2.sh) +if(NATRON_QT6) + set(QT_OPENGLWIDGETS Qt::OpenGLWidgets) +endif() + set(shiboken_args "-std=c++17" "--enable-parent-ctor-heuristic" "--use-isnull-as-nb_nonzero" "--avoid-protected-hack" "--enable-pyside-extensions" @@ -60,13 +64,14 @@ list(APPEND NatronGui_SOURCES add_library(NatronGui STATIC ${NatronGui_HEADERS} ${NatronGui_SOURCES}) target_link_libraries(NatronGui PUBLIC - Shiboken2::libshiboken - PySide2::pyside2 - Qt5::Core - Qt5::Concurrent - Qt5::Network - Qt5::Gui - Qt5::Widgets + ${SHIBOKEN_LIB} + ${PYSIDE_LIB} + Qt::Core + Qt::Concurrent + Qt::Network + Qt::Gui + Qt::Widgets + ${QT_OPENGLWIDGETS} Python3::Module NatronEngine PRIVATE diff --git a/Renderer/CMakeLists.txt b/Renderer/CMakeLists.txt index 740db68b3..b54e1f254 100644 --- a/Renderer/CMakeLists.txt +++ b/Renderer/CMakeLists.txt @@ -25,9 +25,9 @@ add_executable(NatronRenderer ${NatronRenderer_SOURCES}) target_link_libraries(NatronRenderer PRIVATE NatronEngine - Qt5::Core - Qt5::Concurrent - Qt5::Network + Qt::Core + Qt::Concurrent + Qt::Network Python3::Python ) target_include_directories(NatronRenderer diff --git a/Tests/CMakeLists.txt b/Tests/CMakeLists.txt index 333e6038d..f40cbcb9d 100644 --- a/Tests/CMakeLists.txt +++ b/Tests/CMakeLists.txt @@ -36,7 +36,7 @@ add_executable(Tests ${Tests_HEADERS} ${Tests_SOURCES}) target_link_libraries(Tests PRIVATE NatronEngine - Qt5::Core + Qt::Core Python3::Python openMVG ) diff --git a/libs/qhttpserver/CMakeLists.txt b/libs/qhttpserver/CMakeLists.txt index 7a3b3a2e9..bac81b989 100644 --- a/libs/qhttpserver/CMakeLists.txt +++ b/libs/qhttpserver/CMakeLists.txt @@ -29,6 +29,6 @@ set(qhttpserver_HEADERS file(GLOB qhttpserver_SOURCES src/*.cpp) set(qhttpserver_SOURCES ${qhttpserver_SOURCES} http-parser/http_parser.c) add_library(qhttpserver STATIC ${qhttpserver_HEADERS} ${qhttpserver_SOURCES}) -target_link_libraries(qhttpserver PRIVATE Qt5::Core Qt5::Network) +target_link_libraries(qhttpserver PRIVATE Qt::Core Qt::Network) target_include_directories(qhttpserver PRIVATE http-parser) set_target_properties(qhttpserver PROPERTIES POSITION_INDEPENDENT_CODE ON) From 8f54ccdeea220d160452489f9270cead8a3edf0d Mon Sep 17 00:00:00 2001 From: Martin Rodriguez Reboredo Date: Thu, 18 Apr 2024 15:57:45 -0300 Subject: [PATCH 4/4] Adapt Shiboken generation for Qt6 --- CMakeLists.txt | 2 + Engine/CMakeLists.txt | 9 ++- Engine/PySide6_Engine_Python.h | 39 +++++++++++ Engine/Pyside_Engine_Python.h | 2 +- Engine/typesystem_engine.xml | 4 ++ Gui/CMakeLists.txt | 9 ++- Gui/PySide6_Gui_Python.h | 39 +++++++++++ Gui/Pyside_Gui_Python.h | 2 +- Gui/typesystem_natronGui.xml | 4 ++ tools/utils/runPostShiboken.bat | 31 --------- tools/utils/runPostShiboken.sh | 108 ------------------------------- tools/utils/runPostShiboken2.sh | 111 -------------------------------- tools/utils/sourceCleanup.py | 50 ++++++++++++++ 13 files changed, 148 insertions(+), 262 deletions(-) create mode 100644 Engine/PySide6_Engine_Python.h create mode 100644 Gui/PySide6_Gui_Python.h delete mode 100644 tools/utils/runPostShiboken.bat delete mode 100755 tools/utils/runPostShiboken.sh delete mode 100755 tools/utils/runPostShiboken2.sh create mode 100644 tools/utils/sourceCleanup.py diff --git a/CMakeLists.txt b/CMakeLists.txt index 5a1be4f4d..199062bb9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -73,6 +73,7 @@ if(NATRON_QT6) find_package(Shiboken6Tools 6.3 CONFIG REQUIRED COMPONENTS shiboken6) find_package(PySide6 6.3 CONFIG REQUIRED COMPONENTS pyside6) set(QT_VERSION_MAJOR 6) + set(PYSIDE_VERSION_MAJOR 6) get_target_property(PYSIDE_INCLUDE_DIRS PySide6::pyside6 INTERFACE_INCLUDE_DIRECTORIES) set(QTCORE_INCLUDE_DIRS ${Qt6Core_INCLUDE_DIRS}) @@ -88,6 +89,7 @@ else() find_package(PySide2 5.15 CONFIG REQUIRED COMPONENTS pyside2) set(QT_VERSION_MAJOR 5) + set(PYSIDE_VERSION_MAJOR 2) get_target_property(PYSIDE_INCLUDE_DIRS PySide2::pyside2 INTERFACE_INCLUDE_DIRECTORIES) set(QTCORE_INCLUDE_DIRS ${Qt5Core_INCLUDE_DIRS}) diff --git a/Engine/CMakeLists.txt b/Engine/CMakeLists.txt index 256dcfd1d..576f7b200 100644 --- a/Engine/CMakeLists.txt +++ b/Engine/CMakeLists.txt @@ -28,8 +28,7 @@ set(PYENGINE_OUT ${CMAKE_CURRENT_BINARY_DIR}/Qt${QT_VERSION_MAJOR}) set(PYENGINE_INCLUDE_DIRS ${PYSIDE_INCLUDE_DIRS} ${PYSIDE_INCLUDE_DIRS}/QtCore) list(APPEND PYENGINE_INCLUDE_DIRS ${QTCORE_INCLUDE_DIRS} ${Python3_INCLUDE_DIRS} ${Boost_INCLUDE_DIRS}) list(TRANSFORM PYENGINE_INCLUDE_DIRS PREPEND "-I" OUTPUT_VARIABLE PYENGINE_INCS) -set(PYENGINE_HEADER PySide2_Engine_Python.h) -set(POST_SHIBOKEN ../tools/utils/runPostShiboken2.sh) +set(PYENGINE_HEADER PySide${PYSIDE_VERSION_MAJOR}_Engine_Python.h) set(shiboken_args "-std=c++17" "--enable-parent-ctor-heuristic" "--use-isnull-as-nb_nonzero" @@ -43,9 +42,9 @@ execute_process(COMMAND ${Python3_EXECUTABLE} ../tools/utils/sourceList.py types OUTPUT_VARIABLE PyEngine_SOURCES) set_property(SOURCE ${PyEngine_SOURCES} PROPERTY SKIP_AUTOGEN ON) add_custom_command(OUTPUT ${PyEngine_SOURCES} - COMMAND Shiboken2::shiboken2 ${shiboken_args} - COMMAND bash ${POST_SHIBOKEN} ${PYENGINE_OUT}/NatronEngine natronengine - DEPENDS ${PYENGINE_HEADER} ${NatronEngine_HEADERS} ${POST_SHIBOKEN} typesystem_engine.xml + COMMAND $ ${shiboken_args} + COMMAND ${Python3_EXECUTABLE} ../tools/utils/sourceCleanup.py typesystem_engine.xml ${PYENGINE_OUT} + DEPENDS ${SHIBOKEN_EXE} ${PYENGINE_HEADER} ${NatronEngine_HEADERS} ../tools/utils/sourceCleanup.py typesystem_engine.xml WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}) if(UNIX AND NOT APPLE) diff --git a/Engine/PySide6_Engine_Python.h b/Engine/PySide6_Engine_Python.h new file mode 100644 index 000000000..279d28109 --- /dev/null +++ b/Engine/PySide6_Engine_Python.h @@ -0,0 +1,39 @@ +/* ***** BEGIN LICENSE BLOCK ***** + * This file is part of Natron , + * (C) 2018-2024 The Natron developers + * (C) 2013-2018 INRIA and Alexandre Gauthier-Foichat + * + * Natron is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * Natron is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with Natron. If not, see + * ***** END LICENSE BLOCK ***** */ + + +#ifndef PYSIDE6_ENGINE_PYTHON_H +#define PYSIDE6_ENGINE_PYTHON_H + +// Defined for shiboken6-specific tweaks +#define SBK6_RUN + +#ifndef BOOST_SERIALIZATION_VERSION_HPP +#define BOOST_SERIALIZATION_VERSION_HPP +#define BOOST_CLASS_VERSION(T, N) +#endif /* BOOST_SERIALIZATION_VERSION_HPP */ + +#ifndef BOOST_SERIALIZATION_SPLIT_MEMBER_HPP +#define BOOST_SERIALIZATION_SPLIT_MEMBER_HPP +#define BOOST_SERIALIZATION_SPLIT_MEMBER() +#endif /* BOOST_SERIALIZATION_SPLIT_MEMBER_HPP */ + +#include "Pyside_Engine_Python.h" + +#endif // PYSIDE6_ENGINE_PYTHON_H diff --git a/Engine/Pyside_Engine_Python.h b/Engine/Pyside_Engine_Python.h index 333422aeb..ea7031956 100644 --- a/Engine/Pyside_Engine_Python.h +++ b/Engine/Pyside_Engine_Python.h @@ -39,7 +39,7 @@ #ifdef SBK2_RUN #include #else -#include +#include #endif #include //Global diff --git a/Engine/typesystem_engine.xml b/Engine/typesystem_engine.xml index 670e6a85b..7aa3a1ea6 100644 --- a/Engine/typesystem_engine.xml +++ b/Engine/typesystem_engine.xml @@ -1856,6 +1856,10 @@ + + NATRON_NAMESPACE_USING NATRON_PYTHON_NAMESPACE_USING + + diff --git a/Gui/CMakeLists.txt b/Gui/CMakeLists.txt index 08b3ceeb0..b3e06b0f1 100644 --- a/Gui/CMakeLists.txt +++ b/Gui/CMakeLists.txt @@ -28,8 +28,7 @@ list(APPEND PYGUI_INCLUDE_DIRS ${PYSIDE_INCLUDE_DIRS} ${PYSIDE_INCLUDE_DIRS}/QtC list(APPEND PYGUI_INCLUDE_DIRS ${QTCORE_INCLUDE_DIRS} ${QTGUI_INCLUDE_DIRS} ${QTWIDGETS_INCLUDE_DIRS} ${Python3_INCLUDE_DIRS} ${Boost_INCLUDE_DIRS}) list(TRANSFORM PYGUI_INCLUDE_DIRS PREPEND "-I" OUTPUT_VARIABLE PYGUI_INCS) -set(PYGUI_HEADER PySide2_Gui_Python.h) -set(POST_SHIBOKEN ../tools/utils/runPostShiboken2.sh) +set(PYGUI_HEADER PySide${PYSIDE_VERSION_MAJOR}_Gui_Python.h) if(NATRON_QT6) set(QT_OPENGLWIDGETS Qt::OpenGLWidgets) @@ -47,9 +46,9 @@ execute_process(COMMAND ${Python3_EXECUTABLE} ../tools/utils/sourceList.py types OUTPUT_VARIABLE PyGui_SOURCES) set_property(SOURCE ${PyGui_SOURCES} PROPERTY SKIP_AUTOGEN ON) add_custom_command(OUTPUT ${PyGui_SOURCES} - COMMAND Shiboken2::shiboken2 ${shiboken_args} - COMMAND bash ${POST_SHIBOKEN} ${PYGUI_OUT}/NatronGui natrongui - DEPENDS ${PYGUI_HEADER} ${NatronEngine_HEADERS} ${NatronGui_HEADERS} ${POST_SHIBOKEN} typesystem_natronGui.xml + COMMAND $ ${shiboken_args} + COMMAND ${Python3_EXECUTABLE} ../tools/utils/sourceCleanup.py typesystem_natronGui.xml ${PYGUI_OUT} + DEPENDS ${SHIBOKEN_EXE} ${PYGUI_HEADER} NatronEngine ${NatronGui_HEADERS} ../tools/utils/sourceCleanup.py typesystem_natronGui.xml WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}) if(APPLE) diff --git a/Gui/PySide6_Gui_Python.h b/Gui/PySide6_Gui_Python.h new file mode 100644 index 000000000..ec6965d9c --- /dev/null +++ b/Gui/PySide6_Gui_Python.h @@ -0,0 +1,39 @@ +/* ***** BEGIN LICENSE BLOCK ***** + * This file is part of Natron , + * (C) 2018-2024 The Natron developers + * (C) 2013-2018 INRIA and Alexandre Gauthier-Foichat + * + * Natron is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * Natron is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with Natron. If not, see + * ***** END LICENSE BLOCK ***** */ + + +#ifndef PYSIDE6_GUI_PYTHON_H +#define PYSIDE6_GUI_PYTHON_H + +// Defined for shiboken6-specific tweaks +#define SBK6_RUN + +#ifndef BOOST_SERIALIZATION_VERSION_HPP +#define BOOST_SERIALIZATION_VERSION_HPP +#define BOOST_CLASS_VERSION(T, N) +#endif /* BOOST_SERIALIZATION_VERSION_HPP */ + +#ifndef BOOST_SERIALIZATION_SPLIT_MEMBER_HPP +#define BOOST_SERIALIZATION_SPLIT_MEMBER_HPP +#define BOOST_SERIALIZATION_SPLIT_MEMBER() +#endif /* BOOST_SERIALIZATION_SPLIT_MEMBER_HPP */ + +#include "Pyside_Gui_Python.h" + +#endif // PYSIDE6_GUI_PYTHON_H diff --git a/Gui/Pyside_Gui_Python.h b/Gui/Pyside_Gui_Python.h index e29904ff6..2d0124934 100644 --- a/Gui/Pyside_Gui_Python.h +++ b/Gui/Pyside_Gui_Python.h @@ -34,7 +34,7 @@ #ifdef SBK2_RUN #include #else -#include +#include #endif #include diff --git a/Gui/typesystem_natronGui.xml b/Gui/typesystem_natronGui.xml index c612ff9e8..727c5cb48 100644 --- a/Gui/typesystem_natronGui.xml +++ b/Gui/typesystem_natronGui.xml @@ -211,4 +211,8 @@ + + + NATRON_NAMESPACE_USING NATRON_PYTHON_NAMESPACE_USING + diff --git a/tools/utils/runPostShiboken.bat b/tools/utils/runPostShiboken.bat deleted file mode 100644 index 45edf4351..000000000 --- a/tools/utils/runPostShiboken.bat +++ /dev/null @@ -1,31 +0,0 @@ -:: ***** BEGIN LICENSE BLOCK ***** -:: This file is part of Natron , -:: Copyright (C) 2016 INRIA and Alexandre Gauthier -:: -:: Natron is free software: you can redistribute it and/or modify -:: it under the terms of the GNU General Public License as published by -:: the Free Software Foundation; either version 2 of the License, or -:: (at your option) any later version. -:: -:: Natron is distributed in the hope that it will be useful, -:: but WITHOUT ANY WARRANTY; without even the implied warranty of -:: MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -:: GNU General Public License for more details. -:: -:: You should have received a copy of the GNU General Public License -:: along with Natron. If not, see -:: ***** END LICENSE BLOCK ***** - -:: To be run after shiboken to fix errors - -sed "//d" -i Engine/NatronEngine/*.cpp -sed "//d" -i Gui/NatronGui/*.cpp -sed -e "/SbkPySide_QtCoreTypes;/d" -i Gui/NatronGui/natrongui_module_wrapper.cpp -sed -e "/SbkPySide_QtCoreTypeConverters;/d" -i Gui/NatronGui/natrongui_module_wrapper.cpp -sed -e "/SbkNatronEngineTypes;/d" -i Gui/NatronGui/natrongui_module_wrapper.cpp -sed -e "/SbkNatronEngineTypeConverters;/d" -i Gui/NatronGui/natrongui_module_wrapper.cpp -sed -e "s/cleanTypesAttributes/cleanGuiTypesAttributes/g" -i Gui/NatronGui/natrongui_module_wrapper.cpp - - -rm sed* -rm */sed* diff --git a/tools/utils/runPostShiboken.sh b/tools/utils/runPostShiboken.sh deleted file mode 100755 index e27d7d50f..000000000 --- a/tools/utils/runPostShiboken.sh +++ /dev/null @@ -1,108 +0,0 @@ -#!/bin/bash -# ***** BEGIN LICENSE BLOCK ***** -# This file is part of Natron , -# Copyright (C) 2016 INRIA and Alexandre Gauthier -# -# Natron is free software: you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# Natron is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Natron. If not, see -# ***** END LICENSE BLOCK ***** - -# exit if a command returns an error status -set -e - -if [ "$#" -ne 2 ]; then - echo "usage: " 2>&1 - exit 1 -fi - -wrapper_dir="$1" -wrapper_name=$2 -wrapper_source=${wrapper_name}_module_wrapper.cpp -wrapper_header=${wrapper_name}_python.h - -# To be run after shiboken to fix errors - -sed -e '//d' -i'.bak' "$wrapper_dir"/*.cpp -sed -e '//d' -i'.bak' "$wrapper_dir"/*.cpp -sed -e '/Py_BEGIN_ALLOW_THREADS/d' -i'.bak' "$wrapper_dir"/*.cpp -sed -e '/Py_BEGIN_ALLOW_THREADS/d' -i'.bak' "$wrapper_dir"/*.cpp -sed -e '/Py_END_ALLOW_THREADS/d' -i'.bak' "$wrapper_dir"/*.cpp -sed -e '/Py_END_ALLOW_THREADS/d' -i'.bak' "$wrapper_dir"/*.cpp -if [ "$wrapper_name" = "natrongui" ]; then - $SED -e "/SbkPySide_QtCoreTypes;/d" -i'.bak' "$wrapper_dir/$wrapper_source" - $SED -e "/SbkPySide_QtCoreTypeConverters;/d" -i'.bak' "$wrapper_dir/$wrapper_source" - $SED -e '/SbkNatronEngineTypes;/d' -i'.bak' "$wrapper_dir/$wrapper_source" - $SED -e '/SbkNatronEngineTypeConverters;/d' -i'.bak' "$wrapper_dir/$wrapper_source" - $SED -e 's/cleanTypesAttributes/cleanGuiTypesAttributes/g' -i'.bak' "$wrapper_dir/$wrapper_source" -fi - -# fix warnings -sed -e 's@^#include $@#include "Global/Macros.h"\ -// clang-format off\ -CLANG_DIAG_OFF(mismatched-tags)\ -GCC_DIAG_OFF(unused-parameter)\ -GCC_DIAG_OFF(missing-field-initializers)\ -GCC_DIAG_OFF(missing-declarations)\ -GCC_DIAG_OFF(uninitialized)\ -GCC_DIAG_UNUSED_LOCAL_TYPEDEFS_OFF\ -// clang-format on\ -#include // produces many warnings@' -i'.bak' "$wrapper_dir"/*.cpp - -sed -e 's@// Extra includes@// Extra includes\ -NATRON_NAMESPACE_USING NATRON_PYTHON_NAMESPACE_USING@' -i'.bak' "$wrapper_dir"/*.cpp - -# replace NATRON_NAMESPACE with Natron for enums with flags (e.g. StandardButtonEnum) -sed -e 's@"NatronEngine\.NATRON_NAMESPACE@"NatronEngine.Natron@g' -e 's@, NatronEngine\.NATRON_NAMESPACE@, NatronEngine.Natron@g' -e 's@"NatronGui\.NATRON_NAMESPACE@"NatronGui.Natron@g' -e 's@"NATRON_NAMESPACE@"Natron@g' -i'.bak' "$wrapper_dir"/*_wrapper.cpp - -# re-add the Natron namespace -#sed -e 's@" ::\([^s][^t][^d]\)@ NATRON_NAMESPACE::\1@g' -i'.bak' Engine/NatronEngine/*.cpp Engine/NatronEngine/*.h Gui/NatronGui/*.cpp Gui/NatronGui/*.h - -sed -e 's@SbkType< ::@SbkType$@CLANG_DIAG_OFF(header-guard)\ -#include // has wrong header guards in pyside 1.2.2@' -i'.bak' "$wrapper_dir"/*.cpp - -sed -e 's@^#include $@// clang-format off\ -CLANG_DIAG_OFF(deprecated)\ -CLANG_DIAG_OFF(uninitialized)\ -CLANG_DIAG_OFF(keyword-macro)\ -#include // produces warnings\ -CLANG_DIAG_ON(deprecated)\ -CLANG_DIAG_ON(uninitialized)\ -CLANG_DIAG_ON(keyword-macro)\ -// clang-format on@' -i'.bak' "$wrapper_dir"/*.cpp "$wrapper_dir"/*.h - -sed -e 's@^#include $@// clang-format off\ -CLANG_DIAG_OFF(deprecated)\ -CLANG_DIAG_OFF(uninitialized)\ -CLANG_DIAG_OFF(keyword-macro)\ -#include // produces warnings\ -CLANG_DIAG_ON(deprecated)\ -CLANG_DIAG_ON(uninitialized)\ -CLANG_DIAG_ON(keyword-macro)\ -// clang-format on@' -i'.bak' "$wrapper_dir"/*.cpp "$wrapper_dir"/*.h - -# clean up -rm "$wrapper_dir"/*.bak diff --git a/tools/utils/runPostShiboken2.sh b/tools/utils/runPostShiboken2.sh deleted file mode 100755 index 349970b45..000000000 --- a/tools/utils/runPostShiboken2.sh +++ /dev/null @@ -1,111 +0,0 @@ -#!/bin/bash -# ***** BEGIN LICENSE BLOCK ***** -# This file is part of Natron , -# Copyright (C) 2016 INRIA and Alexandre Gauthier -# -# Natron is free software: you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# Natron is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Natron. If not, see -# ***** END LICENSE BLOCK ***** - -# exit if a command returns an error status -set -e - -if [ "$#" -ne 2 ]; then - echo "usage: " 2>&1 - exit 1 -fi - -wrapper_dir="$1" -wrapper_name="$2" -wrapper_source=${wrapper_name}_module_wrapper.cpp -wrapper_header=${wrapper_name}_python.h - -SED="sed" -if [ "$(uname)" = "Darwin" ]; then - # this script uses the sed cammand "T;", which is a GNU extension - SED=gsed - path_to_sed="$(which $SED)" - if [ ! -x "$path_to_sed" ] ; then - echo "$SED is required but not available; please install it:" - echo "- 'brew install gnu-sed' on Homebrew," - echo "- 'sudo port install gsed' on MacPorts." - exit 1 - fi -fi - -# To be run after shiboken to fix errors - -if [ "$wrapper_name" = "natrongui" ]; then - $SED -e "/SbkPySide2_QtCoreTypes;/d" -i'.bak' "$wrapper_dir/$wrapper_source" - $SED -e "/SbkPySide2_QtCoreTypeConverters;/d" -i'.bak' "$wrapper_dir/$wrapper_source" - $SED -e '/SbkNatronEngineTypes;/d' -i'.bak' "$wrapper_dir/$wrapper_source" - $SED -e '/SbkNatronEngineTypeConverters;/d' -i'.bak' "$wrapper_dir/$wrapper_source" - $SED -e 's/cleanTypesAttributes/cleanGuiTypesAttributes/g' -i'.bak' "$wrapper_dir/$wrapper_source" -fi - -# fix warnings -$SED -e 's@^#include $@#include "Global/Macros.h"\ -// clang-format off\ -CLANG_DIAG_OFF(mismatched-tags)\ -GCC_DIAG_OFF(unused-parameter)\ -GCC_DIAG_OFF(missing-field-initializers)\ -GCC_DIAG_OFF(missing-declarations)\ -GCC_DIAG_OFF(uninitialized)\ -GCC_DIAG_UNUSED_LOCAL_TYPEDEFS_OFF\ -// clang-format on\ -#include \ -#include // produces many warnings@' -i'.bak' "$wrapper_dir"/*.cpp - -$SED -e 's@// inner classes@// inner classes\ -NATRON_NAMESPACE_USING NATRON_PYTHON_NAMESPACE_USING@' -i'.bak' "$wrapper_dir"/*.cpp -$SED -e 's@// Extra includes@// Extra includes\ -NATRON_NAMESPACE_USING NATRON_PYTHON_NAMESPACE_USING@' -i'.bak' "$wrapper_dir/$wrapper_source" - -# replace NATRON_NAMESPACE with Natron for enums with flags (e.g. StandardButtonEnum) -$SED -e 's@"1:NatronEngine\.NATRON_NAMESPACE@"1:NatronEngine.Natron@g' -e 's@, NatronEngine\.NATRON_NAMESPACE@, NatronEngine.Natron@g' -e 's@"1:NatronGui\.NATRON_NAMESPACE@"NatronGui.Natron@g' -e 's@"NATRON_NAMESPACE@"Natron@g' -i'.bak' "$wrapper_dir"/*_wrapper.cpp - -# re-add the Natron namespace -#sed -e 's@" ::\([^s][^t][^d]\)@ NATRON_NAMESPACE::\1@g' -i'.bak' Engine/Qt5/NatronEngine/*.cpp Engine/Qt5/NatronEngine/*.h Gui/Qt5/NatronGui/*.cpp Gui/Qt5/NatronGui/*.h - -$SED -e 's@SbkType< ::@SbkType$@CLANG_DIAG_OFF(header-guard)\ -#include // has wrong header guards in pyside 1.2.2@' -i'.bak' "$wrapper_dir"/*.cpp - -$SED -e 's@^#include $@CLANG_DIAG_OFF(deprecated)\ -CLANG_DIAG_OFF(uninitialized)\ -CLANG_DIAG_OFF(keyword-macro)\ -#include // produces warnings\ -CLANG_DIAG_ON(deprecated)\ -CLANG_DIAG_ON(uninitialized)\ -CLANG_DIAG_ON(keyword-macro)@' -i'.bak' "$wrapper_dir"/*.cpp "$wrapper_dir"/*.h - -$SED -e 's@^#include $@CLANG_DIAG_OFF(deprecated)\ -CLANG_DIAG_OFF(uninitialized)\ -CLANG_DIAG_OFF(keyword-macro)\ -#include // produces warnings\ -CLANG_DIAG_ON(deprecated)\ -CLANG_DIAG_ON(uninitialized)\ -CLANG_DIAG_ON(keyword-macro)@' -i'.bak' "$wrapper_dir"/*.cpp "$wrapper_dir"/*.h - -# clean up -rm "$wrapper_dir"/*.bak diff --git a/tools/utils/sourceCleanup.py b/tools/utils/sourceCleanup.py new file mode 100644 index 000000000..74167b5b5 --- /dev/null +++ b/tools/utils/sourceCleanup.py @@ -0,0 +1,50 @@ +from xml.etree import ElementTree +import os +import re +import sys + + +def clean_typesystem_cpp_sources(typesystem, out): + tree = ElementTree.parse(typesystem) + root = tree.getroot() + + package = root.attrib["package"] + + tags = ["namespace-type", "object-type", "value-type"] + types = [child.attrib["name"] for child in root if child.tag in tags] + + sources = [f"{package.lower()}_module_wrapper.cpp", f"{package.lower()}_python.h"] + sources.extend([f"{t.lower()}_wrapper.cpp" for t in types]) + sources.extend([f"{t.lower()}_wrapper.h" for t in types]) + + prog = re.compile("([\\s(,])::(?!Natron)(\\w+[^:])") + + for s in sources: + with open(os.path.normpath(os.path.join(out, package, s)), "r+") as f: + lines = f.readlines() + f.seek(0) + for l in lines: + f.write(prog.sub("\\1\\2", l)) + f.truncate() + + if package.lower() == "natrongui": + with open(os.path.normpath(os.path.join(out, package, sources[0])), "r+") as f: + lines = f.readlines() + f.seek(0) + for l in lines: + if (l.endswith("QtCoreTypes;\n") or + l.endswith("QtCoreTypeStructs;\n") or + l.endswith("QtCoreTypeConverters;\n") or + l.endswith("SbkNatronEngineTypes;\n") or + l.endswith("SbkNatronEngineTypeStructs;\n") or + l.endswith("SbkNatronEngineTypeConverters;\n")): + continue + f.write(l.replace("cleanTypesAttributes", "cleanGuiTypesAttributes")) + f.truncate() + + +if __name__ == "__main__": + if len(sys.argv) != 3: + print("usage: sourceCleanup.py ", file=sys.stderr) + exit(1) + clean_typesystem_cpp_sources(sys.argv[1], sys.argv[2])