Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PassengerCapacity@id #515

Closed
skinkie opened this issue Oct 3, 2023 · 7 comments · Fixed by #579
Closed

PassengerCapacity@id #515

skinkie opened this issue Oct 3, 2023 · 7 comments · Fixed by #579
Assignees
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Milestone

Comments

@skinkie
Copy link
Contributor

skinkie commented Oct 3, 2023

In relation to #471 I notice that the examples in prCEN-1 mention PassengerCapacity without an id attribute, while the table does suggest is is a required element.

image

image

In your opinion what is wrong here?

@skinkie skinkie added question needs documentation update The NeTEx document needs to be updated labels Oct 3, 2023
@Aurige
Copy link
Contributor

Aurige commented Oct 3, 2023

In this specific case, the PassengerCapacity attribute has a type PassengerCapacityStructure and does not ref the PassengerCapacity element (this said, it can also be seen as an issue). So the example is Ok for now.

However, the element itself is defined as below, and the <xsd:attribute name="id" type="PassengerCapacityIdType" use="optional"> is not consistent with the documentation and should be fixed

<xsd:element name="PassengerCapacity">
		<xsd:annotation>
			<xsd:documentation>Capacity for a VEHICLE TYPE and Class.</xsd:documentation>
		</xsd:annotation>
		<xsd:complexType>
			<xsd:complexContent>
				<xsd:restriction base="PassengerCapacityStructure">
					<xsd:sequence>
						<xsd:sequence>
							<xsd:group ref="EntityInVersionGroup" minOccurs="0"/>
						</xsd:sequence>
						<xsd:sequence>
							<xsd:group ref="DataManagedObjectGroup"/>
						</xsd:sequence>
						<xsd:sequence>
							<xsd:group ref="PassengerCapacityGroup"/>
						</xsd:sequence>
					</xsd:sequence>
					<xsd:attribute name="id" type="PassengerCapacityIdType" use="optional">
						<xsd:annotation>
							<xsd:documentation>Identifier of PASSENGER CAPACITY.</xsd:documentation>
						</xsd:annotation>
					</xsd:attribute>
				</xsd:restriction>
			</xsd:complexContent>
		</xsd:complexType>
	</xsd:element>

@skinkie
Copy link
Contributor Author

skinkie commented Oct 3, 2023

@Aurige in your opinion, similar to AccessibilityAssessment should have its own id+version attributes while it is actually embedded within a versioned object?

@Aurige
Copy link
Contributor

Aurige commented Oct 3, 2023

That's the group discussion we had during meeting #13 around #471 that didn't find a conclusion yet

@skinkie
Copy link
Contributor Author

skinkie commented Oct 3, 2023

@Aurige so either we fix the documentation xor the xsd? ;-)

@Aurige
Copy link
Contributor

Aurige commented Oct 4, 2023

I guess we can fix the xsd here (set use="required")

@Aurige
Copy link
Contributor

Aurige commented Oct 4, 2023

then we can remove the "need documentation" tag ;-)

@ue71603 ue71603 added bug Technical mistake, inconsistency with the documentation, etc. and removed question needs documentation update The NeTEx document needs to be updated labels Dec 1, 2023
@ue71603 ue71603 added this to the netex_1.2 milestone Dec 1, 2023
@ue71603
Copy link
Contributor

ue71603 commented Dec 12, 2023

fixed by #579

@ue71603 ue71603 closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants