Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace skip_bridge_call and validate_ethash with feature flags #180

Closed
MaksymZavershynskyi opened this issue Jul 15, 2020 · 1 comment
Closed

Replace skip_bridge_call and validate_ethash with feature flags #180

MaksymZavershynskyi opened this issue Jul 15, 2020 · 1 comment
Assignees
@ailisp
Labels
2020-07 audit enhancement P2

Comments

@MaksymZavershynskyi
Copy link
Contributor

As reported by a user:

Have you folks considered removing the skip_bridge_call and validate_ethash booleans, and replacing them with feature flags? It seems like a massive footgun to me as is right now to deploy the contract by accident with the ethash validation turned off, or making mints without checking the bridge (you could still use the feature flag for disabling these functionalities in tests/testnets)

This means that some tests would need to be executed with feature flags.
@MaksymZavershynskyi
Copy link
Contributor Author

Duplicate of #247

@MaksymZavershynskyi MaksymZavershynskyi marked this as a duplicate of #247 Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ailisp ailisp

Labels
2020-07 audit enhancement P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ailisp @MaksymZavershynskyi