Hide ordering a bit

[joschmitt]

I renamed the ordering keyword in polynomial rings to internal_ordering as a first attempt in the direction of oscar-system/Oscar.jl#3040 and a basis for discussion how this should proceed (if at all).

CC @YueRen (because you seemed interested...)

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e87be00) 86.98% compared to head (a3d8f28) 86.98%.

Files	Patch %	Lines
src/MPoly.jl	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1597   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files         114      114           
  Lines       29686    29686           
=======================================
  Hits        25823    25823           
  Misses       3863     3863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lgoettgens]

I like the general idea of this. some comments

[YueRen]

I also like the idea of differentiating between Nemo and Singular monomial orderings by using different names!

[fingolfin]

I like it

[joschmitt]

This is the way to go as decided in today's "Kaiserslautern meeting".

[joschmitt]

The failing test is "expected", right?

[lgoettgens]

It's at least not the first time I've seen it. We should probably open a issue about it

[joschmitt]

Please merge this whenever we are ready for the next cascade of breaking releases.

[joschmitt]

I removed the deprecations now. If we keep them in, we would also deprecate ordering for the Singular.jl rings because they are <: MPolyRing. Please tell me, if I am missing something.

[joschmitt]

The auto-merge will not work. At least, the "matching" checks haven't started for days now.