Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yet more flinitfy (and related tweaks) #1876

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Yet more flinitfy (and related tweaks) #1876

wants to merge 1 commit into from

Conversation

fingolfin
Copy link
Member

Also remove redundant jacobi_symbol method.

@fingolfin
Yet more flinitfy (and related tweaks)
a97503b 
Also remove redundant `jacobi_symbol` method.
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.23762% with 24 lines in your changes missing coverage. Please review.

Project coverage is 87.30%. Comparing base (fbef9d1) to head (a97503b).

Files with missing lines Patch % Lines
src/antic/nf_elem.jl 8.33% 11 Missing ⚠️
src/flint/fmpq_poly.jl 0.00% 7 Missing ⚠️
src/arb/Complex.jl 80.00% 2 Missing ⚠️
src/flint/fmpz_mat.jl 93.75% 2 Missing ⚠️
src/flint/fmpz.jl 83.33% 1 Missing ⚠️
src/flint/fmpz_poly.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
- Coverage   87.34%   87.30%   -0.04%     
==========================================
  Files          97       97              
  Lines       35832    35745      -87     
==========================================
- Hits        31296    31207      -89     
- Misses       4536     4538       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fingolfin
fingolfin commented Oct 1, 2024
View reviewed changes
src/antic/nf_elem.jl
@@ -396,11 +396,11 @@ function -(a::QQFieldElem, b::AbsSimpleNumFieldElem)
return r
end

+(a::AbsSimpleNumFieldElem, b::Integer) = a + ZZRingElem(b)
+(a::AbsSimpleNumFieldElem, b::Integer) = a + flintify(b)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test coverage for adhoc operations is really bad. Would be good to have more of those in the interface tests (possibly optionally, as I am not sure we mandate this in the ring interface?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ring interface states that it is optional to add explicit ad-hoc functions, but AA should take care of the fallback using promotion (see https://nemocas.github.io/AbstractAlgebra.jl/dev/ring_interface/#Optional-binary-ad-hoc-operators)

lgoettgens
lgoettgens approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the matrix constructor changes are very hard to follow. maybe the next time put moving and changing into two different commit? Anyway, I don't see anything bad standing out

@lgoettgens lgoettgens mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgoettgens lgoettgens lgoettgens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @lgoettgens