Failing to open popups for more than one repositories

[asmodeus812]

Description

Whenever a call to open a specific popup is made, for example the logs popup, the first time it is invoked, it works fine, however if we change the cwd to antoher (valid git directory) and try to invoke the logs popup neogit throws an error.

Neovim version

0.9.4

Operating system and version

Ubuntu 22

Steps to reproduce

1. open file from one git repo
2. set lcd/tcd to the current git repo
3. lua require("neogit").open({ "log" })
4. log is displayed fine for the correct repo
5. open file from another git repo in another tag
6. set lcd/tcd for the current repo.
7. lua require("neogit").open({ "log" })
8. neogit fails with errors

Expected behavior

Popups, similarly to status, should be openable for different git repositories based on the current working directory, ideally should be able to specify the cwd explicitly, just as we do with status.

Actual behavior

Error is thrown

.../packages/start/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: ...site/pack/pac
kages/opt/neogit/lua/neogit/lib/git/log.lua:208: No commit found for oid: 51eb96f027d598549b1c241058b9b8a70d38b445
stack traceback:
^I[C]: in function 'error'
^I.../packages/start/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'
^I.../packages/start/plenary.nvim/lua/plenary/async/async.lua:45: in function 'cb'
^I...vim/site/pack/packages/opt/neogit/lua/neogit/process.lua:359: in function <...vim/site/pack/packages/opt/neogit/lua
/neogit/process.lua:325>

Minimal config

-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}

local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
  return base_root_path .. "/" .. (path or "")
end

function M.load_plugin(plugin_name, plugin_url)
  local package_root = M.root("plugins/")
  local install_destination = package_root .. plugin_name
  vim.opt.runtimepath:append(install_destination)

  if not vim.loop.fs_stat(package_root) then
    vim.fn.mkdir(package_root, "p")
  end

  if not vim.loop.fs_stat(install_destination) then
    print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
    vim.fn.system({
      "git",
      "clone",
      "--depth=1",
      plugin_url,
      install_destination,
    })
    if vim.v.shell_error > 0 then
      error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
        vim.log.levels.ERROR)
    end
  end
end

---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>

---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
  vim.opt.packpath = {}                      -- Empty the package path so we use only the plugins specified
  vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir

  -- Install required plugins
  if plugins ~= nil then
    for plugin_name, plugin_url in pairs(plugins) do
      M.load_plugin(plugin_name, plugin_url)
    end
  end

  vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
  vim.env.XDG_DATA_HOME = M.root("xdg/data")
  vim.env.XDG_STATE_HOME = M.root("xdg/state")
  vim.env.XDG_CACHE_HOME = M.root("xdg/cache")

  -- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
  vim.api.nvim_create_autocmd("VimLeave", {
    callback = function()
      vim.fn.system({
        "rm",
        "-r",
        "-f",
        M.root("xdg")
      })
    end
  })
end

-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
  plenary = "https://github.com/nvim-lua/plenary.nvim.git",
  telescope = "https://github.com/nvim-telescope/telescope.nvim",
  diffview = "https://github.com/sindrets/diffview.nvim",
  neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({}) -- For instance, setup Neogit