Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the "storagePrefix" parameter at the backend creation #401

Closed
YvosOnTheHub opened this issue May 15, 2020 · 3 comments
Closed

Check the "storagePrefix" parameter at the backend creation #401

YvosOnTheHub opened this issue May 15, 2020 · 3 comments

Comments

@YvosOnTheHub
Copy link

Describe the solution you'd like
Trident does not seem to verify the validity of the storagePrefix parameter.
Adding an extra check would avoid errors at PVC creation.

Describe alternatives you've considered
An alternative would be to add caveats in the documentation with regards to this parameter.

Additional context
In my test, here is the parameter I used:
"storagePrefix": "test/nas1_",
Trident did not complain during the backend creation.

However, an ONTAP error was raised when creating a PVC:

failed to provision volume with StorageClass "storage-class-nas": rpc error: code = Unknown desc = encountered error(s) in creating the volume: [Failed to create volume pvc-46a0cded-a847-4b85-b10a-ca7a968e8717 on storage pool aggr1 from backend NAS_Vol-default: error checking for existing volume: API status: failed, Reason: Invalid character '/' in volume name. It can have '_' and alphanumeric characters., Code: 13001], [Failed to create volume pvc-46a0cded-a847-4b85-b10a-ca7a968e8717 on storage pool aggr2 from backend NAS_Vol-default: error checking for existing volume: API status: failed, Reason: Invalid character '/' in volume name. It can have '_' and alphanumeric characters., Code: 13001]

@gnarl
Copy link
Contributor

gnarl commented Jun 7, 2020

We are planning to fix this in the Trident 20.07 release.

@gnarl
Copy link
Contributor

gnarl commented Jul 14, 2020

Fixed in commit c262e4c.

@gnarl gnarl closed this as completed Jul 31, 2020
@travisghansen
Copy link

This removed the ability to use - which seemed to be perfectly fine previously...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants