Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hystrix.stream holds connection open if no metrics #85

Closed
benjchristensen opened this issue Jan 9, 2013 · 1 comment
Closed

hystrix.stream holds connection open if no metrics #85

benjchristensen opened this issue Jan 9, 2013 · 1 comment
Labels
bug
Milestone
1.2.x

Comments

@benjchristensen
Copy link
Contributor

If a server has not yet had any command executions to generate metrics the hystrix.stream servlet will loop infinitely waiting on metrics.

Since it keeps looping with no data it will never attempt writing to the outputstream.

Thus, it will never close the connection even if the client disconnects as it won't get an IOException or call close().

This will keep the servlet inside the try/catch and never count down the counter.
This was referenced Jan 9, 2013
Closed
Merged
@benjchristensen
Copy link
Contributor Author

Here is how the problem manifested itself:

$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"/>
<title>Error 503 MaxConcurrentConnections reached: 5</title>
</head>
<body><h2>HTTP ERROR 503</h2>
<p>Problem accessing /hystrix-examples-webapp/hystrix.stream. Reason:
<pre>    MaxConcurrentConnections reached: 5</pre></p><hr /><i><small>Powered by Jetty://</small></i><br/>                                                
<br/>                                                
<br/>

Now it looks like this with the ping that detects a connection closing:


$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
ping: 

ping: 

ping: 

^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
ping: 

ping: 

ping: 

^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
ping: 

ping: 

ping: 

^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
ping: 

ping: 

ping: 

^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
ping: 

ping: 

ping: 

^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
ping: 

ping: 

ping: 

^C
$ curl http://localhost:8989/hystrix-examples-webapp/hystrix.stream
ping: 

ping: 

ping:

@benjchristensen benjchristensen mentioned this issue Jan 10, 2013
Closed
@C-Otto C-Otto mentioned this issue Mar 3, 2016
Open
@DangerPete DangerPete mentioned this issue Nov 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.2.x
Development

No branches or pull requests
1 participant
@benjchristensen