-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy modules #1995
Remove legacy modules #1995
Conversation
@srinivasankavitha @kilink Preparing this branch for onboarding purposes. Not ready to merge yet, but it's a preview of things to come. |
Looks good to me. I've noticed quite a few projects that add |
0c9e524
to
1359c19
Compare
@@ -1,5 +1,5 @@ | |||
/* | |||
* Copyright 2023 Netflix, Inc. | |||
* Copyright 2021 Netflix, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More curious than an actual comment, but why did the (c) get adjusted back in time? Should this be a SED to bump them up to 2024?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I have no idea. The copyright header comes from a profile in Intellij, which has $today.year
as a variable. After this is merged with can do a clean up.
...hql-dgs-client/src/test/kotlin/com/netflix/graphql/dgs/client/RestClientGraphQLClientTest.kt
Show resolved
Hide resolved
...nt/src/test/kotlin/com/netflix/graphql/dgs/client/GraphqlSSESubscriptionGraphQLClientTest.kt
Show resolved
Hide resolved
...kotlin/com/netflix/graphql/dgs/springgraphql/autoconfig/DgsSpringGraphQLAutoConfiguration.kt
Show resolved
Hide resolved
...oss-autoconfigure/src/main/kotlin/com/netflix/graphql/dgs/autoconfig/DgsAutoConfiguration.kt
Show resolved
Hide resolved
...nt/src/test/kotlin/com/netflix/graphql/dgs/client/WebSocketGraphQLClientWithDGSServerTest.kt
Outdated
Show resolved
Hide resolved
… protocol. GraphqlSSESubscriptionGraphQLClient is now recommended, and works out of the box with Spring GraphQL.
…e of it using the old WS protocol.
bb08e75
to
b29d2e0
Compare
Preview branch removing all legacy modules. This will be merged in late 2024. From then on, the DGS/Spring GraphQL integration will be the only implementation.
Test with the Release Candidate
We published
10.0.0-rc.1
as the first Release Candidate based on this branch.To test with the RC, add the following repository to your
build.gradle
(or Maven equivalent).### Details of changes
The following modules are completely removed because they are replaced by Spring GraphQL. If you were already using the
com.netflix.graphql.dgs:graphql-dgs-spring-graphql-starter
(Spring GraphQL integration) you were already not using any of these modules.Deleted modules:
Deleted classes:
@SpringBootTest(classes = {DgsAutoConfiguration.class, ...}
, and should use@EnableDgsTest
instead.[CustomGraphQLClient
,CustomReactiveGraphQLClient
andWebClientGraphQLClient
.Other changes
SSESubscriptionGraphQLClient
in tests to test your DGS server, switch toGraphqlSSESubscriptionGraphQLClient
, which has the same interface, but uses the new protocol.SSESubscriptionGraphQLClient
can still be used to call into other services using the old protocol, but this client is now deprecated for removal in the future./graphql
endpoint, not on the/subscriptions
endpoint like DGS used to do.