Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MXF string termination to avoid incorrect validation errors #372

Closed
thomasheritage opened this issue Jun 26, 2024 · 3 comments · Fixed by #373
Closed

Handle MXF string termination to avoid incorrect validation errors #372

thomasheritage opened this issue Jun 26, 2024 · 3 comments · Fixed by #373
Labels

Comments

@thomasheritage
Copy link
Contributor

MXF Header Metadata string properties that contain a null character should be trimmed. Currently, the terminating null character (and any subsequent characters) are included in the string used by Photon for validation, resulting in incorrect error reports such as:

[main] ERROR com.netflix.imflibrary.app.IMPAnalyzer -           ERROR-Language Code ([0x656e2d474200, en-GB.]) in SoundFieldGroupLabelSubdescriptor in the IMFTrackfile represented by ID ac4aaec3-a55c-48d0-a806-6cb92888ab3a is not RFC5646 compliant [Photon version: 4.10.0-SNAPSHOT]
@thomasheritage
Copy link
Contributor Author

This looks like the same as was discussed in #196 (which is closed)

@fschleich
Copy link
Contributor

@thomasheritage - thanks for creating the PR! Would you be able to share a sample file that demonstrates the issue?

@thomasheritage
Copy link
Contributor Author

The MXF file in this ZIP demonstrates the issue:
AUDIO_05a22e3f-b79c-472a-81da-f806469c8574.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants