Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repeater): add PROXY and NO_PROXY env variables #620

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

maksadbek
Copy link
Collaborator

PROXY is an alias to --proxy flag
NO_PROXY is an alias to --proxy-domains-bypass flag

PROXY is an alias to --proxy flag
NO_PROXY is an alias to --proxy-domains-bypass flag
@maksadbek maksadbek added Type: enhancement New feature or request. javascript Pull requests that update Javascript code labels Nov 26, 2024
@maksadbek maksadbek self-assigned this Nov 26, 2024
@orubin
Copy link
Contributor

orubin commented Nov 26, 2024

Thanks @maksadbek.
Maybe the PROXY flag should be HTTP_PROXY / HTTPS_PROXY?
https://superuser.com/questions/944958/are-http-proxy-https-proxy-and-no-proxy-environment-variables-standard

@orubin
Copy link
Contributor

orubin commented Nov 26, 2024

@orubin orubin merged commit 340755a into next Nov 26, 2024
6 checks passed
@orubin orubin deleted the read-proxy-params-from-env branch November 26, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants