From 3a0657eb4d7fe5cddd47a09b302740c32443e0e1 Mon Sep 17 00:00:00 2001 From: Maksadbek Date: Fri, 8 Nov 2024 09:37:47 +0100 Subject: [PATCH 1/3] chore: fix e2e test pipeline The git checkout step is failing as actions/checkout actions has started using node20 be default. Since node20 requires GLIBC version 2.28 and upper, our tests that run on Ubunu 16.04 and 18.04 are failing. The solution is to add ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true env variable. --- .github/workflows/e2e.yml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 94bc2ebb..f3f190c0 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -41,6 +41,9 @@ jobs: if: ${{ inputs.test-executables }} runs-on: ${{ matrix.os }} container: ${{ matrix.container }} + env: + ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true + strategy: fail-fast: false matrix: @@ -94,7 +97,7 @@ jobs: && rm -rf /var/lib/apt/lists/* - name: Checkout Repository - uses: actions/checkout@v2 + uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 - name: Download Executable shell: bash @@ -125,6 +128,7 @@ jobs: E2E_REPEATER_TARGET_URL: ${{ format('http://localhost:{0}', steps.target.outputs.port) }} E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }} E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }} + msi: if: ${{ inputs.test-msi }} runs-on: windows-latest @@ -175,6 +179,7 @@ jobs: E2E_REPEATER_TARGET_URL: ${{ format('http://localhost:{0}', steps.target.outputs.port) }} E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }} E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }} + docker: if: ${{ inputs.test-docker }} runs-on: ${{ matrix.os }} @@ -193,7 +198,7 @@ jobs: run: docker pull brightsec/cli:${{ inputs.version }} - name: Checkout Repository - uses: actions/checkout@v2 + uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 - name: Download Target id: target @@ -217,10 +222,14 @@ jobs: E2E_REPEATER_TARGET_URL: ${{ format('http://host.docker.internal:{0}', steps.target.outputs.port) }} E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }} E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }} + npm: if: ${{ inputs.test-npm }} runs-on: ${{ matrix.os }} container: ${{ matrix.container }} + env: + ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true + strategy: fail-fast: false matrix: @@ -257,7 +266,7 @@ jobs: && rm -rf /var/lib/apt/lists/* - name: Checkout Repository - uses: actions/checkout@v2 + uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 - name: Download Target id: target From 3a9633fcb3346f632f0a5fac18534f2c0b240099 Mon Sep 17 00:00:00 2001 From: maksadbek Date: Mon, 11 Nov 2024 11:48:00 +0100 Subject: [PATCH 2/3] Update e2e.yml --- .github/workflows/e2e.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index f3f190c0..68b18d32 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -97,7 +97,7 @@ jobs: && rm -rf /var/lib/apt/lists/* - name: Checkout Repository - uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 + uses: actions/checkout@2 - name: Download Executable shell: bash @@ -198,7 +198,7 @@ jobs: run: docker pull brightsec/cli:${{ inputs.version }} - name: Checkout Repository - uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 + uses: actions/checkout@2 - name: Download Target id: target @@ -266,7 +266,7 @@ jobs: && rm -rf /var/lib/apt/lists/* - name: Checkout Repository - uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 + uses: actions/checkout@2 - name: Download Target id: target From 6c021f0c3c5641213119de4ed90f6321cc5c68b5 Mon Sep 17 00:00:00 2001 From: maksadbek Date: Mon, 11 Nov 2024 11:49:02 +0100 Subject: [PATCH 3/3] Update e2e.yml --- .github/workflows/e2e.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 68b18d32..d9c1a04b 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -97,7 +97,7 @@ jobs: && rm -rf /var/lib/apt/lists/* - name: Checkout Repository - uses: actions/checkout@2 + uses: actions/checkout@v2 - name: Download Executable shell: bash @@ -198,7 +198,7 @@ jobs: run: docker pull brightsec/cli:${{ inputs.version }} - name: Checkout Repository - uses: actions/checkout@2 + uses: actions/checkout@v2 - name: Download Target id: target @@ -266,7 +266,7 @@ jobs: && rm -rf /var/lib/apt/lists/* - name: Checkout Repository - uses: actions/checkout@2 + uses: actions/checkout@v2 - name: Download Target id: target