Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No read permissions in gem #32

Open
ChrisBr opened this issue Jun 11, 2020 · 1 comment
Open

No read permissions in gem #32

ChrisBr opened this issue Jun 11, 2020 · 1 comment

Comments

@ChrisBr
Copy link
Contributor

ChrisBr commented Jun 11, 2020

As mentioned in #31, we had issues in production to require the gem. After using the new release, the bug was still not fixed however although our fork worked. After more debugging, we found out that the packaged gem does not have read permissions set except for privileged users.

tar -tvf data.tar.gz
-rw-------  0 wheel  wheel    3720 11 Jun 08:46 README.md
-rw-------  0 wheel  wheel      26 11 Jun 08:46 lib/omniauth-wechat-oauth2.rb
-rw-------  0 wheel  wheel    2207 11 Jun 08:46 lib/omniauth/strategies/wechat.rb
-rw-------  0 wheel  wheel    2577 11 Jun 08:46 lib/omniauth/strategies/wechat_qiye.rb
-rw-------  0 wheel  wheel      79 11 Jun 08:46 lib/omniauth/wechat.rb

Seems something is wrong on the machine which is used to build and package the gem. Could you please fix the permission and release a new version. Thank you!

@Eric-Guo
Copy link
Collaborator

Yes, I set the umask 077 a long time ago, so lacking read permit for everyone and group probably should think as a feature instead of a bug.

Since it already impacts the production, I just release 0.2.2 which contains the everyone can having read permitted.

But I think it is still arguable here, and I believe original only user can read is the correct setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants