Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evm] refactor: Gas fee cap check was moved to ante handler. Remove or uncomment from VerifyFee #2078

Open
Unique-Divine opened this issue Oct 13, 2024 · 0 comments

Comments

@Unique-Divine
Copy link
Member

Unique-Divine commented Oct 13, 2024

There's some dead code and/or misleading comments. This was pointed out in the Oct 2024 audit.

See

// gasFeeCapMicronibi := evm.WeiToNative(txData.GetGasFeeCapWei())
// if baseFeeMicronibi != nil && gasFeeCapMicronibi.Cmp(baseFeeMicronibi) < 0 {
// baseFeeWei := evm.NativeToWei(baseFeeMicronibi)
// return nil, errors.Wrapf(errortypes.ErrInsufficientFee,
// "the tx gasfeecap is lower than the tx baseFee: %s (gasfeecap), %s (basefee) wei per gas",
// txData.GetGasFeeCapWei(),
// baseFeeWei,
// )
// }

@github-project-automation github-project-automation bot moved this to ⚡ Building 🧱 in ⚛️ Nibiru (Hougyoku) Oct 13, 2024
@github-actions github-actions bot added the S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5 label Oct 13, 2024
@Unique-Divine Unique-Divine added good first issue and removed S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5 labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ⚡ Building 🧱
Development

No branches or pull requests

1 participant