Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseOptionAttribute LongName and ShortName #54

Closed
TheColonel2688 opened this issue Jul 22, 2019 · 5 comments
Closed

BaseOptionAttribute LongName and ShortName #54

TheColonel2688 opened this issue Jul 22, 2019 · 5 comments

Comments

@TheColonel2688
Copy link

Can the Accessibility Level on ShortName and LongName in BaseOptionAttribute be changed to public? or at least public get?

I would like to use those attributes in my code.

@Nick-Lucas
Copy link
Owner

Nick-Lucas commented Jul 22, 2019

Hi @TheColonel2688

I don't see any reason they couldn't be public get, private set, but I'd definitely question the use case?

Is there some functionality that EntryPoint isn't providing, which you feel you need to implement in your app? If it's really unique to you then go ahead and open a pull request :)

Full disclosure: I'm not actively maintaining EntryPoint right now, as I'm not using it on any current projects, though I'm content it's been stable and production ready for a long time. I'll also make time for releasing an update if you have a PR for it. I'm happy to offer support and might even be able to maintain it more actively in the next few months.

@TheColonel2688
Copy link
Author

Basically, I just need to get the LongName as a string. I am having my app register itself as a service, so I need to pass the actual option flag string for my run-as-service flag to windows so that when it calls my app and runs in service mode.

yes, I could just give it a string literal but I figured it would be cleaner to get it for the OptionsAttribute so that if I change it in the CLIArguemtn definitions class it will auto-update.

@Nick-Lucas
Copy link
Owner

Nick-Lucas commented Jul 22, 2019

Thanks for the PR. I've merged it and will try to get out 1.3.0 shortly. Hopefully all the CI nuts and bolts still work after a couple years away!

It certainly doesn't hurt to make these attributes readable, so I have no objections here :)

@Nick-Lucas
Copy link
Owner

Okay that's deployed: https://www.nuget.org/packages/EntryPoint/

@TheColonel2688
Copy link
Author

Sweet thank you sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants