Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support accessible-menu 4.x #32

Closed
NickDJM opened this issue Feb 10, 2023 · 2 comments
Closed

Feat: Support accessible-menu 4.x #32

NickDJM opened this issue Feb 10, 2023 · 2 comments
Labels
2.x Flags issues that will be part of 2.x enhancement New feature or request ready Flags an issue as ready for release

Comments

@NickDJM
Copy link
Owner

NickDJM commented Feb 10, 2023

Related Issues

There have been a few breaking changes made in 4.x of accessible-menu. Need to make sure this works with the latest version.

Solution

  • Check/update error handling
  • Swap to vite?
@NickDJM NickDJM added the enhancement New feature or request label Feb 10, 2023
@NickDJM NickDJM mentioned this issue Feb 17, 2023
Merged
@NickDJM NickDJM added the 2.x Flags issues that will be part of 2.x label Feb 17, 2023
NickDJM added a commit that referenced this issue Feb 17, 2023
@NickDJM
build: replace rollup and jest with vite and vitest with demo env
ced8b93 
BREAKING CHANGE: vite changes the naming convention for the dist files

See #32
@NickDJM NickDJM added the ready Flags an issue as ready for release label Feb 17, 2023
@NickDJM NickDJM removed the ready Flags an issue as ready for release label Mar 5, 2024
@NickDJM
Copy link
Owner Author

NickDJM commented Mar 5, 2024

There were a few more major changes made in the 4.0.0 release. Will need to go through and double check everything is good to go.

@NickDJM
Copy link
Owner Author

NickDJM commented Mar 7, 2024

This is now done. Everything has feature parody.

@NickDJM NickDJM added the ready Flags an issue as ready for release label Mar 7, 2024
@NickDJM NickDJM closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Flags issues that will be part of 2.x enhancement New feature or request ready Flags an issue as ready for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickDJM