Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux sha256sum? #13

Open
NicolasConstant opened this issue Jul 20, 2023 · 1 comment
Open

linux sha256sum? #13

NicolasConstant opened this issue Jul 20, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@NicolasConstant
Copy link
Owner

NicolasConstant/sengi#441

@NicolasConstant
Copy link
Owner Author

Some insights on why those checksum aren't applied on all packages currently:

  • They are generated automatically by electron-builder
  • It seems they only generate them for builds that supports electron's builder auto-update capability

If we want checksum for every packages, we have to implement it ourselves.

Looking to @sid-the-sloth insights, Mdview seems to have an interesting way of doing it, their build trigger a script after all artifacts are done, and it's inside this script that the magic occurs.

I don't really know if the integration of this script would be flawless or would need some modification to work with sengi's build.

If you have some time on your hands, feel free to fork the project and check that, it you can get it working I'll be happy to merge your PR.

@NicolasConstant NicolasConstant added enhancement New feature or request good first issue Good for newcomers labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant