Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check loading state with dependencies #227

Closed
NiklasEi opened this issue Jul 7, 2024 · 2 comments · Fixed by #232
Closed

Check loading state with dependencies #227

NiklasEi opened this issue Jul 7, 2024 · 2 comments · Fixed by #232

Comments

@NiklasEi
Copy link
Owner

NiklasEi commented Jul 7, 2024

A handle should only be counted as loaded by this plugin when all it's dependencies are loaded.

count_loaded_handles should be using https://docs.rs/bevy_asset/latest/bevy_asset/struct.AssetServer.html#method.is_loaded_with_dependencies

@mgi388
Copy link

mgi388 commented Jul 7, 2024

@NiklasEi I briefly tested that out 1 line change locally, looks to be working 😌

@mgi388
Copy link

mgi388 commented Jul 8, 2024

The failure variable also needs to account for deps too otherwise if a dep fails to load the loading screen infinitely shows rather than transitioning to the error state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants