-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: run tests in same tab instead of separate browser instances #111
Comments
Just realised that you need this basically https://github.com/NimaSoroush/differencify/blob/master/API.md#share-browser This will still open new tab per test but that latency is really minimal. Hope this is what you are looking for |
I've given this suggestion a go, but still seeing fairly length page load times for are essentially just window resizes:
Is this expected? I'd think the initial page load would be longer, but subsequent tests only requiring a change in viewport size (and not a page refresh) would be much quicker? |
window resize should not take that long. Can you run them in non-headless mode and see what is going on? |
BTW, I am working on a new feature that will boost the test execution a lot (like 20 times faster). Still at POC level but planning to release it soon. So if the current performance does not bother you much you can wait for that |
Non-headless mode opens a single browser, but launches each test in a new tab - so the load time is still lengthy. I tried removing .newPage() for subsequent tests to attempt to force the test in the same tab, but was getting strange test results. For example, the first test passed showing correct styles but subsequent tests gave false positives (logo on the right should not be appearing):
Ideally testing a simple viewport change could be run in the same tab. Great to hear about he POC speed boost. Loving Differencify, just looking at ways we can get the most out of it. |
Currently testing a responsive component or page layout across multiple breakpoints requires a separate headless browser instance.
It might be much more efficient to resize the same browser window instead of spawning a new instance for each test. This would reduce test execution times dramatically.
The text was updated successfully, but these errors were encountered: