Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(discussion) direct pushing to master/release-20.09/... #104610

Closed
mohe2015 opened this issue Nov 22, 2020 · 2 comments
Closed

(discussion) direct pushing to master/release-20.09/... #104610

mohe2015 opened this issue Nov 22, 2020 · 2 comments

Comments

@mohe2015
Copy link
Contributor

I would like to know what the rules are for direct pushing to master. #20836 is discussing a broader range of security-related issues.
I found out that there are quite frequently direct pushes to master. The two most recent ones in the last 100 commits are these two (seem to be completely fine):
e6295fa
for which I couldn't find any pull request or issue reference (I don't want to blame the committer, this is just an example)

39acab6
which is #99129 where you can see that the target branch was the wrong one so they just merged it manually (and commented the commits). I also just saw that #104594 seems to try to find a better solution for cherry-picking/backporting.

Considering that it's really annoying to also check all commits and not only all pull requests I would like to know why protecting these branches from direct pushing has not been done? I think it's okay to have quite a few people who are allowed to merge pull requests as this is a pretty big project but I'm not sure if direct push access is really required.

@ajs124
Copy link
Member

ajs124 commented Nov 22, 2020

This has been discussed several times before at more or less length, e.g. here: NixOS/rfcs#79

@mohe2015
Copy link
Contributor Author

Thanks for the link. I searched this repo but I totally forgot that there are RFCs. I will close this as there doesn't seem to be consensus and it already was discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants