Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: some YouTube videos fail w/ AttributeError: 'NoneType' object has no attribute 'group' #150843

Open
YoshiRulz opened this issue Dec 15, 2021 · 7 comments
Labels
0.kind: bug Something is broken

Comments

@YoshiRulz
Copy link
Contributor

YoshiRulz commented Dec 15, 2021

Describe the bug

Attempting to download seemingly any video with music fails with AttributeError: 'NoneType' object has no attribute 'group'. This is probably caused by YouTube changing the pages it serves; I checked my shell history and videos which were playable yesterday are now broken.

Steps To Reproduce

Steps to reproduce the behavior:

  1. nix-env -f https://github.com/NixOS/nixpkgs/archive/nixos-21.11.tar.gz -iA youtube-dl
  2. youtube-dl https://www.youtube.com/watch?v=mgsayvglv5o

Examples of videos which cause the error: mgsayvglv5o EFEmTsfFL5A
Example of a working video: WLIfbiTUMiU

Expected behavior

Video downloads in best format (w/o flags) / a list of formats is printed (w/ -F).

Notify maintainers

@bluescreen303 @Phreedom @AndersonTorres @fpletz @Ma27

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.12.0-1-MANJARO, Manjaro Linux, noversion`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4`
 - channels(yoshi): `"nixpkgs-21.11.333823.96b4157790f"`
 - nixpkgs: `/home/yoshi/.nix-defexpr/channels/nixpkgs`

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: youtube-dl
# a list of nixos modules affected by the problem
module:
@Informatic
Copy link
Contributor

youtube-dl is seemingly abandoned, superseded by youtube-dlp (a mostly-drop-in replacement fork)

@primeos
Copy link
Member

primeos commented Dec 15, 2021

Yeah, unfortunately youtube-dl seems to have "died" (it was always undermaintained, IIRC) without an official successor. We could consider deprecating the package. Might be worth checking how other Linux distributions handle this.

I have done some quick research a couple of days ago to look at the current situation.
Here are a few notes I made, in case it helps:


Unfortunately, youtube-dl seems unmaintained:

And there are a lot of unanswered issues about it, e.g.:

There is no official successor but fortunately things seem to converge
on the yt-dlp fork:

@SuperSamus
Copy link
Contributor

youtube-dl just got a new version, actually.
https://github.com/ytdl-org/youtube-dl/releases/tag/2021.12.17

@AndersonTorres
Copy link
Member

Was this solved? O.o

@colemickens
Copy link
Member

Everything I'm reading online points to 'we should probably package youtube-dlp and then let users choose which fork they want to use.

@AndersonTorres
Copy link
Member

Everything I'm reading online points to 'we should probably package youtube-dlp and then let users choose which fork they want to use.

It was already packaged.

@YoshiRulz
Copy link
Contributor Author

As for

Was this solved?

I've switched to yt-dlp to stem the bleeding until I have time to write a faster replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

6 participants