Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run nixpkgs-lint in travis #17458

Closed
copumpkin opened this issue Aug 2, 2016 · 4 comments
Closed

Run nixpkgs-lint in travis #17458

copumpkin opened this issue Aug 2, 2016 · 4 comments
Labels
0.kind: enhancement Add something new

Comments

@copumpkin
Copy link
Member

Seems like it would be helpful to run it on the diff to give people early feedback about common issues.

@matthewbauer
Copy link
Member

There's a lot of warning on in master, so we may need to fix those first.

copumpkin referenced this issue Aug 2, 2016
Build-tested on x86_64 Linux & Mac.
@copumpkin
Copy link
Member Author

The ideal would be for the linter to only warn about lines you've touched, but that seems tricky.

Then we can whittle down the overall number of lint errors and also make it hard to add new ones.

@FRidh FRidh added the 0.kind: enhancement Add something new label Aug 2, 2016
@cmfwyp
Copy link
Member

cmfwyp commented Aug 3, 2016

A simple solution is to check only the files modified. The list of files modified can be found with git diff --numstat HEAD~1. This means nixpkgs-lint needs to accept an argument for a file to only check that file instead of checking all of Nixpkgs.

Also, this might be a duplicate of #11265.

@copumpkin
Copy link
Member Author

Oh, it is a dupe, sorry. I'll close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new
Projects
None yet
Development

No branches or pull requests

4 participants