Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/matrix-synapse: use registration_shared_secret_path #202694

Closed
RyanGibb opened this issue Nov 24, 2022 · 2 comments
Closed

nixos/matrix-synapse: use registration_shared_secret_path #202694

RyanGibb opened this issue Nov 24, 2022 · 2 comments
Labels
0.kind: bug Something is broken

Comments

@RyanGibb
Copy link
Contributor

RyanGibb commented Nov 24, 2022 •
edited
Loading

As services.matrix-synapse.settings.registration_shared_secret says...

nixpkgs/nixos/modules/services/matrix/matrix-synapse.nix

Line 237 in f10cdcf

Secrets should be passed in via <literal>extraConfigFiles</literal>!

In order to avoid putting secrets in the public nix store NixOS/nix#8

matrix-org/synapse#13614 adds support for registration_shared_secret_path, which allows us to point to a path with the shared secret. This would be a cleaner solution.

Notify maintainers

From teams.matrix.members:
@Ma27
@fadenb
@mguentner
@Ekleog
@Ralith
@dandellion
@sumnerevans
@RyanGibb RyanGibb added the 0.kind: bug Something is broken label Nov 24, 2022
@Ma27
Copy link
Member

Ma27 commented Nov 24, 2022

FWIW settings is already a freeform type, so you can already use that option.

@RyanGibb
Copy link
Contributor Author

Thank you @Ma27! I believe that resolves this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ma27 @RyanGibb