Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

by-name checks do not show the command needed to reproduce locally #266931

Closed
ghost opened this issue Nov 11, 2023 · 1 comment
Closed

by-name checks do not show the command needed to reproduce locally #266931

ghost opened this issue Nov 11, 2023 · 1 comment
Labels
0.kind: bug Something is broken
Milestone
RFC 140

Comments

@ghost
Copy link

ghost commented Nov 11, 2023 •
edited by ghost
Loading

The by-name checks need to emit a series of command invocations which are sufficient to reproduce exactly what github is doing, locally, outside of github.

Right now the by-name checks aren't written in bash or nixpkgs; they're written in github.

Working on a fix.
@ghost ghost added the 0.kind: bug Something is broken label Nov 11, 2023
@ghost ghost self-assigned this Nov 11, 2023
@ghost ghost mentioned this issue Nov 11, 2023
Closed
13 tasks
@infinisil infinisil added this to the RFC 140 milestone Nov 13, 2023
@infinisil infinisil mentioned this issue Dec 16, 2023
Merged
4 tasks
@infinisil
Copy link
Member

This is now addressed with #274591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken
Projects
None yet
Milestone
RFC 140
Development

Successfully merging a pull request may close this issue.

nixpkgs-check-by-name: make all github-driven checks locally reproducible
1 participant
@infinisil