-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another call for Darwin maintainers #323144
Comments
Thanks for the initiative @toonn. Until something official gets set up, I will take Domen's place to add new members. |
Thank you, Jonas! I went through the tail end of the previous issue up to the first person already part of the team. @cidkidnix, @khaneliman, @iFreilicht, @heywoodlh, @DontEatOreo, @siriobalmelli, @matteo-pacini and @afh, welcome to the team. |
I have two x86_64-darwin machines, I'm interested in helping whenever I can :) |
Added @Guanran928, welcome to the team! |
I'm running Nix on aarch64-darwin machines with nix-darwin and home-manager. I'd like to support maintaining Nix on macOS. :) (I'd happily support Nixpkgs, not only on macOS-related topics. I don't know anything about the processes for "applying" to help.) |
Btw. If the maintainer of nix-darwin wants get builder for their CI, in nix-community we should have enough builder capacity by now. Just drop by in our matrix channel. I now also have macOS laptop so I can test/port my software to it as you can see from my projects like this: nix-community/srvos#441 |
Thanks for the offer @Mic92! We currently don’t have elaborate enough testing in nix-darwin for it to really be worthwhile but VM tests is something we’ve tried working towards before, so it might be helpful for us in future. |
I can help out a bit on the weekends 🙂 |
Please also onboard me. I borrowed |
I'd be happy to help out using the community darwin builder for the moment before I'm able to get myself a darwin system sometime soon. |
I have an |
@emilazy I actually wrote a scriptable VM harness that I planned to PR to nix-darwin at some point, but life got in the way. If you'd like, I can definitely throw up the code somewhere, for inspiration if nothing else? |
@winterqt Sure, that would be great to see! I know @Enzime put work into this too; IIRC the hard parts involved automating macOS installation in AArch64 VMs. I wanted to try and keep similar code paths on That said, we should probably keep this issue focused on people joining the Darwin maintainers team – I’m available in #nix-darwin-dev:matrix.org or via email if you want to share what you got working. |
Invited @juliusrickert, @Aleksanaa, @kashw2 and @thecaralice. Welcome to the team! |
@toonn , I would like to be part of this as well. I only have a |
How does one test PRs? Wouldn't trust my comments on reviews but I could at least try build some. |
If you are mentioned or asked to review, you will most likely be asked to test on darwin, modify dependencies and add common workarounds. But normally you just need to add some packages under darwin.apple_sdk according to the build failure. |
How does one do that exactly? Asking for link to docs. (I kind of understand how to get home-manager install packages, but getting specific packages from different sources is beyond me.) |
@eliandoran, invited. Welcome to the team! @tko, testing PRs is most conveniently done using nixpkgs-review. Though to actually give approval you should review the code changes. |
I am currently dedicating my time to this in my |
@yzx9, invited. Welcome to the team! Experience is appreciated but not a requirement as long as I have some interactions on issues/PRs to gauge whether or not someone's been helpful. |
I'm happy to help with this. Been running nix on an M1 for a little while. |
@shivaraj-bh, invited. Welcome to the team! |
Hello, I would like to help also. I have both Intel and M1 macOS machines. |
@jwiegley, invited. Welcome to the team! (I made heavy use of your Nix setup for Haskell when I started out, thank you! <3) |
@toonn Happy to help out where I can. I've been hacking on darwin for a while now, especially on cross-compilation support to Linux targets. |
@szlend, invited. Welcome to the team! |
Hi, i have a mac-arm with nixpkgs and flakes setup. I am happy to provide support where-ever i can |
I would like to participate, but need some direction - what exactly does reviewing/testing PRs involve? I'm mainly asking because build errors are already being caught by CI/ofborg |
The ofborg Darwin builders are usually overloaded, so even being able to run |
Likewise, I really like porting Nix on MacOS, got some cool stuff like Linux builders setup and I'd like to update unions-fuse for example |
@kdhingra307, your first PR looks good but I'd like to see another interaction or two, could you ping again when you've had more interactions on issues, PRs or Discourse or similar? @krad246, you don't need to be part of darwin-maintainers to contribute, in fact that's a prerequisite to joining. The main purpose of the team is to be a point of contact for contributors that run into Darwin-related issues. Check the paragraph in the OP mentioning "Requirements." Ping again when you've had a couple interactions in issues/PRs/Discourse to join the team. @gshpychka, passing your name to zimbatm. Welcome to the team! |
Hello, I'm isabel, and i would like to become a darwin maintainer. I have 30 merged PRs and have reviewed 72 merged PRs. And have a m1 darwin machine that I'm happy to test some PRs on. |
@isabelroses, invited. Welcome to the team! |
Hi, would love to help out! I have 31 merged PRs and have reviewed 41 PRs. My primary machine is an M1 MBP and I test most PRs on it, though I do occasionally review on my NixOS WSL machine. |
@uncenter, invited. Welcome to the team! |
Hi, Nix has been so refreshing keeping things consistent between my NixOS desktop and M2 MBP. So I would be happy to help in anyway I can if people are still needed. |
@sstubbs, I asked org owners to invite you since you weren't part of the NixOS org yet. lassulus responded so I think you should have an invite. When looking at your contributions I saw an open issue and PR that were left over after you submitted another PR obsoleting the first. Do try to include fixes/closes keywords in your commits or at least mention the PR number in issues/PRs that are related so things don't end up in a state of limbo. Welcome to the team! |
Thank you @toonn I have joined and will make sure to clean up other related issues/PRs going forward when needed. |
I'd be happy to help review and fix darwin packages as well. |
This issue has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/the-darwin-sdks-have-been-updated/55295/26 |
I am interested in helping review and fix darwin packages. I maintain some postgresql extension packages, and pgrx Rust packages that have darwin aarch64 compatibility in my own work. So I'd like to help out on the broader set of packages too. I am also trying to help the postgres foundation adopt nix, and have some darwin support. |
I would like to become a Darwin maintainer.
and have been daily using nix+nix-darwin on an |
@niklaskorz, @samrose, @azuwis, invited. Welcome to the team! |
We have a darwin-maintainers team, which is currently hovering around 50 members.
If you'd like to join the team, we're looking for help with the following:
Requirements for joining are minimal. We take a look at issues/PRs you've been involved in to make sure you are helpful and respectful rather than disruptive or rude.
Comments on issues that help confirm they're a problem are just as valid as PRs fixing popular packages. If you have a hard time contributing to the project in this way, a history of productive discussion on the NixOS Discourse or a similarly easily accessible place for public discussion can be considered.
You're welcome to join the Nix on MacOS community on Matrix whether or not you join the team.
If you want to help out but don't have access to aarch64-darwin hardware you can request access to the Darwin build box. Note that it's shared hardware so communicate in the Matrix room when you're doing stdenv rebuilds for a while. A great big thanks to @winterqt for starting that initiative and the Infra team for keeping it going!
Feel free to nominate yourself and help use bring macOS into a better state : )
This is a spiritual successor to #145230, thank you, Domen, for improving the state of Darwin support so far.
The text was updated successfully, but these errors were encountered: