Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocaml packages are not individually overridable #75485

Closed
nomeata opened this issue Dec 11, 2019 · 9 comments · Fixed by #113696
Closed

Ocaml packages are not individually overridable #75485

nomeata opened this issue Dec 11, 2019 · 9 comments · Fixed by #113696
Labels

Comments

@nomeata
Copy link
Contributor

nomeata commented Dec 11, 2019

I am facing the problem that I want to use Ocaml 4.08, but the base package in nixpkgs (1.11.1) is incompatible with 4.08.

I wanted to use a local overlay to bump it to 1.13, but it would not get picked up by other packages, and the reason seems to be that the package set in https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/ocaml-modules/janestreet/default.nix is a simple rec, and does not take part in the global fixed-point of nix packages. Shouln’t this file take base as a parameter and not be a rec set?

Is that intentionally or was it just an oversight? @vbgl?

@vbgl
Copy link
Contributor

vbgl commented Dec 11, 2019

Oversight. Do not hesitate to contribute improvements! Many thanks.

BTW, recent nixpkgs have base for OCaml 4.08 (0.12.2).

@nomeata
Copy link
Contributor Author

nomeata commented Dec 11, 2019

Thanks! I am always a bit hazy on the semantics of the various nixpkgs branches. With “recent” you mean master, but not yet any tagged “release”, right? (Especially if I want a high chance to find packages on cache.nixos.org)

@nomeata
Copy link
Contributor Author

nomeata commented Dec 11, 2019

Hmm, todays master (2cf477f) still has 0.11.1.

@nomeata
Copy link
Contributor Author

nomeata commented Dec 16, 2019

BTW, recent nixpkgs have base for OCaml 4.08 (0.12.2).

Is that on a particular branch maybe? (can't fine one, though)

@nomeata
Copy link
Contributor Author

nomeata commented Dec 16, 2019

Oh, now I see pkgs/development/ocaml-modules/janestreet/janePackage_0_12.nix :-)

@stale
Copy link

stale bot commented Jun 13, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 13, 2020
@nomeata
Copy link
Contributor Author

nomeata commented Jun 14, 2020

Seems to be still relevant

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 14, 2020
@stale
Copy link

stale bot commented Dec 12, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 12, 2020
@sternenseemann
Copy link
Member

This is still an issue with the janeStreet sub set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants
@nomeata @vbgl @sternenseemann and others