Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package request: JabRef 5 #86331

Closed
luxzeitlos opened this issue Apr 29, 2020 · 9 comments · Fixed by #101287
Closed

Package request: JabRef 5 #86331

luxzeitlos opened this issue Apr 29, 2020 · 9 comments · Fixed by #101287
Labels
0.kind: packaging request Request for a new package to be added

Comments

@luxzeitlos
Copy link
Contributor

JabRef 5
JabRef is an open source bibliography reference manager. The native file format used by JabRef is BibTeX, the standard LaTeX bibliography format. JabRef is a desktop application and works equally well on Windows, Linux, and Mac OS X.

While there is a JabRef Package it is the outdated Version 3.

Metadata

@luxzeitlos luxzeitlos added the 0.kind: packaging request Request for a new package to be added label Apr 29, 2020
@wamserma
Copy link
Member

We are still at the last 3 because JabRef 4 introduced some breaking changes that were not compatible with the state of Nixpkgs at that time, see #72423.
Things are looking better with JabRef, but the .jar is no longer shipped standalone. So downloading huge blob just to throw away much of it would be needed.
This is discussed upstream at JabRef/jabref#6340 and JabRef/jabref#5771 - so feel free to ask for the bare .jar in these threads or find someone to change the nix expression to build Jabref from source.

@tobiasdiez
Copy link

The JabRef team will not and cannot provide jar files anymore since this is no longer a supported distribution form in recent Java versions. Instead, we use jlink + jpackpage to package JabRef in form that includes all of the runtime dependencies (including the jre). We now also provide a deb package, so maybe this can be easily reused for nix as well.

(The linked issue concern a bug in our development workflow where unnecessary files are included in the build version, but this shouldn't be of any concern for further distribution for nix.)

@wamserma
Copy link
Member

@tobiasdiez Thanks for the feedback. I had an attempt at building the latest release from source, but hit an issue with jlink, see here: JabRef/jabref#6378
I did not retry yet with master and OpenJDK 14. Any ideas what causes this collision?

@tobiasdiez
Copy link

This looks to me indeed like a problem with JDK 13. Does it work with 14?

@wamserma
Copy link
Member

Building tag v5.0 with Java14 fails due to this issue: gradle/gradle#10248
(I did not yet try to bump Groovy to 2.5.9 on this tag.)

Building jabref/master with OpenJDK14 also fails with

> ./gradlew jlink
[...]
Error: Modules javafx.graphics and org.jabref.merged.module export package javafx.scene.layout to module org.jabref

@tobiasdiez
Copy link

Strange. The current master does compile on Linux as verified by our github build workflow...

Why do you need to compile JabRef yourself?

@wamserma
Copy link
Member

Why do you need to compile JabRef yourself?

It is the preferred way of packaging in nixpkgs.

@tyrion
Copy link

tyrion commented Jun 1, 2020

I also failed to compile JabRef from source under nixos (not sure if I did something wrong as I am no java expert). Anyway here is how I packaged JabRef 5, using the deb: https://gist.github.com/tyrion/7be8fec894181e881b7b6803d5772b76

I am not sure if this is good enough to be included in nixpkgs. Let me know if you want me to open a PR with this.

@Siedlerchr
Copy link

Can you plaese try with using the AdoptOpenJDK jdk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: packaging request Request for a new package to be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants