Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs-lint: don't find license with new syntax #9966

Closed
davidak opened this issue Sep 20, 2015 · 4 comments
Closed

nixpkgs-lint: don't find license with new syntax #9966

davidak opened this issue Sep 20, 2015 · 4 comments
Labels
0.kind: bug Something is broken

Comments

@davidak
Copy link
Member

davidak commented Sep 20, 2015

for example this has a correct license:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/system/ioping/default.nix#L17

but nixpkgs-lint don't recognize it:

$ nixpkgs-lint -f /home/davidak/nixpkgs/ -p ioping
=== Package meta information ===

ioping: Lacks a license

=== Package name collisions ===

=== Bottom line ===
Number of packages: 1
Number of bad names: 0
Number of missing maintainers: 0
Number of missing platforms: 0
Number of missing licenses: 1
Number of missing descriptions: 0
Number of bad descriptions: 0
Number of name collisions: 0
@pSub
Copy link
Member

pSub commented Nov 25, 2015

Fixed with NixOS/nix#712 in the next version of nix.

@vcunat
Copy link
Member

vcunat commented Nov 25, 2015

Thanks!

@vcunat vcunat closed this as completed Nov 25, 2015
@vcunat
Copy link
Member

vcunat commented Nov 25, 2015

Next step: have a bot using it on PRs :-)

@davidak
Copy link
Member Author

davidak commented Nov 25, 2015

@vcunat great idea. remind if basic meta-data is missing. would you create an issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

3 participants