python3Packages.xen: init at 4.19.0 #345171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CertainLach
requested review from
SigmaSquadron and
emilazy
and removed request for
natsukium
github-actions
bot
added
6.topic: python
6.topic: xen-project
CertainLach
commented
Sep 28, 2024
| @@ -17550,6 +17550,10 @@ self: super: with self; { | |||
| inherit (pkgs) graphviz; | |||
| }; | |||
|
|
|||
| xen = toPythonModule (pkgs.xen-slim.override { | |||
There was a problem hiding this comment.
Using xen-slim causes duplication of xen package in system closure, but xen can't be built with internal qemu on latest python.
I haven't found a good way to only build python package out of xen source tree, but it might be made better in future with dedicated python output.
There was a problem hiding this comment.
I'm still not exactly sure why we're shipping 24.11 with a clearly broken Meson. Have you tried using 3.12 but overriding the python package to include setuptools? I tried it myself a few weeks ago but didn't have any success, but it's probably because I'm not very familiar with the python ecosystem.
There was a problem hiding this comment.
I have tried adding setuptools to meson package itself, and it didn't work for me. Meson does something clever/stupid and can't find setuptools this way.
There was a problem hiding this comment.
...Python module is not required for qubes, as qubes has its own qubes-vmm-xen based off xen-slim, and we can only include relevant xen changes, but I wanted to add xen python package itself for easier testing.
CertainLach
force-pushed
the
xen/python-package
branch
from
bb21ee1 to
561007c
Compare
|
So, if I understood this correctly, |
ofborg
bot
added
11.by: package-maintainer
|
python3Packages.xen will is pinned to whatever version this package set is pinned to (python311Packages set will have it built with python 3.11, python312Packages with python 3.12, python310 with python 3.10). So, xen will be built for every supported python version here, and this is why I would like if we manage to build python package without building rest of xen. |
CertainLach
commented
Sep 28, 2024
CertainLach
force-pushed
the
xen/python-package
branch
2 times, most recently
from
ebf4d6b to
7b9c9c9
Compare
SigmaSquadron
approved these changes
Sep 28, 2024
SigmaSquadron
added
the
12.approvals: 1
|
Why... Result of nixpkgs-review pr 345171: 1 package marked as broken and skipped: 8 packages failed to build: |
|
Huh, did it only fail with 4.17? |
SigmaSquadron
removed
the
12.approvals: 1
|
Yep, only on 4.17. So, adding setuptools breaks distutils?.. |
|
Can we add a version condition to include |
CertainLach
force-pushed
the
xen/python-package
branch
from
7b9c9c9 to
ec70660
Compare
|
Result of 1 package marked as broken and skipped:
8 packages failed to build:
76 packages built:
|
|
Oh, it has failed again? Didn't noticed that, I thought everything is ok. Ah, that's 4.17-slim that's failing, due to newer python being used. I'll just switch it to python311 for 4.17-slim build. |
CertainLach
force-pushed
the
xen/python-package
branch
from
ec70660 to
34c22dd
Compare
CertainLach
force-pushed
the
xen/python-package
branch
from
34c22dd to
8de0512
Compare
|
Result of 1 package marked as broken and skipped:
89 packages built:
|
digitalrane
approved these changes
Sep 28, 2024
SigmaSquadron
added
12.approvals: 1
natsukium
reviewed
Sep 29, 2024
CertainLach
force-pushed
the
xen/python-package
branch
from
8de0512 to
4d67e28
Compare
|
Result of 1 package marked as broken and skipped:
67 packages failed to build:
22 packages built:
...forgot about overrides in xen/packages.nix |
CertainLach
force-pushed
the
xen/python-package
branch
from
4d67e28 to
26fb54e
Compare
|
Result of 1 package marked as broken and skipped:
89 packages built:
|
digitalrane
approved these changes
Sep 29, 2024
13 tasks
SigmaSquadron
approved these changes
Sep 29, 2024
SigmaSquadron
added
12.approvals: 2
hehongbo
approved these changes
Oct 1, 2024
hehongbo
added
12.approvals: 3+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.