-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x11docker: init at 5.4.1 #55723
x11docker: init at 5.4.1 #55723
Conversation
Just nuking nxproxy would break x2goclient. Ideally we could get multiple outputs from this build, similar to https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/nx |
IIRC, there is a separation of dev/bin outputs possible, maybe I can use it to further difference outputs of nxagent/nxproxy/libs? I'll check it out later |
You also need to patch shebangs, it currently fails with the following error locally:
|
this will come for free by not using |
Right, I forgot to check the gui. Thanks for the |
The gui fails with Output of `x11docker-gui`
It appears we need to package kaptain for that gui, so why not just disable that for now? The command line client is (at least to me) the most interesting part of x11docker. |
I'll see if I have enough time to test the package today. If the |
I am the developer of x11docker, and I stumbled over this thread yet. If there is anything needed to adjust x11docker for NixOS, please tell me. I once did some basic test runs in a NixOS VM, but did not check out all possible setups.
I am currently looking at the x11docker-gui runs as well with image |
The docker image didn't seem to work, or at least that's what I assume the error is. Cool thing you stumbled upon this so quickly, I was going to email you once this was merged to let you know your program got packaged. It's a really awesome tool and I'm excited to start packaging some proprietary X11 apps :) |
I didn't read through the entire Most of the occurrences can be solved by a simple |
* Add an alias with a deprecation warning for `nxproxy` to avoid an immediate breaking change. * Use the default shell used in the build environment (`stdenv.shell`) for patching. This shell is in the environment and thus used to patch scripts using `patchShebangs`. The shell is referenced as `stdenv.shell` in Makefiles to patch the remaining occurrences of `/bin/bash` in the build environment.
I pushed a simple commit to your branch that fixes my review. If it's fine for you, I'd go ahead and merge as I just tested |
Ignore my review (which I deleted), I didn't realize |
@jD91mZM2 thanks! |
Cross-ref: 10f37a3. |
The tarball job fails when warnings are detected (and blocks channel). And that's good, because `nix-env -qa` also gets these warnings. I'm afraid we still don't have a good way to deprecate attributes, exactly because the inability to distinguish these "listing actions" from explicit usage (direct or transitive).
@vcunat thanks a lot for fixing this and the elaboration in your commit message. I guess I was wrong here, so I'm sorry! Just out of interest, are there any proposals on how to properly deprecate attribute names (like a package in this case?) |
The most recent thread I know: NixOS/rfcs#33 |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS) (I think, it says this is the default)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)This adds a recipe for x11docker, and also the nxagent backend because it supports both seamless and desktop mode.