Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping meta.maintainers #70

Closed
FRidh opened this issue Feb 11, 2018 · 10 comments
Closed

Ping meta.maintainers #70

FRidh opened this issue Feb 11, 2018 · 10 comments

Comments

@FRidh
Copy link
Member

FRidh commented Feb 11, 2018

We still need to ping maintainers of packages/modules in case their expressions are modified.

Proposal:

  1. use nix-env to check which packages need to be rebuild
  2. retrieve for each package meta.position
  3. check if the file specified in 2) is in the diff. If so, ping the maintainers listed in somepkg.meta.maintainers.

The attributes are typically GitHub handles, but as far as I know there is no way in Nix to get that handle.

Two possible solutions to retrieve the handle:

  1. rewrite lib.maintainers (@handle in lib/maintainers.nix must be a github username nixpkgs#18352 (comment))
  2. use sed
@FRidh
Copy link
Member Author

FRidh commented Feb 11, 2018

Maintainers change in Nixpkgs: NixOS/nixpkgs#34842

@7c6f434c
Copy link
Member

I think there is also an option to have a separate table (in Nix or in CSV) of email-as-listed → github handle, full name, IRC nick…

@FRidh
Copy link
Member Author

FRidh commented Mar 18, 2018

Note the Nixpkgs change is in (NixOS/nixpkgs#36119)

@Profpatsch
Copy link
Member

Profpatsch commented Mar 19, 2018

I would love if someone implemented this for ofborg. https://github.com/ryantm/nix-update already uses the new github handles.

@grahamc
Copy link
Member

grahamc commented Mar 19, 2018

Step #3 seems particularly complicated... I wonder if @vcunat has had an opportunity to come up with a "root change" script?

@FRidh
Copy link
Member Author

FRidh commented Mar 19, 2018

@grahamc what is complicated about step 3? meta.position includes a filename. Or do you mean "it would be nice if there was a simpler solution"?

@vcunat
Copy link
Member

vcunat commented Mar 20, 2018

No, not yet.

@7c6f434c
Copy link
Member

Maybe label PRs about packages that miss maintainers, too? Got the idea after reading the discussion: NixOS/nixpkgs#54249

@dasJ
Copy link
Member

dasJ commented Nov 19, 2019

Is this still relevant? Ofborg already pings maintainers if they are in the org

@grahamc grahamc closed this as completed Nov 19, 2019
@grahamc
Copy link
Member

grahamc commented Nov 19, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants