Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self_loop on the start state is redundant #3

Open
roys174 opened this issue Oct 3, 2018 · 0 comments
Open

self_loop on the start state is redundant #3

roys174 opened this issue Oct 3, 2018 · 0 comments

Comments

@roys174
Copy link
Collaborator

roys174 commented Oct 3, 2018

The model doesn't add the restart_padding for the self-loop diagonal. This creates a small bug for in the plus-times semiring, as the model is considering matches starting from the beginning and taking multiple self-loops.

A simple solution is to give the first self-loop a fixed score of one. Similarly, we could do the same for the final self-loop, and avoid the max/sum-pooling of the final hidden states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant