From 9eb6caa197f525366a88523e5e45b1245edbcbdd Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Mon, 28 Aug 2023 20:13:36 +0300 Subject: [PATCH 01/15] Update workflow --- .github/workflows/main.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5528bf7..6eaeaeb 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -34,7 +34,7 @@ jobs: - { name: mac, ts: 'nts', compiler: 'clang', os: macos-11 } steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 # configure spx artifact name in next format: # {php}-{ts}-{os.name}-{compiler} @@ -42,7 +42,7 @@ jobs: - name: Set artifact name id: setup-artifact run: | - echo "::set-output name=spx_file_name::spx-php-${{ matrix.php }}-${{ matrix.ts }}-${{ matrix.name }}-${{ matrix.compiler }}" + echo "spx_file_name=spx-php-${{ matrix.php }}-${{ matrix.ts }}-${{ matrix.name }}-${{ matrix.compiler }}" >> $GITHUB_OUTPUT - name: Setup PHP uses: shivammathur/setup-php@v2 @@ -83,7 +83,7 @@ jobs: - name: Upload build artifacts after Failure if: failure() - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: debug-${{ steps.setup-artifact.outputs.spx_file_name }} path: | @@ -106,7 +106,7 @@ jobs: ./.github/release-notes.sh ./CHANGELOG.md - name: Upload build artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: ${{ steps.setup-artifact.outputs.spx_file_name }} path: ${{ steps.setup-artifact.outputs.spx_file_name }}.zip @@ -120,18 +120,18 @@ jobs: steps: - name: Checkout Code - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: fetch-depth: 1 - name: Get the release version id: get-version run: | - echo ::set-output name=version::${GITHUB_REF#refs/tags/} + echo "version=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT - name: Download SPX build artifacts id: download - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: path: ./build-artifacts From f14db476db5fdccd046eef4e650850c67a433f15 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 09:26:20 +0300 Subject: [PATCH 02/15] Move build process to action --- .../workflows/build-linux-mac-ext/action.yml | 42 +++++++++++++++++++ .github/workflows/main.yml | 41 ++---------------- 2 files changed, 46 insertions(+), 37 deletions(-) create mode 100644 .github/workflows/build-linux-mac-ext/action.yml diff --git a/.github/workflows/build-linux-mac-ext/action.yml b/.github/workflows/build-linux-mac-ext/action.yml new file mode 100644 index 0000000..78e97b1 --- /dev/null +++ b/.github/workflows/build-linux-mac-ext/action.yml @@ -0,0 +1,42 @@ +name: 'PHP Extension build action' +description: 'Build PHP extension for linux/mac' + +runs: + using: 'composite' + steps: + - name: Setup PHP + uses: shivammathur/setup-php@v2 + with: + php-version: ${{ matrix.php }} + + - name: Install dependencies + if: runner.os == 'macOS' + run: brew install zlib + + - name: phpize + run: phpize + + - name: Configure + run: | + if [ "${{ runner.os }}" = "macOS" ]; then + ./configure --with-zlib-dir=$(brew --prefix)/opt/zlib + else + ./configure + fi + + - name: Compile + run: | + make -j"$(getconf _NPROCESSORS_ONLN)" + sudo make install + + - name: Extension Info + run: | + php --ini + php -d extension=./modules/spx.so --ri spx + + - name: Run Tests + run: make test + env: + NO_INTERACTION: 1 + REPORT_EXIT_STATUS: 1 + TEST_PHP_ARGS: "--show-diff" \ No newline at end of file diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 6eaeaeb..ea4f177 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -21,7 +21,8 @@ jobs: strategy: fail-fast: false matrix: - php: [ '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ] + # php: [ '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ] + php: ['8.1'] name: - linux @@ -44,42 +45,8 @@ jobs: run: | echo "spx_file_name=spx-php-${{ matrix.php }}-${{ matrix.ts }}-${{ matrix.name }}-${{ matrix.compiler }}" >> $GITHUB_OUTPUT - - name: Setup PHP - uses: shivammathur/setup-php@v2 - with: - php-version: ${{ matrix.php }} - - - name: Install dependencies - if: runner.os == 'macOS' - run: brew install zlib - - - name: phpize - run: phpize - - - name: Configure - run: | - if [ "${{ runner.os }}" = "macOS" ]; then - ./configure --with-zlib-dir=$(brew --prefix)/opt/zlib - else - ./configure - fi - - - name: Compile - run: | - make -j"$(getconf _NPROCESSORS_ONLN)" - sudo make install - - - name: Extension Info - run: | - php --ini - php -d extension=./modules/spx.so --ri spx - - - name: Run Tests - run: make test - env: - NO_INTERACTION: 1 - REPORT_EXIT_STATUS: 1 - TEST_PHP_ARGS: "--show-diff" + - name: Build extension + uses: ./.github/workflows/build-linux-mac-ext - name: Upload build artifacts after Failure if: failure() From 5e981f1f5ddd18516e10439016f972b39233c485 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 09:34:17 +0300 Subject: [PATCH 03/15] add shell param --- .github/workflows/build-linux-mac-ext/action.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/build-linux-mac-ext/action.yml b/.github/workflows/build-linux-mac-ext/action.yml index 78e97b1..fbfe8be 100644 --- a/.github/workflows/build-linux-mac-ext/action.yml +++ b/.github/workflows/build-linux-mac-ext/action.yml @@ -10,13 +10,16 @@ runs: php-version: ${{ matrix.php }} - name: Install dependencies + shell: bash if: runner.os == 'macOS' run: brew install zlib - name: phpize + shell: bash run: phpize - name: Configure + shell: bash run: | if [ "${{ runner.os }}" = "macOS" ]; then ./configure --with-zlib-dir=$(brew --prefix)/opt/zlib @@ -25,16 +28,19 @@ runs: fi - name: Compile + shell: bash run: | make -j"$(getconf _NPROCESSORS_ONLN)" sudo make install - name: Extension Info + shell: bash run: | php --ini php -d extension=./modules/spx.so --ri spx - name: Run Tests + shell: bash run: make test env: NO_INTERACTION: 1 From 838d0be46cbd2653622eb1590ae8f4057cfb16d0 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 10:46:52 +0300 Subject: [PATCH 04/15] Add docker build for debian --- .github/workflows/build-debian-ext/Dockerfile | 25 +++++++++++++++++ .github/workflows/build-debian-ext/action.yml | 27 +++++++++++++++++++ .github/workflows/main.yml | 16 ++++++++--- 3 files changed, 64 insertions(+), 4 deletions(-) create mode 100644 .github/workflows/build-debian-ext/Dockerfile create mode 100644 .github/workflows/build-debian-ext/action.yml diff --git a/.github/workflows/build-debian-ext/Dockerfile b/.github/workflows/build-debian-ext/Dockerfile new file mode 100644 index 0000000..d5ea606 --- /dev/null +++ b/.github/workflows/build-debian-ext/Dockerfile @@ -0,0 +1,25 @@ +FROM debian:11.5-slim as builder + +LABEL Description="Base image with custom PHP version based on Debian" +LABEL name="spx-profiler-debian11" + +ENV DEBIAN_FRONTEND="noninteractive" +ARG PHP_VERSION + +RUN apt update && apt upgrade -y && \ + apt install --no-install-recommends -y \ + lsb-release \ + ca-certificates \ + apt-transport-https \ + software-properties-common \ + gnupg2 \ + wget \ + curl \ + git \ + make\ + zlib1g-dev \ + && \ + echo "deb https://packages.sury.org/php/ $(lsb_release -sc) main" | tee /etc/apt/sources.list.d/sury-php.list && \ + wget -qO - https://packages.sury.org/php/apt.gpg | apt-key add - && \ + apt update && \ + apt install -y php${PHP_VERSION}-dev diff --git a/.github/workflows/build-debian-ext/action.yml b/.github/workflows/build-debian-ext/action.yml new file mode 100644 index 0000000..e4b7fe0 --- /dev/null +++ b/.github/workflows/build-debian-ext/action.yml @@ -0,0 +1,27 @@ +name: 'PHP Extension build action' +description: 'Build PHP extension for debian using docker' + +runs: + using: 'composite' + steps: + - uses: docker/build-push-action@v2 + with: + push: false + tags: builder:${{ matrix.php }} + file: ${{ github.workspace }}/.github/workflows/build-debian-ext/Dockerfile + build-args: | + PHP_VERSION=${{ matrix.php }} + cache-from: type=gha + cache-to: type=gha,mode=max + + - name: Run the build process with Docker + shell: bash + uses: addnab/docker-run-action@v3 + with: + image: builder:${{ matrix.php }} + options: -v ${{ github.workspace }}:/php-spx + run: | + cd /php-spx + phpize + ./configure + make -j"$(getconf _NPROCESSORS_ONLN)" diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ea4f177..2b2355b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -26,13 +26,16 @@ jobs: name: - linux + - debian - mac include: # Linux - - { name: linux, ts: 'nts', compiler: 'gcc', os: ubuntu-20.04 } + - { name: linux, ts: 'nts', compiler: 'gcc', os: ubuntu-20.04 } + # Debian (docker) + - { name: debian, ts: 'nts', compiler: 'gcc', os: ubuntu-20.04 } # macOS - - { name: mac, ts: 'nts', compiler: 'clang', os: macos-11 } + - { name: mac, ts: 'nts', compiler: 'clang', os: macos-11 } steps: - uses: actions/checkout@v3 @@ -45,8 +48,13 @@ jobs: run: | echo "spx_file_name=spx-php-${{ matrix.php }}-${{ matrix.ts }}-${{ matrix.name }}-${{ matrix.compiler }}" >> $GITHUB_OUTPUT - - name: Build extension - uses: ./.github/workflows/build-linux-mac-ext + - name: Build extension for Ubuntu and macOS + if: ${{ matrix.name }} != 'debian' + uses: ./.github/workflows/build-linux-mac-ext + + - name: Build extension for Debian using docker + if: ${{ matrix.name }} == 'debian' + uses: ./.github/workflows/build-debian-ext - name: Upload build artifacts after Failure if: failure() From 09be2e9abab58cfdcf9dae3a1d4536d80d9c0aaa Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 10:48:56 +0300 Subject: [PATCH 05/15] Fix yaml syntax --- .github/workflows/build-debian-ext/action.yml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build-debian-ext/action.yml b/.github/workflows/build-debian-ext/action.yml index e4b7fe0..799c3d8 100644 --- a/.github/workflows/build-debian-ext/action.yml +++ b/.github/workflows/build-debian-ext/action.yml @@ -15,13 +15,12 @@ runs: cache-to: type=gha,mode=max - name: Run the build process with Docker - shell: bash uses: addnab/docker-run-action@v3 with: - image: builder:${{ matrix.php }} - options: -v ${{ github.workspace }}:/php-spx - run: | - cd /php-spx - phpize - ./configure - make -j"$(getconf _NPROCESSORS_ONLN)" + image: builder:${{ matrix.php }} + options: -v ${{ github.workspace }}:/php-spx + run: | + cd /php-spx + phpize + ./configure + make -j"$(getconf _NPROCESSORS_ONLN)" From 57fb88508fe857cfa0b39b2b956f181281136693 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 10:58:10 +0300 Subject: [PATCH 06/15] fix if condition --- .github/workflows/build-debian-ext/action.yml | 2 -- .github/workflows/main.yml | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-debian-ext/action.yml b/.github/workflows/build-debian-ext/action.yml index 799c3d8..1ca6024 100644 --- a/.github/workflows/build-debian-ext/action.yml +++ b/.github/workflows/build-debian-ext/action.yml @@ -11,8 +11,6 @@ runs: file: ${{ github.workspace }}/.github/workflows/build-debian-ext/Dockerfile build-args: | PHP_VERSION=${{ matrix.php }} - cache-from: type=gha - cache-to: type=gha,mode=max - name: Run the build process with Docker uses: addnab/docker-run-action@v3 diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 2b2355b..26ef808 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -49,11 +49,11 @@ jobs: echo "spx_file_name=spx-php-${{ matrix.php }}-${{ matrix.ts }}-${{ matrix.name }}-${{ matrix.compiler }}" >> $GITHUB_OUTPUT - name: Build extension for Ubuntu and macOS - if: ${{ matrix.name }} != 'debian' + if: matrix.name != 'debian' uses: ./.github/workflows/build-linux-mac-ext - name: Build extension for Debian using docker - if: ${{ matrix.name }} == 'debian' + if: matrix.name == 'debian' uses: ./.github/workflows/build-debian-ext - name: Upload build artifacts after Failure From 83e0441e2a466b5b35f74faa773373ea3e8aca1c Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 11:02:29 +0300 Subject: [PATCH 07/15] Fix path to dockerfile --- .github/workflows/build-debian-ext/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-debian-ext/action.yml b/.github/workflows/build-debian-ext/action.yml index 1ca6024..8084fc9 100644 --- a/.github/workflows/build-debian-ext/action.yml +++ b/.github/workflows/build-debian-ext/action.yml @@ -8,7 +8,7 @@ runs: with: push: false tags: builder:${{ matrix.php }} - file: ${{ github.workspace }}/.github/workflows/build-debian-ext/Dockerfile + file: ./.github/workflows/build-debian-ext/Dockerfile build-args: | PHP_VERSION=${{ matrix.php }} From dd94aeae028f1d984af8e53387aef681cfc60ca3 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 11:17:11 +0300 Subject: [PATCH 08/15] Enable layer caahe, test different php version --- .github/workflows/build-debian-ext/action.yml | 18 +++++++++++++++++- .github/workflows/main.yml | 6 +++--- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-debian-ext/action.yml b/.github/workflows/build-debian-ext/action.yml index 8084fc9..ce3992b 100644 --- a/.github/workflows/build-debian-ext/action.yml +++ b/.github/workflows/build-debian-ext/action.yml @@ -4,13 +4,29 @@ description: 'Build PHP extension for debian using docker' runs: using: 'composite' steps: - - uses: docker/build-push-action@v2 + - name: Cache Docker layers + uses: actions/cache@v3 + with: + path: /tmp/.buildx-cache + key: ${{ runner.os }}-buildx-${{ github.sha }} + restore-keys: | + ${{ runner.os }}-buildx- + + - uses: docker/build-push-action@v4 with: push: false tags: builder:${{ matrix.php }} file: ./.github/workflows/build-debian-ext/Dockerfile build-args: | PHP_VERSION=${{ matrix.php }} + cache-from: type=local,src=/tmp/.buildx-cache + cache-to: type=local,dest=/tmp/.buildx-cache-new + + - name: Move buildx cache + shell: bash + run: | + rm -rf /tmp/.buildx-cache + mv /tmp/.buildx-cache-new /tmp/.buildx-cache - name: Run the build process with Docker uses: addnab/docker-run-action@v3 diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 26ef808..b65808f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -22,7 +22,7 @@ jobs: fail-fast: false matrix: # php: [ '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ] - php: ['8.1'] + php: ['5.6', '7.1', '8.1'] name: - linux @@ -31,11 +31,11 @@ jobs: include: # Linux - - { name: linux, ts: 'nts', compiler: 'gcc', os: ubuntu-20.04 } + # - { name: linux, ts: 'nts', compiler: 'gcc', os: ubuntu-20.04 } # Debian (docker) - { name: debian, ts: 'nts', compiler: 'gcc', os: ubuntu-20.04 } # macOS - - { name: mac, ts: 'nts', compiler: 'clang', os: macos-11 } + # - { name: mac, ts: 'nts', compiler: 'clang', os: macos-11 } steps: - uses: actions/checkout@v3 From 0539e8e9179ac1794e95fa6bc658b431c6ad4bef Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 11:19:26 +0300 Subject: [PATCH 09/15] disable mac and linux builds --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index b65808f..07371dc 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,9 +25,9 @@ jobs: php: ['5.6', '7.1', '8.1'] name: - - linux + # - linux - debian - - mac + # - mac include: # Linux From b3bf570d093b05469c27e5d5036eb059e06b7f69 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 11:22:01 +0300 Subject: [PATCH 10/15] use buildx --- .github/workflows/build-debian-ext/action.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/build-debian-ext/action.yml b/.github/workflows/build-debian-ext/action.yml index ce3992b..5ba5fe6 100644 --- a/.github/workflows/build-debian-ext/action.yml +++ b/.github/workflows/build-debian-ext/action.yml @@ -12,6 +12,9 @@ runs: restore-keys: | ${{ runner.os }}-buildx- + - name: Set up Docker Buildx + uses: docker/setup-buildx-action@v2 + - uses: docker/build-push-action@v4 with: push: false From cefbf144cf594e48d2f335e498bd79ddb6bccf65 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 11:32:49 +0300 Subject: [PATCH 11/15] set output type docker on build stage --- .github/workflows/build-debian-ext/action.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-debian-ext/action.yml b/.github/workflows/build-debian-ext/action.yml index 5ba5fe6..601d354 100644 --- a/.github/workflows/build-debian-ext/action.yml +++ b/.github/workflows/build-debian-ext/action.yml @@ -18,6 +18,7 @@ runs: - uses: docker/build-push-action@v4 with: push: false + load: true tags: builder:${{ matrix.php }} file: ./.github/workflows/build-debian-ext/Dockerfile build-args: | From 1bcdf66be0a9501cae2e6bb9bf7641a5e9b3f407 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 11:43:04 +0300 Subject: [PATCH 12/15] Change cache key --- .github/workflows/build-debian-ext/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-debian-ext/action.yml b/.github/workflows/build-debian-ext/action.yml index 601d354..1a5325e 100644 --- a/.github/workflows/build-debian-ext/action.yml +++ b/.github/workflows/build-debian-ext/action.yml @@ -8,7 +8,7 @@ runs: uses: actions/cache@v3 with: path: /tmp/.buildx-cache - key: ${{ runner.os }}-buildx-${{ github.sha }} + key: ${{ runner.os }}-buildx-php${{ matrix.php }} restore-keys: | ${{ runner.os }}-buildx- From 4fdd5fd60462a25dab3e170282bd197e3f126cf8 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 11:44:21 +0300 Subject: [PATCH 13/15] Enable build matrix --- .github/workflows/main.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 07371dc..c1922fe 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -21,28 +21,27 @@ jobs: strategy: fail-fast: false matrix: - # php: [ '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ] - php: ['5.6', '7.1', '8.1'] + php: [ '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ] name: - # - linux + - linux - debian - # - mac + - mac include: # Linux - # - { name: linux, ts: 'nts', compiler: 'gcc', os: ubuntu-20.04 } + - { name: linux, ts: 'nts', compiler: 'gcc', os: ubuntu-20.04 } # Debian (docker) - { name: debian, ts: 'nts', compiler: 'gcc', os: ubuntu-20.04 } # macOS - # - { name: mac, ts: 'nts', compiler: 'clang', os: macos-11 } + - { name: mac, ts: 'nts', compiler: 'clang', os: macos-11 } steps: - uses: actions/checkout@v3 # configure spx artifact name in next format: # {php}-{ts}-{os.name}-{compiler} - # spx-php-8.1-nts-Linux-gcc + # spx-php-8.1-nts-linux-gcc - name: Set artifact name id: setup-artifact run: | From 2692024cf1092726b590d831761bde2126172c00 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Tue, 29 Aug 2023 11:56:59 +0300 Subject: [PATCH 14/15] Update changelog --- CHANGELOG.md | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 81f4c56..c8d0eb1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,21 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). -## [Unreleased](https://github.com/NoiseByNorthwest/php-spx/compare/0.4.13...HEAD) +## [Unreleased](https://github.com/NoiseByNorthwest/php-spx/compare/0.4.14...HEAD) + +### Added +- Added Debian builds to github workflow + + +## [v0.4.14](https://github.com/NoiseByNorthwest/php-spx/compare/0.4.13...0.4.14) + +### Added +- Added simple search feature +- Added custom metadata storage implementation +- Added `--enable-spx-dev` to compile with debug symbols + +### Fixed +- Fixed buffer overflow in str_builder ## [v0.4.13](https://github.com/NoiseByNorthwest/php-spx/compare/0.4.12...0.4.13) From 827ded061880845c61bb1766878b4325db49dde3 Mon Sep 17 00:00:00 2001 From: AlexNDRmac Date: Wed, 30 Aug 2023 18:00:16 +0300 Subject: [PATCH 15/15] Add extension to artifact filemane --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index c1922fe..d09c21a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -82,7 +82,7 @@ jobs: - name: Upload build artifact uses: actions/upload-artifact@v3 with: - name: ${{ steps.setup-artifact.outputs.spx_file_name }} + name: ${{ steps.setup-artifact.outputs.spx_file_name }}.zip path: ${{ steps.setup-artifact.outputs.spx_file_name }}.zip release: