Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array fields are not syntax highlighted #385

Closed
OmarTawfik opened this issue Feb 1, 2023 · 0 comments · Fixed by #443
Closed

array fields are not syntax highlighted #385

OmarTawfik opened this issue Feb 1, 2023 · 0 comments · Fixed by #443
Assignees
Labels
status:ready This issue is ready to be worked on

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Feb 1, 2023

Considering the following code:

// Here type `Foo` is green
contract Foo {
    // Same as here for type `string` 
    string first;
    // But `Bar` type is white
    Bar[] second;
    // And here `Bar` type is blue
    constructor(Bar[] bar) public {
      // Here `Bar` type is white again
      Bar[] x = new Bar[](10);
    }
}

This is how it is highlighted in editor today:

image

I suggest unifying how type names are colorized, as otherwise they indicate different semantics to readers.

@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Feb 1, 2023
@kanej kanej moved this to Todo in hardhat-vscode Feb 1, 2023
@kanej kanej self-assigned this Feb 7, 2023
@kanej kanej assigned antico5 and unassigned kanej Mar 9, 2023
@antico5 antico5 moved this from Todo to In Progress in hardhat-vscode Mar 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in hardhat-vscode Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants