Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Truffle adapter #45

Closed
kanej opened this issue Jan 26, 2022 · 1 comment · Fixed by #393
Closed

Add Truffle adapter #45

kanej opened this issue Jan 26, 2022 · 1 comment · Fixed by #393
Labels
status:ready This issue is ready to be worked on type:feature New feature or request

Comments

@kanej
Copy link
Member

kanej commented Jan 26, 2022

Taken from feedback: NomicFoundation/hardhat-vscode-feedback#4

Currently, we only show compilation errors for Hardhat projects. Different tools can compile the same codebase differently, leading to different compilation errors. For example, they may choose to use a different version of solc for a certain source file.

We need to detect when a project is using Truffle and get the compilation errors based on its compilation pipeline, ideally without reimplementing its logic.

@kanej kanej added the type:feature New feature or request label Jan 26, 2022
@kanej kanej added this to the Developer framework agnostic milestone Jan 2, 2023
@kanej
Copy link
Member Author

kanej commented Jan 2, 2023

We have added an adapter structure that allows other projects (other than hardhat) to be used from the language server.

Support for truffle consists of providing an implementation for this adapter that matches the truffle project structures.

@kanej kanej changed the title [Truffle support] Compilation errors Add Truffle adapter Jan 2, 2023
@kanej kanej added status:ready This issue is ready to be worked on priority:high labels Jan 2, 2023
@kanej kanej mentioned this issue Jan 3, 2023
3 tasks
@kanej kanej moved this to Todo in hardhat-vscode Feb 6, 2023
@kanej kanej moved this from Todo to In Review in hardhat-vscode Feb 22, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in hardhat-vscode Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on type:feature New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant