Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dapptools adapter #47

Closed
kanej opened this issue Jan 26, 2022 · 2 comments
Closed

Add Dapptools adapter #47

kanej opened this issue Jan 26, 2022 · 2 comments
Labels
status:ready This issue is ready to be worked on type:feature New feature or request
Milestone
Developer framewo...

Comments

@kanej
Copy link
Member

kanej commented Jan 26, 2022

This is feedback: NomicFoundation/hardhat-vscode-feedback#6

Currently, we only show compilation errors for Hardhat projects. Different tools can compile the same codebase differently, leading to different compilation errors. For example, they may choose to use a different version of solc for a certain source file.

We need to detect when a project is using Dapptools and get the compilation errors based on its compilation pipeline, ideally without reimplementing its logic.
@kanej kanej added the type:feature New feature or request label Jan 26, 2022
@kanej kanej added this to the Developer framework agnostic milestone Jan 2, 2023
@kanej kanej changed the title [Dapptools support] Compilation errors Add Dapptools adapter Jan 2, 2023
@kanej
Copy link
Member Author

kanej commented Jan 2, 2023

We have added an adapter structure that allows other projects (other than hardhat) to be used from the language server.

Support for dapptools consists of providing an implementation for this adapter that matches the dapptools project structures.

@kanej kanej added status:ready This issue is ready to be worked on priority:low labels Jan 2, 2023
@kanej kanej mentioned this issue Jan 3, 2023
Closed
3 tasks
@kanej kanej removed the priority:low label Jan 3, 2023
@kanej
Copy link
Member Author

kanej commented Feb 7, 2023

Dapptools has been superseded by foundry.

@kanej kanej closed this as completed Feb 7, 2023
@kanej kanej closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on type:feature New feature or request
Projects
hardhat-vscode
Status: Done
Milestone
Developer framework agnostic
Development

No branches or pull requests
1 participant
@kanej