Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumes Foundry installation location #354

Closed
frangio opened this issue Jan 3, 2023 · 1 comment · Fixed by #366
Closed

Assumes Foundry installation location #354

frangio opened this issue Jan 3, 2023 · 1 comment · Fixed by #366
Labels
status:ready This issue is ready to be worked on type:bug Something isn't working

Comments

@frangio
Copy link

frangio commented Jan 3, 2023

The location of the forge executable is assumed to be ~/.foundry/bin/forge on non-Windows. I think this is the location where foundryup installs, but it can also be installed by other means in other locations in the $PATH.

Error: Command failed: ~/.foundry/bin/forge config --json
/bin/sh: line 1: ~/.foundry/bin/forge: No such file or directory
@antico5
Copy link
Collaborator

antico5 commented Jan 3, 2023

Thanks for pointing it out. Initially we were using forge directly but had the issue that depending how vscode was launched, that command could be visible or not. A good improvement would be to try to run forge directly, then fall back to the default installation directory (current), and then error if neither are found.

@kanej kanej added this to the Standalone language server milestone Jan 4, 2023
@kanej kanej added status:ready This issue is ready to be worked on type:bug Something isn't working labels Jan 4, 2023
@kanej kanej moved this to Todo in hardhat-vscode Jan 4, 2023
@antico5 antico5 moved this from Todo to Done in hardhat-vscode Jan 18, 2023
@kanej kanej moved this from Done to In Progress in hardhat-vscode Jan 19, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in hardhat-vscode Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on type:bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants