Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display User Details for Teacher and Admin #196

Open
2 tasks
uier opened this issue Mar 2, 2023 · 4 comments
Open
2 tasks

Display User Details for Teacher and Admin #196

uier opened this issue Mar 2, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@uier
Copy link
Member

uier commented Mar 2, 2023

  • Course Members: email
  • Admin Users: email, active
@Bogay
Copy link
Member

Bogay commented Mar 4, 2023

所以我們要直接把這些資訊放進 user.info 內？

@uier
Copy link
Member Author

uier commented Mar 5, 2023

所以我們要直接把這些資訊放進 user.info 內？

ummm 未必，只有課程內 Members 頁面的表格和 Admin 管理 Users 的表格會需要展示，其他地方沒有需求

@Bogay Bogay added the good first issue Good for newcomers label Mar 10, 2023
@Bogay
Copy link
Member

Bogay commented Mar 13, 2023

看起來目前這邊是透過不同的 API 取得資料的，課程列表是包在 course API 回傳，而 admin 那邊則是 call user API。

比較直接的做法是直接修改這兩個 API 的回傳資料，或是可以討論看看是否能夠讓前端決定要拿什麼欄位就好？ @uier 你怎麼看

@uier
Copy link
Member Author

uier commented Mar 14, 2023

目前我不覺得需要讓前端決定要拿什麼欄位，所以沒有其他想法的話就前者（直接修改）

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bogay @uier