diff --git a/build/common.project.props b/build/common.project.props index cb64df91781..87fca675a27 100644 --- a/build/common.project.props +++ b/build/common.project.props @@ -20,7 +20,7 @@ netstandard2.0 $(NETFXTargetFramework);$(NETCoreTargetFrameworks) $(NETFXTargetFramework);$(NetStandardVersion) - $(NETFXTargetFramework);$(NetStandardVersion);netstandard2.1 + $(NETFXTargetFramework);$(NetStandardVersion);netcoreapp5.0 $([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), 'README.md'))\ $(RepositoryRootDirectory)build\ $(RepositoryRootDirectory)$(RepositoryName).sln diff --git a/build/common.targets b/build/common.targets index 5df4083e594..46cb591e410 100644 --- a/build/common.targets +++ b/build/common.targets @@ -16,7 +16,7 @@ - true + true false diff --git a/build/packages.targets b/build/packages.targets index bdcb29cf840..f7a4b30c8ae 100644 --- a/build/packages.targets +++ b/build/packages.targets @@ -7,7 +7,7 @@ 16.5.29714.20 16.153.0 16.5.126 - + 5.0.0-preview.3.20214.6 diff --git a/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj b/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj index 49c883a4f4d..390da2f9e78 100644 --- a/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj +++ b/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj @@ -1,8 +1,4 @@  - - true - - @@ -154,7 +150,6 @@ - @@ -168,7 +163,7 @@ Desktop/ - + CoreCLR/ diff --git a/src/NuGet.Core/NuGet.Commands/NuGet.Commands.csproj b/src/NuGet.Core/NuGet.Commands/NuGet.Commands.csproj index fdd17a2a28b..eabbf466d28 100644 --- a/src/NuGet.Core/NuGet.Commands/NuGet.Commands.csproj +++ b/src/NuGet.Core/NuGet.Commands/NuGet.Commands.csproj @@ -11,7 +11,7 @@ $(TargetFrameworksLibrary) $(NoWarn);CS1591;CS1574;CS1573;CS1584;CS1658 - $(NoWarn);CS1998 + $(NoWarn);CS1998 true true true diff --git a/src/NuGet.Core/NuGet.Packaging/NuGet.Packaging.csproj b/src/NuGet.Core/NuGet.Packaging/NuGet.Packaging.csproj index b8dc0be568e..60da7b462e9 100644 --- a/src/NuGet.Core/NuGet.Packaging/NuGet.Packaging.csproj +++ b/src/NuGet.Core/NuGet.Packaging/NuGet.Packaging.csproj @@ -1,4 +1,4 @@ - + true @@ -11,7 +11,7 @@ $(TargetFrameworksLibrary) $(NoWarn);CS1591;CS1574;CS1573;CS1572 - $(NoWarn);CS0414 + $(NoWarn);CS0414 true true true @@ -49,7 +49,7 @@ - + diff --git a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/MsbuildIntegrationTestFixture.cs b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/MsbuildIntegrationTestFixture.cs index c74f1775ba1..71655f023a0 100644 --- a/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/MsbuildIntegrationTestFixture.cs +++ b/test/NuGet.Core.FuncTests/Dotnet.Integration.Test/MsbuildIntegrationTestFixture.cs @@ -295,7 +295,7 @@ private void CopyRestoreArtifacts(string artifactsDirectory, string pathToSdkInC { var projectArtifactsFolder = new DirectoryInfo(Path.Combine(artifactsDirectory, projectName, toolsetVersion, "bin", configuration)); - IEnumerable frameworkArtifactFolders = projectArtifactsFolder.EnumerateDirectories().Where(folder => folder.FullName.Contains("netstandard2.1") || folder.FullName.Contains("netcoreapp5.0")); + IEnumerable frameworkArtifactFolders = projectArtifactsFolder.EnumerateDirectories().Where(folder => folder.FullName.Contains("netcoreapp5.0")); if (!frameworkArtifactFolders.Any()) { @@ -328,8 +328,8 @@ private void CopyPackSdkArtifacts(string artifactsDirectory, string pathToSdkInC const string packProjectName = "NuGet.Build.Tasks.Pack"; const string packTargetsName = "NuGet.Build.Tasks.Pack.targets"; // Copy the pack SDK. - //Order by fullname so that we can get the latest nestandard version. E.g. if we have both netstandard2.0 and netstandard2.1, netstandard2.1 will be selected. - var packProjectCoreArtifactsDirectory = new DirectoryInfo(Path.Combine(artifactsDirectory, packProjectName, toolsetVersion, "bin", configuration)).EnumerateDirectories("netstandard*").OrderBy(x => x.FullName).Last(); + // Pick the netstandard2.0 NuGet.Build.Tasks.Pack dll + var packProjectCoreArtifactsDirectory = new DirectoryInfo(Path.Combine(artifactsDirectory, packProjectName, toolsetVersion, "bin", configuration)).EnumerateDirectories("netstandard*").Single(); var packAssemblyDestinationDirectory = Path.Combine(pathToPackSdk, "CoreCLR"); // Be smart here so we don't have to call ILMerge in the VS build. It takes ~15s total. // In VisualStudio, simply use the non il merged version. @@ -505,7 +505,7 @@ private void PatchDepsJsonWithNewlyAddedDlls(string[] assemblyNames, string[] fi var assemblyPath = Path.Combine(Directory.GetCurrentDirectory(), assemblyName); var assemblyVersion = Assembly.LoadFile(assemblyPath).GetName().Version.ToString(); var assemblyFileVersion = FileVersionInfo.GetVersionInfo(assemblyPath).FileVersion; - var jproperty = new JProperty("lib/netstandard2.1/" + assemblyName, + var jproperty = new JProperty("lib/netcoreapp5.0/" + assemblyName, new JObject { new JProperty("assemblyVersion", assemblyVersion),