Enabled password encryption on .NET Core/Windows #813
Conversation
| @@ -55,8 +55,8 @@ do | |||
| if grep -q "netcoreapp1.0" "$testProject"; then | |||
| pushd $testDir | |||
|
|
|||
| echo "$DOTNET test $testDir --configuration release --framework netcoreapp1.0" | |||
There was a problem hiding this comment.
Shouldn't build.sh on Mac have -notrait Platform=Linux? And similar for build.sh on Linux?
There was a problem hiding this comment.
Good point! It definitely should.
|
How does a user of .NET CLI on Windows create a config file with an encrypted password? Does he have to use nuget.exe? |
| #else | ||
| if (!RuntimeEnvironmentHelper.IsWindows) | ||
| { | ||
| throw new NotSupportedException("Encryption is not supported on non-Windows platforms"); |
There was a problem hiding this comment.
I would expect this to be a resource string.
|
That's right the only way for a user to add encrypted credentials is to run |
|
Add resource string and |
Let's log an issue to add a test for this. As it stands today, we are lighting up a feature for .NET CLI on Windows without any end-to-end tests covering that feature.
|
|
LGTM |
Fixes NuGet/Home#1851 Enabled password encryption of source and proxy credentials on all Windows frameworks by replacing `#if !IS_CORECLR` with `RuntimeEnvironmentHelper.IsWindows` Updated tests. Also fixes NuGet/Home#2065 Introduced `Platform` xUnit trait to be able running OS specific tests. On Windows: ``` xunit <test-project> -notrait Platform=Linux -notrait Platform=Darwin ``` On Linux ``` xunit <test-project> -notrait Platform=Windows ```
alpaix
force-pushed
the
alpanov/encryption
branch
from
896508d to
bb7f380
Compare
Fixes NuGet/Home#1851
Enabled password encryption of source and proxy credentials on all Windows
frameworks by replacing
#if !IS_CORECLRwithRuntimeEnvironmentHelper.IsWindowsUpdated tests.
Also fixes NuGet/Home#2065
Introduced
PlatformxUnit trait to be able running OS specific tests.On Windows:
On Linux
//cc @emgarten @joelverhagen @rrelyea @rohit21agrawal @drewgil @jainaashish