Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advancements broken by joining game #169

Open
Nolij opened this issue Sep 25, 2021 · 0 comments
Open

Advancements broken by joining game #169

Nolij opened this issue Sep 25, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@Nolij
Copy link

Nolij commented Sep 25, 2021

I recently implemented some fun advancements in to my game and noticed that they worked before joining a game, but not during the game or after it ended until I rejoined or the server restarted. I was able to band-aid fix this by putting this snippet in the addPlayer and removePlayer methods for my game: player.getAdvancementTracker().reload(gameSpace.getServer().getAdvancementLoader());

It would be ideal if there were a toggle for this advancement blocking while in game (much like there is toggles for other things such as portals) (it doesn't work for all advancement triggers at the moment, only some, so it would have to be rewritten for that anyway), however they should certainly at least work after a player leaves a game by default.

@Gegy Gegy added the bug Something isn't working label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants